| Conditions | 1 |
| Total Lines | 382 |
| Code Lines | 331 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | # -*- coding: utf-8 -*- |
||
| 50 | def __init__(self, context, request): |
||
| 51 | super(SamplesView, self).__init__(context, request) |
||
| 52 | |||
| 53 | self.catalog = SAMPLE_CATALOG |
||
| 54 | self.contentFilter = { |
||
| 55 | "sort_on": "created", |
||
| 56 | "sort_order": "descending", |
||
| 57 | "isRootAncestor": True, # only root ancestors |
||
| 58 | } |
||
| 59 | |||
| 60 | self.title = self.context.translate(_("Samples")) |
||
| 61 | self.description = "" |
||
| 62 | |||
| 63 | self.show_select_column = True |
||
| 64 | self.form_id = "samples" |
||
| 65 | self.context_actions = {} |
||
| 66 | self.icon = "{}{}".format( |
||
| 67 | self.portal_url, "/senaite_theme/icon/sample") |
||
| 68 | |||
| 69 | self.url = api.get_url(self.context) |
||
| 70 | |||
| 71 | # Toggle some columns if the sampling workflow is enabled |
||
| 72 | sampling_enabled = api.get_setup().getSamplingWorkflowEnabled() |
||
| 73 | |||
| 74 | now = DateTime().strftime("%Y-%m-%d %H:%M") |
||
| 75 | |||
| 76 | self.columns = collections.OrderedDict(( |
||
| 77 | ("Priority", { |
||
| 78 | "title": "", |
||
| 79 | "index": "getPrioritySortkey", |
||
| 80 | "sortable": True, }), |
||
| 81 | ("Progress", { |
||
| 82 | "title": "Progress", |
||
| 83 | "index": "getProgress", |
||
| 84 | "sortable": True, |
||
| 85 | "toggle": True}), |
||
| 86 | ("getId", { |
||
| 87 | "title": _("Sample ID"), |
||
| 88 | "attr": "getId", |
||
| 89 | "replace_url": "getURL", |
||
| 90 | "index": "getId"}), |
||
| 91 | ("getClientOrderNumber", { |
||
| 92 | "title": _("Client Order"), |
||
| 93 | "sortable": True, |
||
| 94 | "toggle": False}), |
||
| 95 | ("Creator", { |
||
| 96 | "title": _("Creator"), |
||
| 97 | "index": "getCreatorFullName", |
||
| 98 | "sortable": True, |
||
| 99 | "toggle": True}), |
||
| 100 | ("Created", { |
||
| 101 | "title": _("Date Registered"), |
||
| 102 | "index": "created", |
||
| 103 | "toggle": False}), |
||
| 104 | ("SamplingDate", { |
||
| 105 | "title": _("Expected Sampling Date"), |
||
| 106 | "index": "getSamplingDate", |
||
| 107 | "toggle": sampling_enabled}), |
||
| 108 | ("getDateSampled", { |
||
| 109 | "title": _("Date Sampled"), |
||
| 110 | "toggle": True, |
||
| 111 | "type": "datetime", |
||
| 112 | "max": now, |
||
| 113 | "sortable": True}), |
||
| 114 | ("getDatePreserved", { |
||
| 115 | "title": _("Date Preserved"), |
||
| 116 | "toggle": False, |
||
| 117 | "type": "datetime", |
||
| 118 | "max": now, |
||
| 119 | "sortable": False}), # no datesort without index |
||
| 120 | ("getDateReceived", { |
||
| 121 | "title": _("Date Received"), |
||
| 122 | "toggle": False}), |
||
| 123 | ("getDueDate", { |
||
| 124 | "title": _("Due Date"), |
||
| 125 | "toggle": False}), |
||
| 126 | ("getDateVerified", { |
||
| 127 | "title": _("Date Verified"), |
||
| 128 | "input_width": "10", |
||
| 129 | "toggle": False}), |
||
| 130 | ("getDatePublished", { |
||
| 131 | "title": _("Date Published"), |
||
| 132 | "toggle": False}), |
||
| 133 | ("BatchID", { |
||
| 134 | "title": _("Batch ID"), |
||
| 135 | "index": "getBatchID", |
||
| 136 | "sortable": True, |
||
| 137 | "toggle": False}), |
||
| 138 | ("Client", { |
||
| 139 | "title": _("Client"), |
||
| 140 | "index": "getClientTitle", |
||
| 141 | "attr": "getClientTitle", |
||
| 142 | "replace_url": "getClientURL", |
||
| 143 | "toggle": True}), |
||
| 144 | ("ClientID", { |
||
| 145 | "title": _("Client ID"), |
||
| 146 | "index": "getClientID", |
||
| 147 | "attr": "getClientID", |
||
| 148 | "replace_url": "getClientURL", |
||
| 149 | "toggle": True}), |
||
| 150 | ("Province", { |
||
| 151 | "title": _("Province"), |
||
| 152 | "sortable": True, |
||
| 153 | "index": "getProvince", |
||
| 154 | "attr": "getProvince", |
||
| 155 | "toggle": False}), |
||
| 156 | ("District", { |
||
| 157 | "title": _("District"), |
||
| 158 | "sortable": True, |
||
| 159 | "index": "getDistrict", |
||
| 160 | "attr": "getDistrict", |
||
| 161 | "toggle": False}), |
||
| 162 | ("getClientReference", { |
||
| 163 | "title": _("Client Ref"), |
||
| 164 | "sortable": True, |
||
| 165 | "index": "getClientReference", |
||
| 166 | "toggle": False}), |
||
| 167 | ("getClientSampleID", { |
||
| 168 | "title": _("Client SID"), |
||
| 169 | "toggle": False}), |
||
| 170 | ("ClientContact", { |
||
| 171 | "title": _("Contact"), |
||
| 172 | "sortable": True, |
||
| 173 | "index": "getContactFullName", |
||
| 174 | "toggle": False}), |
||
| 175 | ("getSampleTypeTitle", { |
||
| 176 | "title": _("Sample Type"), |
||
| 177 | "sortable": True, |
||
| 178 | "toggle": True}), |
||
| 179 | ("getSamplePointTitle", { |
||
| 180 | "title": _("Sample Point"), |
||
| 181 | "sortable": True, |
||
| 182 | "index": "getSamplePointTitle", |
||
| 183 | "toggle": False}), |
||
| 184 | ("getStorageLocation", { |
||
| 185 | "title": _("Storage Location"), |
||
| 186 | "sortable": True, |
||
| 187 | "index": "getStorageLocationTitle", |
||
| 188 | "toggle": False}), |
||
| 189 | ("SamplingDeviation", { |
||
| 190 | "title": _("Sampling Deviation"), |
||
| 191 | "sortable": True, |
||
| 192 | "index": "getSamplingDeviationTitle", |
||
| 193 | "toggle": False}), |
||
| 194 | ("getSampler", { |
||
| 195 | "title": _("Sampler"), |
||
| 196 | "toggle": sampling_enabled}), |
||
| 197 | ("getPreserver", { |
||
| 198 | "title": _("Preserver"), |
||
| 199 | "sortable": False, |
||
| 200 | "toggle": False}), |
||
| 201 | ("getProfilesTitle", { |
||
| 202 | "title": _("Profile"), |
||
| 203 | "sortable": True, |
||
| 204 | "index": "getProfilesTitle", |
||
| 205 | "toggle": False}), |
||
| 206 | ("getAnalysesNum", { |
||
| 207 | "title": _("Number of Analyses"), |
||
| 208 | "sortable": True, |
||
| 209 | "index": "getAnalysesNum", |
||
| 210 | "toggle": False}), |
||
| 211 | ("getTemplateTitle", { |
||
| 212 | "title": _("Template"), |
||
| 213 | "sortable": True, |
||
| 214 | "index": "getTemplateTitle", |
||
| 215 | "toggle": False}), |
||
| 216 | ("Printed", { |
||
| 217 | "title": _("Printed"), |
||
| 218 | "sortable": False, |
||
| 219 | "index": "getPrinted", |
||
| 220 | "toggle": False}), |
||
| 221 | ("state_title", { |
||
| 222 | "title": _("State"), |
||
| 223 | "sortable": True, |
||
| 224 | "index": "review_state"}), |
||
| 225 | )) |
||
| 226 | |||
| 227 | # custom print transition |
||
| 228 | print_stickers = { |
||
| 229 | "id": "print_stickers", |
||
| 230 | "title": _("Print stickers"), |
||
| 231 | "url": "{}/workflow_action?action=print_stickers".format(self.url) |
||
| 232 | } |
||
| 233 | |||
| 234 | self.review_states = [ |
||
| 235 | { |
||
| 236 | "id": "default", |
||
| 237 | "title": _("Active"), |
||
| 238 | "contentFilter": { |
||
| 239 | "review_state": ( |
||
| 240 | "sample_registered", |
||
| 241 | "scheduled_sampling", |
||
| 242 | "to_be_sampled", |
||
| 243 | "sample_due", |
||
| 244 | "sample_received", |
||
| 245 | "to_be_preserved", |
||
| 246 | "to_be_verified", |
||
| 247 | "verified", |
||
| 248 | ), |
||
| 249 | "sort_on": "created", |
||
| 250 | "sort_order": "descending", |
||
| 251 | }, |
||
| 252 | "custom_transitions": [print_stickers], |
||
| 253 | "columns": self.columns.keys(), |
||
| 254 | }, { |
||
| 255 | "id": "to_be_sampled", |
||
| 256 | "title": _("To Be Sampled"), |
||
| 257 | "contentFilter": { |
||
| 258 | "review_state": ("to_be_sampled",), |
||
| 259 | "sort_on": "created", |
||
| 260 | "sort_order": "descending"}, |
||
| 261 | "custom_transitions": [print_stickers], |
||
| 262 | "columns": self.columns.keys() |
||
| 263 | }, { |
||
| 264 | "id": "to_be_preserved", |
||
| 265 | "title": _("To Be Preserved"), |
||
| 266 | "contentFilter": { |
||
| 267 | "review_state": ("to_be_preserved",), |
||
| 268 | "sort_on": "created", |
||
| 269 | "sort_order": "descending", |
||
| 270 | }, |
||
| 271 | "custom_transitions": [print_stickers], |
||
| 272 | "columns": self.columns.keys(), |
||
| 273 | }, { |
||
| 274 | "id": "scheduled_sampling", |
||
| 275 | "title": _("Scheduled sampling"), |
||
| 276 | "contentFilter": { |
||
| 277 | "review_state": ("scheduled_sampling",), |
||
| 278 | "sort_on": "created", |
||
| 279 | "sort_order": "descending", |
||
| 280 | }, |
||
| 281 | "custom_transitions": [print_stickers], |
||
| 282 | "columns": self.columns.keys(), |
||
| 283 | }, { |
||
| 284 | "id": "sample_due", |
||
| 285 | "title": _("Due"), |
||
| 286 | "contentFilter": { |
||
| 287 | "review_state": ( |
||
| 288 | "to_be_sampled", |
||
| 289 | "to_be_preserved", |
||
| 290 | "sample_due"), |
||
| 291 | "sort_on": "created", |
||
| 292 | "sort_order": "descending"}, |
||
| 293 | "custom_transitions": [print_stickers], |
||
| 294 | "columns": self.columns.keys(), |
||
| 295 | }, { |
||
| 296 | "id": "sample_received", |
||
| 297 | "title": _("Received"), |
||
| 298 | "contentFilter": { |
||
| 299 | "review_state": "sample_received", |
||
| 300 | "sort_on": "created", |
||
| 301 | "sort_order": "descending", |
||
| 302 | }, |
||
| 303 | "custom_transitions": [print_stickers], |
||
| 304 | "columns": self.columns.keys(), |
||
| 305 | }, { |
||
| 306 | "id": "to_be_verified", |
||
| 307 | "title": _("To be verified"), |
||
| 308 | "contentFilter": { |
||
| 309 | "review_state": "to_be_verified", |
||
| 310 | "sort_on": "created", |
||
| 311 | "sort_order": "descending", |
||
| 312 | }, |
||
| 313 | "custom_transitions": [print_stickers], |
||
| 314 | "columns": self.columns.keys(), |
||
| 315 | }, { |
||
| 316 | "id": "verified", |
||
| 317 | "title": _("Verified"), |
||
| 318 | "contentFilter": { |
||
| 319 | "review_state": "verified", |
||
| 320 | "sort_on": "created", |
||
| 321 | "sort_order": "descending", |
||
| 322 | }, |
||
| 323 | "custom_transitions": [print_stickers], |
||
| 324 | "columns": self.columns.keys(), |
||
| 325 | }, { |
||
| 326 | "id": "published", |
||
| 327 | "title": _("Published"), |
||
| 328 | "contentFilter": { |
||
| 329 | "review_state": ("published"), |
||
| 330 | "sort_on": "created", |
||
| 331 | "sort_order": "descending", |
||
| 332 | }, |
||
| 333 | "custom_transitions": [], |
||
| 334 | "columns": self.columns.keys(), |
||
| 335 | }, { |
||
| 336 | "id": "dispatched", |
||
| 337 | "title": _("Dispatched"), |
||
| 338 | "flat_listing": True, |
||
| 339 | "confirm_transitions": ["restore"], |
||
| 340 | "contentFilter": { |
||
| 341 | "review_state": ("dispatched"), |
||
| 342 | "sort_on": "created", |
||
| 343 | "sort_order": "descending", |
||
| 344 | }, |
||
| 345 | "custom_transitions": [], |
||
| 346 | "columns": self.columns.keys(), |
||
| 347 | }, { |
||
| 348 | "id": "cancelled", |
||
| 349 | "title": _("Cancelled"), |
||
| 350 | "contentFilter": { |
||
| 351 | "review_state": "cancelled", |
||
| 352 | "sort_on": "created", |
||
| 353 | "sort_order": "descending", |
||
| 354 | }, |
||
| 355 | "custom_transitions": [], |
||
| 356 | "columns": self.columns.keys(), |
||
| 357 | }, { |
||
| 358 | "id": "invalid", |
||
| 359 | "title": _("Invalid"), |
||
| 360 | "contentFilter": { |
||
| 361 | "review_state": "invalid", |
||
| 362 | "sort_on": "created", |
||
| 363 | "sort_order": "descending", |
||
| 364 | }, |
||
| 365 | "custom_transitions": [print_stickers], |
||
| 366 | "columns": self.columns.keys(), |
||
| 367 | }, { |
||
| 368 | "id": "all", |
||
| 369 | "title": _("All"), |
||
| 370 | "contentFilter": { |
||
| 371 | "sort_on": "created", |
||
| 372 | "sort_order": "descending", |
||
| 373 | }, |
||
| 374 | "custom_transitions": [print_stickers], |
||
| 375 | "columns": self.columns.keys(), |
||
| 376 | }, { |
||
| 377 | "id": "rejected", |
||
| 378 | "title": _("Rejected"), |
||
| 379 | "contentFilter": { |
||
| 380 | "review_state": "rejected", |
||
| 381 | "sort_on": "created", |
||
| 382 | "sort_order": "descending", |
||
| 383 | }, |
||
| 384 | "custom_transitions": [print_stickers], |
||
| 385 | "columns": self.columns.keys(), |
||
| 386 | }, { |
||
| 387 | "id": "assigned", |
||
| 388 | "title": get_image("assigned.png", |
||
| 389 | title=t(_("Assigned"))), |
||
| 390 | "contentFilter": { |
||
| 391 | "assigned_state": "assigned", |
||
| 392 | "review_state": ("sample_received",), |
||
| 393 | "sort_on": "created", |
||
| 394 | "sort_order": "descending", |
||
| 395 | }, |
||
| 396 | "custom_transitions": [print_stickers], |
||
| 397 | "columns": self.columns.keys(), |
||
| 398 | }, { |
||
| 399 | "id": "unassigned", |
||
| 400 | "title": get_image("unassigned.png", |
||
| 401 | title=t(_("Unsassigned"))), |
||
| 402 | "contentFilter": { |
||
| 403 | "assigned_state": "unassigned", |
||
| 404 | "review_state": ( |
||
| 405 | "sample_received", |
||
| 406 | ), |
||
| 407 | "sort_on": "created", |
||
| 408 | "sort_order": "descending", |
||
| 409 | }, |
||
| 410 | "custom_transitions": [print_stickers], |
||
| 411 | "columns": self.columns.keys(), |
||
| 412 | }, { |
||
| 413 | "id": "late", |
||
| 414 | "title": get_image("late.png", |
||
| 415 | title=t(_("Late"))), |
||
| 416 | "contentFilter": { |
||
| 417 | # Query only for unpublished ARs that are late |
||
| 418 | "review_state": ( |
||
| 419 | "sample_received", |
||
| 420 | "to_be_verified", |
||
| 421 | "verified", |
||
| 422 | ), |
||
| 423 | "getDueDate": { |
||
| 424 | "query": DateTime(), |
||
| 425 | "range": "max", |
||
| 426 | }, |
||
| 427 | "sort_on": "created", |
||
| 428 | "sort_order": "descending", |
||
| 429 | }, |
||
| 430 | "custom_transitions": [print_stickers], |
||
| 431 | "columns": self.columns.keys(), |
||
| 432 | } |
||
| 766 |