seboettg / citeproc-php

src/Styles/DelimiterTrait.php

<?php
/*
 * citeproc-php
 *
 * @link        http://github.com/seboettg/citeproc-php for the source repository
 * @copyright   Copyright (c) 2016 Sebastian Böttger.
 * @license     https://opensource.org/licenses/MIT
 */

namespace Seboettg\CiteProc\Styles;

use SimpleXMLElement;

/**
 * Trait DelimiterTrait
 * @package Seboettg\CiteProc\Styles
 * @author Sebastian Böttger <seboettg@gmail.com>
 */
trait DelimiterTrait
{

    /**
     * @param SimpleXMLElement $node
     */
    protected function initDelimiterAttributes(SimpleXMLElement $node)
    {
        foreach ($node->attributes() as $attribute) {
            /** @var string $name */
            $name = (string) $attribute->getName();
            $value = (string) $attribute;

            switch ($name) {
                case 'delimiter':
                    $this->delimiter = $value;

The property delimiter does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

                    return;
            }
        }
    }
}