TextCaseTrait - Code Metrics - Inspection of "bug fix in number: text case / capitalizing of lon..." - seboettg/citeproc-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c41dc5...63b79a )

by Sebastian

created 2017-03-13 08:49 UTC

TextCaseTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	70
Duplicated Lines	20 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	14
lcom	1
cbo	1
dl	14
loc	70
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	initTextCaseAttributes()	14	14	3
D	applyTextCase()	0	35	9
A	keepNoCase()	0	7	2

How to fix Duplicated Code

<?php
/**
 * citeproc-php
 *
 * @link        http://github.com/seboettg/citeproc-php for the source repository
 * @copyright   Copyright (c) 2016 Sebastian Böttger.
 * @license     https://opensource.org/licenses/MIT
 */

namespace Seboettg\CiteProc\Styles;
use Seboettg\CiteProc\Util\StringHelper;


/**
 * Trait TextCase
 * @package Seboettg\CiteProc\Styles
 *
 * @author Sebastian Böttger <[email protected]>
 */
trait TextCaseTrait
{

    private $textCase;

    protected function initTextCaseAttributes(\SimpleXMLElement $node)

    {
        foreach ($node->attributes() as $attribute) {
            /** @var string $name */
            $name = $attribute->getName();
            $value = (string) $attribute;

            switch ($name) {
                case 'text-case':
                    $this->textCase = $value;
                    return;
            }
        }
    }

    /**
     * @param string $text
     * @param string $lang
     * @return string
     */
    public function applyTextCase($text, $lang = "en")
    {

        switch ($this->textCase) {
            case 'uppercase':
                $text = $this->keepNoCase(mb_strtoupper($text), $text);
                break;
            case 'lowercase':
                $text = $this->keepNoCase(mb_strtolower($text), $text);
                break;
            case 'sentence':
                if (StringHelper::checkUpperCaseString($text)) {
                    $text = mb_strtolower($text);
                    return StringHelper::mb_ucfirst($text);
                } else {
                    return StringHelper::mb_ucfirst($text);
                }
                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
            case 'capitalize-all':
                $text = $this->keepNoCase(StringHelper::capitalizeAll($text), $text);
                break;
            case 'title':
                if ($lang === "en") {
                    $text = $this->keepNoCase(StringHelper::capitalizeForTitle($text), $text);
                }
                break;
            case 'capitalize-first':
                $text = $this->keepNoCase(StringHelper::mb_ucfirst($text), $text);
                break;
            default:
switch ($expr) {
    default:
        doSomething(); //right
        break;
}


switch ($expr) {
    default:

        doSomething(); //wrong
        break;
}

        }

        return $text;
    }


    private function keepNoCase($render, $original)
    {
        if (preg_match('/<span class=\"nocase\">(\p{L}+)<\/span>/i', $original, $match)) {
            return preg_replace('/(<span class=\"nocase\">\p{L}+<\/span>)/i', $match[1], $render);
        }
        return $render;
    }
}

1		<?php
2		/**
3		* citeproc-php
4		*
5		* @link http://github.com/seboettg/citeproc-php for the source repository
6		* @copyright Copyright (c) 2016 Sebastian Böttger.
7		* @license https://opensource.org/licenses/MIT
8		*/
9
10		namespace Seboettg\CiteProc\Styles;
11		use Seboettg\CiteProc\Util\StringHelper;
12
13
14		/**
15		* Trait TextCase
16		* @package Seboettg\CiteProc\Styles
17		*
18		* @author Sebastian Böttger <[email protected]>
19		*/
20		trait TextCaseTrait
21		{
22
23		private $textCase;
24
25	View Code Duplication	protected function initTextCaseAttributes(\SimpleXMLElement $node)
		0 ignored issues – show Duplication introduced 2016-10-01 15:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
26		{
27		foreach ($node->attributes() as $attribute) {
28		/** @var string $name */
29		$name = $attribute->getName();
30		$value = (string) $attribute;
31
32		switch ($name) {
33		case 'text-case':
34		$this->textCase = $value;
35		return;
36		}
37		}
38		}
39
40		/**
41		* @param string $text
42		* @param string $lang
43		* @return string
44		*/
45		public function applyTextCase($text, $lang = "en")
46		{
47
48		switch ($this->textCase) {
49		case 'uppercase':
50		$text = $this->keepNoCase(mb_strtoupper($text), $text);
51		break;
52		case 'lowercase':
53		$text = $this->keepNoCase(mb_strtolower($text), $text);
54		break;
55		case 'sentence':
56		if (StringHelper::checkUpperCaseString($text)) {
57		$text = mb_strtolower($text);
58		return StringHelper::mb_ucfirst($text);
59		} else {
60		return StringHelper::mb_ucfirst($text);
61		}
62		break;
		0 ignored issues – show Unused Code introduced 2017-03-13 08:52 UTC by Report Bug Copy Issue Report `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
63		case 'capitalize-all':
64		$text = $this->keepNoCase(StringHelper::capitalizeAll($text), $text);
65		break;
66		case 'title':
67		if ($lang === "en") {
68		$text = $this->keepNoCase(StringHelper::capitalizeForTitle($text), $text);
69		}
70		break;
71		case 'capitalize-first':
72		$text = $this->keepNoCase(StringHelper::mb_ucfirst($text), $text);
73		break;
74		default:
		0 ignored issues – show Coding Style introduced 2016-10-01 15:57 UTC by Report Bug Copy Issue Report The default body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a default statement must start on the line immediately following the statement. switch ($expr) { default: doSomething(); //right break; } switch ($expr) { default: doSomething(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
75
76		}
77
78		return $text;
79		}
80
81
82		private function keepNoCase($render, $original)
83		{
84		if (preg_match('/<span class=\"nocase\">(\p{L}+)<\/span>/i', $original, $match)) {
85		return preg_replace('/(<span class=\"nocase\">\p{L}+<\/span>)/i', $match[1], $render);
86		}
87		return $render;
88		}
89		}

seboettg / citeproc-php

Push — master ( c41dc5...63b79a )

TextCaseTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like