Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 14 | class CiteProcHelper |
||
| 15 | { |
||
| 16 | |||
| 17 | /** |
||
| 18 | * Applies additional functions for markup extension |
||
| 19 | * |
||
| 20 | * @param \stdClass $dataItem the actual item |
||
| 21 | * @param string $valueToRender value the has to apply on |
||
| 22 | * @param string $renderedText actual by citeproc rendered text |
||
| 23 | * @return string |
||
| 24 | */ |
||
| 25 | public static function applyAdditionMarkupFunction($dataItem, $valueToRender, $renderedText) |
||
| 43 | |||
| 44 | /** |
||
| 45 | * @param array $array |
||
| 46 | * @return array |
||
| 47 | */ |
||
| 48 | public static function cloneArray(array $array) |
||
| 56 | } |
||
| 57 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.