Seboettg\CiteProc\Styles\DelimiterTrait

Complexity

Total Complexity

3

Size/Duplication

Total Lines	17
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	initDelimiterAttributes()	0	11	3

<?php
/*

You must use "/**" style comments for a file comment

 * citeproc-php
 *
 * @link        http://github.com/seboettg/citeproc-php for the source repository
 * @copyright   Copyright (c) 2016 Sebastian Böttger.
 * @license     https://opensource.org/licenses/MIT
 */

namespace Seboettg\CiteProc\Styles;

use SimpleXMLElement;

/**
 * Trait DelimiterTrait
 * @package Seboettg\CiteProc\Styles

There must be exactly one blank line before the tags in a doc comment

 * @author Sebastian Böttger <seboettg@gmail.com>

Tag value for @author tag indented incorrectly; expected 2 spaces but found 1

 */

Missing @category tag in class comment

Missing @license tag in class comment

Missing @link tag in class comment

trait DelimiterTrait
{

    /**

Missing short description in doc comment

     * @param SimpleXMLElement $node

Missing parameter comment

     */

Missing @return tag in function comment

    protected function initDelimiterAttributes(SimpleXMLElement $node)
    {
        foreach ($node->attributes() as $attribute) {
            /** @var string $name */

The open comment tag must be the only content on the line

Missing short description in doc comment

The close comment tag must be the only content on the line

            $name = (string) $attribute->getName();
            $value = (string) $attribute;

            switch ($name) {
                case 'delimiter':

Line indented incorrectly; expected 12 spaces, found 16

                    $this->delimiter = $value;

The property delimiter does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

                    return;
            }
        }
    }
}