Variable::matchForVariable() - Code Metrics - Inspection of "refactoring" - seboettg/citeproc-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — new-api ( f151f9...5a646f )

by Sebastian

created 2021-01-03 11:33 UTC

Variable::matchForVariable() A

↳ Parent: Variable

Complexity

Conditions	5
Paths	6

Size

Total Lines	13
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	5

Importance

Changes

Metric	Value
cc	5
eloc	9
nc	6
nop	2
dl	0
loc	13
ccs	9
cts	9
cp	1
crap	5
rs	9.6111
c	0
b	0
f	0

<?php
declare(strict_types=1);
/*
 * citeproc-php
 *
 * @link        http://github.com/seboettg/citeproc-php for the source repository
 * @copyright   Copyright (c) 2016 Sebastian Böttger.
 * @license     https://opensource.org/licenses/MIT
 */

namespace Seboettg\CiteProc\Constraint;

use Seboettg\CiteProc\Config\RenderingMode;
use Seboettg\CiteProc\Rendering\Observer\RenderingObserver;
use Seboettg\CiteProc\Rendering\Observer\RenderingObserverTrait;
use stdClass;

/**
 * Class Variable
 * @package Seboettg\CiteProc\Choose\Constraint
 *
 * @author Sebastian Böttger <[email protected]>
 */
/** @noinspection PhpUnused */
class Variable extends AbstractConstraint implements RenderingObserver
{
    use RenderingObserverTrait;

    public function __construct(string $value, string $match = "any")

    {
        parent::__construct($value, $match);
        $this->initObserver();
    }

    /**
     * @param string $variable
     * @param stdClass $data
     * @return bool
     */
    protected function matchForVariable(string $variable, stdClass $data): bool
    {
        $variableExistInCitationItem = false;
        if ($this->mode->equals(RenderingMode::CITATION()) && isset($data->id)) {
            $id = $data->id;
            $citationItem = $this->citationItems->filter(function ($item) use ($id) {
                return $item->id === $id;
            })->current();
            if (!empty($citationItem)) {
                $variableExistInCitationItem = !empty($citationItem->{$variable});
            }
        }
        return !empty($data->{$variable}) || $variableExistInCitationItem;
    }
}


1		<?php
2		declare(strict_types=1);
3		/*
4		* citeproc-php
5		*
6		* @link http://github.com/seboettg/citeproc-php for the source repository
7		* @copyright Copyright (c) 2016 Sebastian Böttger.
8		* @license https://opensource.org/licenses/MIT
9		*/
10
11		namespace Seboettg\CiteProc\Constraint;
12
13		use Seboettg\CiteProc\Config\RenderingMode;
14		use Seboettg\CiteProc\Rendering\Observer\RenderingObserver;
15		use Seboettg\CiteProc\Rendering\Observer\RenderingObserverTrait;
16		use stdClass;
17
18		/**
19		* Class Variable
20		* @package Seboettg\CiteProc\Choose\Constraint
21		*
22		* @author Sebastian Böttger <[email protected]>
23		*/
24		/** @noinspection PhpUnused */
25		class Variable extends AbstractConstraint implements RenderingObserver
26		{
27		use RenderingObserverTrait;
28
29	50	public function __construct(string $value, string $match = "any")
		0 ignored issues – show Coding Style introduced 2021-01-03 11:37 UTC by Report Bug Copy Issue Report Incorrect spacing between argument "$match" and equals sign; expected 0 but found 1 Loading history... Coding Style introduced 2021-01-03 11:37 UTC by Report Bug Copy Issue Report Incorrect spacing between default value and equals sign for argument "$match"; expected 0 but found 1 Loading history...
30		{
31	50	parent::__construct($value, $match);
32	50	$this->initObserver();
33	50	}
34
35		/**
36		* @param string $variable
37		* @param stdClass $data
38		* @return bool
39		*/
40	40	protected function matchForVariable(string $variable, stdClass $data): bool
41		{
42	40	$variableExistInCitationItem = false;
43	40	if ($this->mode->equals(RenderingMode::CITATION()) && isset($data->id)) {
44	8	$id = $data->id;
45		$citationItem = $this->citationItems->filter(function ($item) use ($id) {
46	3	return $item->id === $id;
47	8	})->current();
48	8	if (!empty($citationItem)) {
49	3	$variableExistInCitationItem = !empty($citationItem->{$variable});
50		}
51		}
52	40	return !empty($data->{$variable}) \|\| $variableExistInCitationItem;
53		}
54		}
55

seboettg / citeproc-php

Push — new-api ( f151f9...5a646f )

Variable::matchForVariable() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like