Seboettg\CiteProc\Rendering\Date\DateRange\YearRenderer

Complexity

Total Complexity

7

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	parseDateRange()	0	17	7

<?php
/*

You must use "/**" style comments for a file comment

 * citeproc-php: DateRangeYearParser.php
 * User: Sebastian Böttger <sebastian.boettger@thomascook.de>
 * created at 03.11.19, 20:01
 */

namespace Seboettg\CiteProc\Rendering\Date\DateRange;

use Seboettg\CiteProc\Rendering\Date\DatePart;
use Seboettg\CiteProc\Rendering\Date\DateTime;
use Seboettg\Collection\ArrayList;

/**
 * Class DateRangeYearRenderer
 * @package Seboettg\CiteProc\Rendering\Date

There must be exactly one blank line before the tags in a doc comment

 */

Missing @category tag in class comment

Missing @author tag in class comment

Missing @license tag in class comment

Missing @link tag in class comment

class YearRenderer extends DateRangeRenderer
{

    /**

Missing short description in doc comment

     * @param ArrayList<DatePart> $dateParts

Missing parameter comment

Tag value for @param tag indented incorrectly; expected 2 spaces but found 1

     * @param DateTime $from

Missing parameter comment

Expected 12 spaces after parameter type; 1 found

Tag value for @param tag indented incorrectly; expected 2 spaces but found 1

     * @param DateTime $to

Missing parameter comment

Expected 12 spaces after parameter type; 1 found

Tag value for @param tag indented incorrectly; expected 2 spaces but found 1

     * @param $delimiter

Missing parameter comment

Tag value for @param tag indented incorrectly; expected 2 spaces but found 1

     * @return string

Tag @return cannot be grouped with parameter tags in a doc comment

     */
    public function parseDateRange(ArrayList $dateParts, DateTime $from, DateTime $to, $delimiter)
    {
        $ret = "";
        foreach ($dateParts as $key => $datePart) {
            if (strpos($key, "year") !== false) {
                $ret .= $this->renderOneRangePart($datePart, $from, $to, $delimiter);
            }
            if (strpos($key, "month") !== false) {
                $day = !empty($d = $from->getMonth()) ? $d : "";
                $ret .= $day;
            }
            if (strpos($key, "day") !== false) {
                $day = !empty($d = $from->getDay()) ? $datePart->render($from, $this->parentDateObject) : "";

The assignment to $d is dead and can be removed.

                $ret .= $day;
            }
        }
        return $ret;
    }
}