Seboettg\CiteProc\Rendering\Date\DateRange\DayRenderer::parseDateRange()

Complexity

Conditions	4
Paths	1

Size

Total Lines	16
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function parseDateRange(ListInterface $datePartsList, DateTime $from, DateTime $to, string $delimiter): string
    {
        return $datePartsList->mapNotNull(function (Pair $pair) use ($from, $to, $delimiter) {
            $key = $pair->getKey();
            $datePart = $pair->getValue();
            if (strpos($key, "year") !== false) {

It seems like $key can also be of type boolean; however, parameter $haystack of strpos() does only seem to accept string, maybe add an additional type check?

                return $datePart->render($from, $this->parentDateObject);
            }
            if (strpos($key, "month") !== false) {
                return $datePart->render($from, $this->parentDateObject);
            }
            if (strpos($key, "day")) {
                return $this->renderOneRangePart($datePart, $from, $to, $delimiter);
            }
            return null;
        })->joinToString("");
    }