AddressBookEntry

Complexity

Total Complexity

8

Size/Duplication

Total Lines	84
Duplicated Lines	0 %

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	getPhoneNumber()	0	3	1
A	compareTo()	0	3	1
A	getLastName()	0	3	1
A	getFirstName()	0	3	1
A	__construct()	0	6	1
A	getAddress()	0	3	1
A	equals()	0	3	1
A	getCompareValue()	0	3	1

<?php
/*
 * Forest: PhoneBookEntry.php
 * User: Sebastian Böttger <sebastian.boettger@thomascook.de>
 * created at 24.12.19, 14:57
 */

use Seboettg\Collection\Comparable\Comparable;
use Seboettg\Forest\Item\ItemInterface;

class AddressBookEntry implements ItemInterface
{

    /**
     * @var string
     */
    protected $firstName;

    /**
     * @var string
     */
    protected $lastName;

    /**
     * @var string
     */
    protected $address;

    /**
     * @var string
     */
    protected $phoneNumber;

    public function __construct(string $lastName, string $firstName, ?string $address = null, ?string $phoneNumber = null)
    {
        $this->lastName = $lastName;
        $this->firstName = $firstName;
        $this->address = $address;
        $this->phoneNumber = $phoneNumber;
    }

    public function getCompareValue()
    {
        return $this->lastName . "," . $this->firstName;
    }

    /**
     * @param Comparable|AddressBookEntry $b
     * @return int
     */
    public function compareTo(Comparable $b): int
    {
        return strcasecmp($this->getCompareValue(), $b->getCompareValue());

The method getCompareValue() does not exist on Seboettg\Collection\Comparable\Comparable. It seems like you code against a sub-type of Seboettg\Collection\Comparable\Comparable such as AddressBookEntry.

    }

    /**
     * @param ItemInterface|AddressBookEntry $item
     * @return bool
     */
    public function equals(ItemInterface $item): bool
    {
        return $this->compareTo($item) === 0;
    }

    /**
     * @return string
     */
    public function getFirstName(): string
    {
        return $this->firstName;
    }

    /**
     * @return string
     */
    public function getLastName(): string
    {
        return $this->lastName;
    }

    /**
     * @return string
     */
    public function getPhoneNumber(): string
    {
        return $this->phoneNumber;
    }

    /**
     * @return string
     */
    public function getAddress(): string
    {
        return $this->address;
    }

}