Issues in epubfs.php - All Issues - Inspection of "Improves opds validation" - seblucas/cops - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#488)

unknown

created 2020-10-14 19:52 UTC

epubfs.php (2 issues)

Labels

Duplication 2

Severity

Informational 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * COPS (Calibre OPDS PHP Server) class file
 *
 * @license    GPL 2 (http://www.gnu.org/licenses/gpl.html)
 * @author     Sébastien Lucas <[email protected]>
 */

require 'config.php';
require 'base.php';

function getComponentContent($book, $component, $add)
{
    $data = $book->component($component);

    $callback = function($m) use ($book, $component, $add) {
        $method = $m[1];
        $path = $m[2];
        $end = '';
        if (preg_match('/^src\s*:/', $method)) {
            $end = ')';
        }
        if (preg_match('/^#/', $path)) {
            return $method . "'" . $path . "'" . $end;
        }
        $hash = '';
        if (preg_match('/^(.+)#(.+)$/', $path, $matches)) {

            $path = $matches[1];
            $hash = '#' . $matches[2];
        }
        $comp = $book->getComponentName($component, $path);
        if (!$comp) {
            return $method . "'#'" . $end;
        }
        $out = $method . "'epubfs.php?" . $add . 'comp=' . $comp . $hash . "'" . $end;
        if ($end) {
            return $out;
        }
        return str_replace('&', '&amp;', $out);
    };

    $data = preg_replace_callback("/(src=)[\"']([^:]*?)[\"']/", $callback, $data);
    $data = preg_replace_callback("/(href=)[\"']([^:]*?)[\"']/", $callback, $data);
    $data = preg_replace_callback("/(\@import\s+)[\"'](.*?)[\"'];/", $callback, $data);
    $data = preg_replace_callback('/(src\s*:\s*url\()(.*?)\)/', $callback, $data);

    return $data;
}

if (php_sapi_name() === 'cli') {
    return;
}

$idData = getURLParam('data', NULL);
$add = 'data=' . $idData . '&';
if (!is_null(GetUrlParam(DB))) {

    $add .= DB . '=' . GetUrlParam(DB) . '&';
}
$myBook = Book::getBookByDataId($idData);

$book = new EPub($myBook->getFilePath('EPUB', $idData));

$book->initSpineComponent();

if (!isset($_GET['comp'])) {
    notFound();
    return;
}

$component = $_GET['comp'];

try {
    $data = getComponentContent($book, $component, $add);

    $expires = 60*60*24*14;
    header('Pragma: public');
    header('Cache-Control: maxage='.$expires);
    header('Expires: ' . gmdate('D, d M Y H:i:s', time()+$expires) . ' GMT');
    header ('Content-Type: ' . $book->componentContentType($component));
    echo $data;
} catch (Exception $e) {
    error_log($e);
    notFound();
}


1			<?php
2			/**
3			* COPS (Calibre OPDS PHP Server) class file
4			*
5			* @license GPL 2 (http://www.gnu.org/licenses/gpl.html)
6			* @author Sébastien Lucas <[email protected]>
7			*/
8
9			require 'config.php';
10			require 'base.php';
11
12			function getComponentContent($book, $component, $add)
13			{
14	7		$data = $book->component($component);
15
16			$callback = function($m) use ($book, $component, $add) {
17	7		$method = $m[1];
18	7		$path = $m[2];
19	7		$end = '';
20	7		if (preg_match('/^src\s*:/', $method)) {
21	1		$end = ')';
22			}
23	7		if (preg_match('/^#/', $path)) {
24	3		return $method . "'" . $path . "'" . $end;
25			}
26	7		$hash = '';
27	7	View Code Duplication	if (preg_match('/^(.+)#(.+)$/', $path, $matches)) {
			0 ignored issues – show Duplication introduced 2016-06-30 15:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
28	3		$path = $matches[1];
29	3		$hash = '#' . $matches[2];
30			}
31	7		$comp = $book->getComponentName($component, $path);
32	7		if (!$comp) {
33			return $method . "'#'" . $end;
34			}
35	7		$out = $method . "'epubfs.php?" . $add . 'comp=' . $comp . $hash . "'" . $end;
36	7		if ($end) {
37	1		return $out;
38			}
39	7		return str_replace('&', '&', $out);
40	7		};
41
42	7		$data = preg_replace_callback("/(src=)[\"']([^:]*?)[\"']/", $callback, $data);
43	7		$data = preg_replace_callback("/(href=)[\"']([^:]*?)[\"']/", $callback, $data);
44	7		$data = preg_replace_callback("/(\@import\s+)[\"'](.*?)[\"'];/", $callback, $data);
45	7		$data = preg_replace_callback('/(src\s:\surl\()(.*?)\)/', $callback, $data);
46
47	7		return $data;
48			}
49
50			if (php_sapi_name() === 'cli') {
51			return;
52			}
53
54			$idData = getURLParam('data', NULL);
55			$add = 'data=' . $idData . '&';
56		View Code Duplication	if (!is_null(GetUrlParam(DB))) {
			0 ignored issues – show Duplication introduced 2016-06-30 15:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
57			$add .= DB . '=' . GetUrlParam(DB) . '&';
58			}
59			$myBook = Book::getBookByDataId($idData);
60
61			$book = new EPub($myBook->getFilePath('EPUB', $idData));
62
63			$book->initSpineComponent();
64
65			if (!isset($_GET['comp'])) {
66			notFound();
67			return;
68			}
69
70			$component = $_GET['comp'];
71
72			try {
73			$data = getComponentContent($book, $component, $add);
74
75			$expires = 606024*14;
76			header('Pragma: public');
77			header('Cache-Control: maxage='.$expires);
78			header('Expires: ' . gmdate('D, d M Y H:i:s', time()+$expires) . ' GMT');
79			header ('Content-Type: ' . $book->componentContentType($component));
80			echo $data;
81			} catch (Exception $e) {
82			error_log($e);
83			notFound();
84			}
85

seblucas / cops

Pull Request — master (#488)

epubfs.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like