| Conditions | 11 |
| Paths | 72 |
| Total Lines | 78 |
| Code Lines | 63 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 70 |
| CRAP Score | 11 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 78 | 14 | private function startXmlDocument ($page) { |
|
| 79 | 14 | global $config; |
|
| 80 | 14 | self::getXmlStream ()->startDocument('1.0','UTF-8'); |
|
| 81 | 14 | self::getXmlStream ()->startElement ("feed"); |
|
| 82 | 14 | self::getXmlStream ()->writeAttribute ("xmlns", "http://www.w3.org/2005/Atom"); |
|
| 83 | 14 | self::getXmlStream ()->writeAttribute ("xmlns:xhtml", "http://www.w3.org/1999/xhtml"); |
|
| 84 | 14 | self::getXmlStream ()->writeAttribute ("xmlns:opds", "http://opds-spec.org/2010/catalog"); |
|
| 85 | 14 | self::getXmlStream ()->writeAttribute ("xmlns:opensearch", "http://a9.com/-/spec/opensearch/1.1/"); |
|
| 86 | 14 | self::getXmlStream ()->writeAttribute ("xmlns:dcterms", "http://purl.org/dc/terms/"); |
|
| 87 | 14 | self::getXmlStream ()->startElement ("title"); |
|
| 88 | 14 | self::getXmlStream ()->text ($page->title); |
|
| 89 | 14 | self::getXmlStream ()->endElement (); |
|
| 90 | 14 | if ($page->subtitle != "") |
|
| 91 | 14 | { |
|
| 92 | 1 | self::getXmlStream ()->startElement ("subtitle"); |
|
| 93 | 1 | self::getXmlStream ()->text ($page->subtitle); |
|
| 94 | 1 | self::getXmlStream ()->endElement (); |
|
| 95 | 1 | } |
|
| 96 | 14 | self::getXmlStream ()->startElement ("id"); |
|
| 97 | 14 | if ($page->idPage) |
|
| 98 | 14 | { |
|
| 99 | 13 | $idPage = $page->idPage; |
|
| 100 | 13 | if (!is_null (GetUrlParam (DB))) $idPage = str_replace ("cops:", "cops:" . GetUrlParam (DB) . ":", $idPage); |
|
| 101 | 13 | self::getXmlStream ()->text ($idPage); |
|
| 102 | 13 | } |
|
| 103 | else |
||
| 104 | { |
||
| 105 | 1 | self::getXmlStream ()->text ($_SERVER['REQUEST_URI']); |
|
| 106 | } |
||
| 107 | 14 | self::getXmlStream ()->endElement (); |
|
| 108 | 14 | self::getXmlStream ()->startElement ("updated"); |
|
| 109 | 14 | self::getXmlStream ()->text (self::getUpdatedTime ()); |
|
| 110 | 14 | self::getXmlStream ()->endElement (); |
|
| 111 | 14 | self::getXmlStream ()->startElement ("icon"); |
|
| 112 | 14 | self::getXmlStream ()->text ($page->favicon); |
|
| 113 | 14 | self::getXmlStream ()->endElement (); |
|
| 114 | 14 | self::getXmlStream ()->startElement ("author"); |
|
| 115 | 14 | self::getXmlStream ()->startElement ("name"); |
|
| 116 | 14 | self::getXmlStream ()->text ($page->authorName); |
|
| 117 | 14 | self::getXmlStream ()->endElement (); |
|
| 118 | 14 | self::getXmlStream ()->startElement ("uri"); |
|
| 119 | 14 | self::getXmlStream ()->text ($page->authorUri); |
|
| 120 | 14 | self::getXmlStream ()->endElement (); |
|
| 121 | 14 | self::getXmlStream ()->startElement ("email"); |
|
| 122 | 14 | self::getXmlStream ()->text ($page->authorEmail); |
|
| 123 | 14 | self::getXmlStream ()->endElement (); |
|
| 124 | 14 | self::getXmlStream ()->endElement (); |
|
| 125 | 14 | $link = new LinkNavigation ("", "start", "Home"); |
|
| 126 | 14 | self::renderLink ($link); |
|
| 127 | 14 | $link = new LinkNavigation ("?" . getQueryString (), "self"); |
|
| 128 | 14 | self::renderLink ($link); |
|
| 129 | 14 | $urlparam = "?"; |
|
| 130 | 14 | if (!is_null (GetUrlParam (DB))) { |
|
| 131 | 1 | $urlparam = addURLParameter ($urlparam, DB, GetUrlParam (DB)); |
|
| 132 | 1 | $urlparam = addURLParameter ($urlparam, VL, GetUrlParam (VL, 0)); |
|
| 133 | 1 | } |
|
| 134 | 14 | if ($config['cops_generate_invalid_opds_stream'] == 0 || preg_match("/(MantanoReader|FBReader)/", $_SERVER['HTTP_USER_AGENT'])) { |
|
| 135 | // Good and compliant way of handling search |
||
| 136 | 14 | $urlparam = addURLParameter ($urlparam, "page", Base::PAGE_OPENSEARCH); |
|
| 137 | 14 | $link = new Link ("feed.php" . $urlparam, "application/opensearchdescription+xml", "search", "Search here"); |
|
| 138 | 14 | } |
|
| 139 | else |
||
| 140 | { |
||
| 141 | // Bad way, will be removed when OPDS client are fixed |
||
| 142 | 1 | $urlparam = addURLParameter ($urlparam, "query", "{searchTerms}"); |
|
| 143 | 1 | $urlparam = str_replace ("%7B", "{", $urlparam); |
|
| 144 | 1 | $urlparam = str_replace ("%7D", "}", $urlparam); |
|
| 145 | 1 | $link = new Link ($config['cops_full_url'] . 'feed.php' . $urlparam, "application/atom+xml", "search", "Search here"); |
|
| 146 | } |
||
| 147 | 14 | self::renderLink ($link); |
|
| 148 | 14 | if ($page->containsBook () && !is_null ($config['cops_books_filter']) && count ($config['cops_books_filter']) > 0) { |
|
| 149 | 1 | $Urlfilter = getURLParam ("tag", ""); |
|
| 150 | 1 | foreach ($config['cops_books_filter'] as $lib => $filter) { |
|
| 151 | 1 | $link = new LinkFacet ("?" . addURLParameter (getQueryString (), "tag", $filter), $lib, localize ("tagword.title"), $filter == $Urlfilter); |
|
| 152 | 1 | self::renderLink ($link); |
|
| 153 | 1 | } |
|
| 154 | 1 | } |
|
| 155 | 14 | } |
|
| 156 | |||
| 275 |