Conditions | 11 |
Paths | 72 |
Total Lines | 75 |
Code Lines | 61 |
Lines | 0 |
Ratio | 0 % |
Tests | 67 |
CRAP Score | 11 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
75 | 14 | private function startXmlDocument ($page) { |
|
76 | 14 | global $config; |
|
77 | 14 | self::getXmlStream ()->startDocument('1.0','UTF-8'); |
|
78 | 14 | self::getXmlStream ()->startElement ("feed"); |
|
79 | 14 | self::getXmlStream ()->writeAttribute ("xmlns", "http://www.w3.org/2005/Atom"); |
|
80 | 14 | self::getXmlStream ()->writeAttribute ("xmlns:xhtml", "http://www.w3.org/1999/xhtml"); |
|
81 | 14 | self::getXmlStream ()->writeAttribute ("xmlns:opds", "http://opds-spec.org/2010/catalog"); |
|
82 | 14 | self::getXmlStream ()->writeAttribute ("xmlns:opensearch", "http://a9.com/-/spec/opensearch/1.1/"); |
|
83 | 14 | self::getXmlStream ()->writeAttribute ("xmlns:dcterms", "http://purl.org/dc/terms/"); |
|
84 | 14 | self::getXmlStream ()->startElement ("title"); |
|
85 | 14 | self::getXmlStream ()->text ($page->title); |
|
86 | 14 | self::getXmlStream ()->endElement (); |
|
87 | 14 | if ($page->subtitle != "") |
|
88 | 14 | { |
|
89 | 1 | self::getXmlStream ()->startElement ("subtitle"); |
|
90 | 1 | self::getXmlStream ()->text ($page->subtitle); |
|
91 | 1 | self::getXmlStream ()->endElement (); |
|
92 | 1 | } |
|
93 | 14 | self::getXmlStream ()->startElement ("id"); |
|
94 | 14 | if ($page->idPage) |
|
95 | 14 | { |
|
96 | 13 | $idPage = $page->idPage; |
|
97 | 13 | if (!is_null (GetUrlParam (DB))) $idPage = str_replace ("cops:", "cops:" . GetUrlParam (DB) . ":", $idPage); |
|
98 | 13 | self::getXmlStream ()->text ($idPage); |
|
99 | 13 | } |
|
100 | else |
||
101 | { |
||
102 | 1 | self::getXmlStream ()->text ($_SERVER['REQUEST_URI']); |
|
103 | } |
||
104 | 14 | self::getXmlStream ()->endElement (); |
|
105 | 14 | self::getXmlStream ()->startElement ("updated"); |
|
106 | 14 | self::getXmlStream ()->text (self::getUpdatedTime ()); |
|
107 | 14 | self::getXmlStream ()->endElement (); |
|
108 | 14 | self::getXmlStream ()->startElement ("icon"); |
|
109 | 14 | self::getXmlStream ()->text ($page->favicon); |
|
110 | 14 | self::getXmlStream ()->endElement (); |
|
111 | 14 | self::getXmlStream ()->startElement ("author"); |
|
112 | 14 | self::getXmlStream ()->startElement ("name"); |
|
113 | 14 | self::getXmlStream ()->text ($page->authorName); |
|
114 | 14 | self::getXmlStream ()->endElement (); |
|
115 | 14 | self::getXmlStream ()->startElement ("uri"); |
|
116 | 14 | self::getXmlStream ()->text ($page->authorUri); |
|
117 | 14 | self::getXmlStream ()->endElement (); |
|
118 | 14 | self::getXmlStream ()->startElement ("email"); |
|
119 | 14 | self::getXmlStream ()->text ($page->authorEmail); |
|
120 | 14 | self::getXmlStream ()->endElement (); |
|
121 | 14 | self::getXmlStream ()->endElement (); |
|
122 | 14 | $link = new LinkNavigation ("", "start", "Home"); |
|
123 | 14 | self::renderLink ($link); |
|
124 | 14 | $link = new LinkNavigation ("?" . getQueryString (), "self"); |
|
125 | 14 | self::renderLink ($link); |
|
126 | 14 | $urlparam = "?"; |
|
127 | 14 | if (!is_null (GetUrlParam (DB))) $urlparam = addURLParameter ($urlparam, DB, GetUrlParam (DB)); |
|
128 | 14 | if ($config['cops_generate_invalid_opds_stream'] == 0 || preg_match("/(MantanoReader|FBReader)/", $_SERVER['HTTP_USER_AGENT'])) { |
|
129 | // Good and compliant way of handling search |
||
130 | 14 | $urlparam = addURLParameter ($urlparam, "page", Base::PAGE_OPENSEARCH); |
|
131 | 14 | $link = new Link ("feed.php" . $urlparam, "application/opensearchdescription+xml", "search", "Search here"); |
|
132 | 14 | } |
|
133 | else |
||
134 | { |
||
135 | // Bad way, will be removed when OPDS client are fixed |
||
136 | 1 | $urlparam = addURLParameter ($urlparam, "query", "{searchTerms}"); |
|
137 | 1 | $urlparam = str_replace ("%7B", "{", $urlparam); |
|
138 | 1 | $urlparam = str_replace ("%7D", "}", $urlparam); |
|
139 | 1 | $link = new Link ($config['cops_full_url'] . 'feed.php' . $urlparam, "application/atom+xml", "search", "Search here"); |
|
140 | } |
||
141 | 14 | self::renderLink ($link); |
|
142 | 14 | if ($page->containsBook () && !is_null ($config['cops_books_filter']) && count ($config['cops_books_filter']) > 0) { |
|
143 | 1 | $Urlfilter = getURLParam ("tag", ""); |
|
144 | 1 | foreach ($config['cops_books_filter'] as $lib => $filter) { |
|
145 | 1 | $link = new LinkFacet ("?" . addURLParameter (getQueryString (), "tag", $filter), $lib, localize ("tagword.title"), $filter == $Urlfilter); |
|
146 | 1 | self::renderLink ($link); |
|
147 | 1 | } |
|
148 | 1 | } |
|
149 | 14 | } |
|
150 | |||
279 |