CustomColumn::getUriAllCustoms() - Code Metrics - Inspection of "pt-PT edits - language revision" - seblucas/cops - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#254)

unknown

created 2016-02-22 18:20 UTC

CustomColumn::getUriAllCustoms() A

↳ Parent: CustomColumn

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Metric	Value
dl	0
loc	3
ccs	2
cts	2
cp	1
rs	10
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php
/**
 * COPS (Calibre OPDS PHP Server) class file
 *
 * @license    GPL 2 (http://www.gnu.org/licenses/gpl.html)
 * @author     S�bastien Lucas <[email protected]>
 */

require_once('base.php');

class CustomColumn extends Base {
    const ALL_CUSTOMS_ID = "cops:custom";

    public $id;
    public $name;
    public $customId;

    public function __construct($pid, $pname, $pcustomId) {
        $this->id = $pid;
        $this->name = $pname;
        $this->customId = $pcustomId;
    }

    public function getUri () {
        return "?page=".parent::PAGE_CUSTOM_DETAIL."&custom={$this->customId}&id={$this->id}";
    }

    public function getEntryId () {
        return self::ALL_CUSTOMS_ID.":".$this->customId.":".$this->id;
    }

    public static function getTableName ($customId) {
        return "custom_column_{$customId}";
    }

    public static function getTableLinkName ($customId) {
        return "books_custom_column_{$customId}_link";
    }

    public static function getTableLinkColumn ($customId) {

        return "value";
    }

    public static function getAllCustomsId ($customId) {
        return self::ALL_CUSTOMS_ID . ":" . $customId;
    }

    public static function getUriAllCustoms ($customId) {
        return "?page=" . parent::PAGE_ALL_CUSTOMS . "&custom={$customId}";
    }

    public static function getAllTitle ($customId) {
        $result = parent::getDb ()->prepare('select name from custom_columns where id = ?');
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $result->execute (array ($customId));
        $post = $result->fetchObject ();
        return $post->name;
    }

    public static function getCustomId ($lookup) {
        $result = parent::getDb ()->prepare('select id from custom_columns where label = ?');
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $result->execute (array ($lookup));
        if ($post = $result->fetchObject ()) {
            return $post->id;
        }
        return NULL;
    }

    public static function getCount($customId) {
        $nCustoms = parent::executeQuerySingle ('select count(*) from ' . self::getTableName ($customId));
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $entry = new Entry (self::getAllTitle ($customId), self::getAllCustomsId ($customId),
            str_format (localize("tags.alphabetical", $nCustoms), $nCustoms), "text",
            array ( new LinkNavigation (self::getUriAllCustoms ($customId))), "", $nCustoms);
        return $entry;
    }

    public static function getCustomById ($customId, $id) {
        $result = parent::getDb ()->prepare('select id, value as name from ' . self::getTableName ($customId) . ' where id = ?');
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $result->execute (array ($id));
        if ($post = $result->fetchObject ()) {
            return new CustomColumn ($post->id, $post->name, $customId);
        }
        return NULL;
    }

    public static function getAllCustoms($customId) {
        $result = parent::getDb ()->query(str_format ('select {0}.id as id, {0}.value as name, count(*) as count
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
from {0}, {1}
where {0}.id = {1}.{2}
group by {0}.id, {0}.value
order by {0}.value', self::getTableName ($customId), self::getTableLinkName ($customId), self::getTableLinkColumn ($customId)));
        $entryArray = array();
        while ($post = $result->fetchObject ())
        {
            $customColumn = new CustomColumn ($post->id, $post->name, $customId);
            array_push ($entryArray, new Entry ($customColumn->name, $customColumn->getEntryId (),
                str_format (localize("bookword", $post->count), $post->count), "text",
                array ( new LinkNavigation ($customColumn->getUri ())), "", $post->count));
        }
        return $entryArray;
    }
}


1		<?php
2		/**
3		* COPS (Calibre OPDS PHP Server) class file
4		*
5		* @license GPL 2 (http://www.gnu.org/licenses/gpl.html)
6		* @author S�bastien Lucas <[email protected]>
7		*/
8
9		require_once('base.php');
10
11		class CustomColumn extends Base {
12		const ALL_CUSTOMS_ID = "cops:custom";
13
14		public $id;
15		public $name;
16		public $customId;
17
18	6	public function __construct($pid, $pname, $pcustomId) {
19	6	$this->id = $pid;
20	6	$this->name = $pname;
21	6	$this->customId = $pcustomId;
22	6	}
23
24	3	public function getUri () {
25	3	return "?page=".parent::PAGE_CUSTOM_DETAIL."&custom={$this->customId}&id={$this->id}";
26		}
27
28	6	public function getEntryId () {
29	6	return self::ALL_CUSTOMS_ID.":".$this->customId.":".$this->id;
30		}
31
32	10	public static function getTableName ($customId) {
33	10	return "custom_column_{$customId}";
34		}
35
36	6	public static function getTableLinkName ($customId) {
37	6	return "books_custom_column_{$customId}_link";
38		}
39
40	6	public static function getTableLinkColumn ($customId) {
		0 ignored issues – show Unused Code introduced 2015-11-22 12:57 UTC by Report Bug Copy Issue Report The parameter `$customId` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
41	6	return "value";
42		}
43
44	7	public static function getAllCustomsId ($customId) {
45	7	return self::ALL_CUSTOMS_ID . ":" . $customId;
46		}
47
48	4	public static function getUriAllCustoms ($customId) {
49	4	return "?page=" . parent::PAGE_ALL_CUSTOMS . "&custom={$customId}";
50		}
51
52	7	public static function getAllTitle ($customId) {
53	7	$result = parent::getDb ()->prepare('select name from custom_columns where id = ?');
		0 ignored issues – show Comprehensibility Bug introduced 2015-11-22 12:57 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getDb()` instead of `getAllTitle()`). Are you sure this is correct? If so, you might want to change this to `$this->getDb()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
54	7	$result->execute (array ($customId));
55	7	$post = $result->fetchObject ();
56	7	return $post->name;
57		}
58
59	4	public static function getCustomId ($lookup) {
60	4	$result = parent::getDb ()->prepare('select id from custom_columns where label = ?');
		0 ignored issues – show Comprehensibility Bug introduced 2015-11-22 12:57 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getDb()` instead of `getCustomId()`). Are you sure this is correct? If so, you might want to change this to `$this->getDb()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
61	4	$result->execute (array ($lookup));
62	4	if ($post = $result->fetchObject ()) {
63	4	return $post->id;
64		}
65		return NULL;
66		}
67
68	4	public static function getCount($customId) {
69	4	$nCustoms = parent::executeQuerySingle ('select count(*) from ' . self::getTableName ($customId));
		0 ignored issues – show Comprehensibility Bug introduced 2015-11-22 12:57 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`executeQuerySingle()` instead of `getCount()`). Are you sure this is correct? If so, you might want to change this to `$this->executeQuerySingle()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
70	4	$entry = new Entry (self::getAllTitle ($customId), self::getAllCustomsId ($customId),
71	4	str_format (localize("tags.alphabetical", $nCustoms), $nCustoms), "text",
72	4	array ( new LinkNavigation (self::getUriAllCustoms ($customId))), "", $nCustoms);
73	4	return $entry;
74		}
75
76	3	public static function getCustomById ($customId, $id) {
77	3	$result = parent::getDb ()->prepare('select id, value as name from ' . self::getTableName ($customId) . ' where id = ?');
		0 ignored issues – show Comprehensibility Bug introduced 2015-11-22 12:57 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getDb()` instead of `getCustomById()`). Are you sure this is correct? If so, you might want to change this to `$this->getDb()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
78	3	$result->execute (array ($id));
79	3	if ($post = $result->fetchObject ()) {
80	3	return new CustomColumn ($post->id, $post->name, $customId);
81		}
82		return NULL;
83		}
84
85	3	public static function getAllCustoms($customId) {
86	3	$result = parent::getDb ()->query(str_format ('select {0}.id as id, {0}.value as name, count(*) as count
		0 ignored issues – show Comprehensibility Bug introduced 2015-11-22 12:57 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getDb()` instead of `getAllCustoms()`). Are you sure this is correct? If so, you might want to change this to `$this->getDb()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
87		from {0}, {1}
88		where {0}.id = {1}.{2}
89		group by {0}.id, {0}.value
90	3	order by {0}.value', self::getTableName ($customId), self::getTableLinkName ($customId), self::getTableLinkColumn ($customId)));
91	3	$entryArray = array();
92	3	while ($post = $result->fetchObject ())
93		{
94	3	$customColumn = new CustomColumn ($post->id, $post->name, $customId);
95	3	array_push ($entryArray, new Entry ($customColumn->name, $customColumn->getEntryId (),
96	3	str_format (localize("bookword", $post->count), $post->count), "text",
97	3	array ( new LinkNavigation ($customColumn->getUri ())), "", $post->count));
98	3	}
99	3	return $entryArray;
100		}
101		}
102

seblucas / cops

Pull Request — master (#254)

CustomColumn::getUriAllCustoms() A

Complexity

Size

Duplication

Code Coverage

Duplication Side-by-Side

Filter issues like