View GitHub Repository cops

Schedule Inspection
Subscribe
Completed
Push — master ( fb8b2d...704d46 )
by Sébastien
01:57
created

lib/LinkFacet.php (3 issues)

← previous file next file →

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

Code
1 
<?php
2 
/**
3 
 * COPS (Calibre OPDS PHP Server) class file
4 
 *
5 
 * @license    GPL 2 (http://www.gnu.org/licenses/gpl.html)
6 
 * @author     Sébastien Lucas <[email protected]>
7 
 */
8 

            


            
                                                        
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
class LinkFacet extends Link

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Coding Style
            Compatibility
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.
                                            

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
You can fix this by adding a namespace to your class:


namespace YourVendor;

class YourClass { }





When choosing a vendor namespace, try to pick something that is not too generic
to avoid conflicts with other libraries.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                
{

            


            
                                                        
            
                                    
            
            

                
                    11
                

                                    
                             1                         
                
                
                
    public function __construct($phref, $ptitle = NULL, $pfacetGroup = NULL, $pactiveFacet = FALSE) {

            


            
                                                        
            
                                    
            
            

                
                    12
                

                                    
                             1                         
                
                
                
        parent::__construct ($phref, Link::OPDS_PAGING_TYPE, "http://opds-spec.org/facet", $ptitle, $pfacetGroup, $pactiveFacet);

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Coding Style
            Comprehensibility
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
The string literal http://opds-spec.org/facet does not require double quotes, as per coding-style, please use single quotes.
                                                                                                

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
PHP provides two ways to mark string literals. Either with single quotes 'literal' or with
double quotes "literal". The difference between these is that string literals in double quotes
may contain variables with are evaluated at run-time as well as escape sequences.


String literals in single quotes on the other hand are evaluated very literally and the only two
characters that needs escaping in the literal are the single quote itself (\') and the
backslash (\\). Every other character is displayed as is.


Double quoted string literals may contain other variables or more complex escape sequences.


<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;





will print an indented: Single is Value


If your string literal does not contain variables or escape sequences, it should be defined
using single quotes to make that fact clear.


For more information on PHP string literals and available escape sequences see the PHP core
documentation.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                                                    
                                                                                                        
            
            

                
                    13
                

                                    
                             1                         
                
                View Code Duplication
                
        if (!is_null (GetUrlParam (DB))) $this->href = addURLParameter ($this->href, DB, GetUrlParam (DB));

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Duplication
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
This code seems to be duplicated across your project.
                                            

                                            
                    
                                            

                            

                            

                                
                                    
                                
                            


                            
Duplicated code is one of the most pungent code smells. If you need to duplicate
the same code in three or more different places, we strongly encourage you to
look into extracting the code into a single class or operation.


You can also find more detailed suggestions in the “Code” section of your repository.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    14
                

                                    
                             1                         
                
                
                
        $this->href = parent::getScriptName() . $this->href;

            


            
                                                        
            
                                    
            
            

                
                    15
                

                                    
                             1                         
                
                
                
    }

            


            
                                                        
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
}

            


            
                                                        
            
                                    
            
            

                
                    17