Serie::getAllSeriesByQuery() - Code Metrics - Inspection of "Fix Github URL to actual Github Cops project" - seblucas/cops - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#303)

unknown

created 2016-11-21 14:39 UTC

Serie::getAllSeriesByQuery() A

↳ Parent: Serie

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	2
c	0
b	0
f	0
nc	1
nop	1
dl	0
loc	3
ccs	2
cts	2
cp	1
crap	1
rs	10

<?php
/**
 * COPS (Calibre OPDS PHP Server) class file
 *
 * @license    GPL 2 (http://www.gnu.org/licenses/gpl.html)
 * @author     S�bastien Lucas <[email protected]>
 */

require_once('base.php');

class Serie extends Base {
    const ALL_SERIES_ID = "cops:series";
    const SERIES_COLUMNS = "series.id as id, series.name as name, series.sort as sort, count(*) as count";
    const SQL_ALL_SERIES = "select {0} from series, books_series_link where series.id = series group by series.id, series.name, series.sort order by series.sort";
    const SQL_SERIES_FOR_SEARCH = "select {0} from series, books_series_link where series.id = series and upper (series.name) like ? group by series.id, series.name, series.sort order by series.sort";

    public $id;
    public $name;

    public function __construct($post) {
        $this->id = $post->id;
        $this->name = $post->name;
    }

    public function getUri () {
        return "?page=".parent::PAGE_SERIE_DETAIL."&id=$this->id";
    }

    public function getEntryId () {
        return self::ALL_SERIES_ID.":".$this->id;
    }

    public static function getCount() {
        // str_format (localize("series.alphabetical", count(array))
        return parent::getCountGeneric ("series", self::ALL_SERIES_ID, parent::PAGE_ALL_SERIES);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    public static function getSerieByBookId ($bookId) {
        $result = parent::getDb ()->prepare('select  series.id as id, name
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
from books_series_link, series
where series.id = series and book = ?');
        $result->execute (array ($bookId));
        if ($post = $result->fetchObject ()) {
            return new Serie ($post);
        }
        return NULL;
    }

    public static function getSerieById ($serieId) {
        $result = parent::getDb ()->prepare('select id, name  from series where id = ?');
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $result->execute (array ($serieId));
        if ($post = $result->fetchObject ()) {
            return new Serie ($post);
        }
        return NULL;
    }

    public static function getAllSeries() {
        return Base::getEntryArrayWithBookNumber (self::SQL_ALL_SERIES, self::SERIES_COLUMNS, array (), "Serie");
    }

    public static function getAllSeriesByQuery($query) {
        return Base::getEntryArrayWithBookNumber (self::SQL_SERIES_FOR_SEARCH, self::SERIES_COLUMNS, array ('%' . $query . '%'), "Serie");
    }
}


1		<?php
2		/**
3		* COPS (Calibre OPDS PHP Server) class file
4		*
5		* @license GPL 2 (http://www.gnu.org/licenses/gpl.html)
6		* @author S�bastien Lucas <[email protected]>
7		*/
8
9		require_once('base.php');
10
11		class Serie extends Base {
12		const ALL_SERIES_ID = "cops:series";
13		const SERIES_COLUMNS = "series.id as id, series.name as name, series.sort as sort, count(*) as count";
14		const SQL_ALL_SERIES = "select {0} from series, books_series_link where series.id = series group by series.id, series.name, series.sort order by series.sort";
15		const SQL_SERIES_FOR_SEARCH = "select {0} from series, books_series_link where series.id = series and upper (series.name) like ? group by series.id, series.name, series.sort order by series.sort";
16
17		public $id;
18		public $name;
19
20	49	public function __construct($post) {
21	49	$this->id = $post->id;
22	49	$this->name = $post->name;
23	49	}
24
25	49	public function getUri () {
26	49	return "?page=".parent::PAGE_SERIE_DETAIL."&id=$this->id";
27		}
28
29	7	public function getEntryId () {
30	7	return self::ALL_SERIES_ID.":".$this->id;
31		}
32
33	18	public static function getCount() {
34		// str_format (localize("series.alphabetical", count(array))
35	18	return parent::getCountGeneric ("series", self::ALL_SERIES_ID, parent::PAGE_ALL_SERIES);
		0 ignored issues – show Comprehensibility Bug introduced 2015-11-22 12:57 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getCountGeneric()` instead of `getCount()`). Are you sure this is correct? If so, you might want to change this to `$this->getCountGeneric()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
36		}
37
38	48	public static function getSerieByBookId ($bookId) {
39	48	$result = parent::getDb ()->prepare('select series.id as id, name
		0 ignored issues – show Comprehensibility Bug introduced 2015-11-22 12:57 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getDb()` instead of `getSerieByBookId()`). Are you sure this is correct? If so, you might want to change this to `$this->getDb()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
40		from books_series_link, series
41	48	where series.id = series and book = ?');
42	48	$result->execute (array ($bookId));
43	48	if ($post = $result->fetchObject ()) {
44	43	return new Serie ($post);
45		}
46	21	return NULL;
47		}
48
49	1	public static function getSerieById ($serieId) {
50	1	$result = parent::getDb ()->prepare('select id, name from series where id = ?');
		0 ignored issues – show Comprehensibility Bug introduced 2015-11-22 12:57 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getDb()` instead of `getSerieById()`). Are you sure this is correct? If so, you might want to change this to `$this->getDb()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
51	1	$result->execute (array ($serieId));
52	1	if ($post = $result->fetchObject ()) {
53	1	return new Serie ($post);
54		}
55		return NULL;
56		}
57
58	2	public static function getAllSeries() {
59	2	return Base::getEntryArrayWithBookNumber (self::SQL_ALL_SERIES, self::SERIES_COLUMNS, array (), "Serie");
60		}
61
62	22	public static function getAllSeriesByQuery($query) {
63	22	return Base::getEntryArrayWithBookNumber (self::SQL_SERIES_FOR_SEARCH, self::SERIES_COLUMNS, array ('%' . $query . '%'), "Serie");
64		}
65		}
66

seblucas / cops

Pull Request — master (#303)

Serie::getAllSeriesByQuery() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like