Test Setup Failed
Pull Request — master (#424)
by
unknown
50:02
created
base.php 2 patches
Doc Comments   +11 added lines patch added patch discarded remove patch
@@ -64,6 +64,9 @@  discard block
 block discarded – undo
64 64
     $_SERVER['REDIRECT_STATUS'] = 404;
65 65
 }
66 66
 
67
+/**
68
+ * @param string $name
69
+ */
67 70
 function getURLParam($name, $default = NULL)
68 71
 {
69 72
     if (!empty ($_GET) && isset($_GET[$name]) && $_GET[$name] != '') {
@@ -104,6 +107,11 @@  discard block
 block discarded – undo
104 107
     return $url . '?v=' . VERSION;
105 108
 }
106 109
 
110
+/**
111
+ * @param string $xml
112
+ *
113
+ * @return string
114
+ */
107 115
 function xml2xhtml($xml)
108 116
 {
109 117
     return preg_replace_callback('#<(\w+)([^>]*)\s*/>#s', function($m) {
@@ -326,6 +334,9 @@  discard block
 block discarded – undo
326 334
     return $phrase;
327 335
 }
328 336
 
337
+/**
338
+ * @param string $paramName
339
+ */
329 340
 function addURLParameter($urlParams, $paramName, $paramValue)
330 341
 {
331 342
     if (empty ($urlParams)) {
Please login to merge, or discard this patch.
Braces   +19 added lines, -11 removed lines patch added patch discarded remove patch
@@ -149,7 +149,9 @@  discard block
 block discarded – undo
149 149
     $errors = libxml_get_errors();
150 150
 
151 151
     foreach ($errors as $error) {
152
-        if ($error->code == 801) return false;
152
+        if ($error->code == 801) {
153
+            return false;
154
+        }
153 155
     }
154 156
     return true;
155 157
 }
@@ -175,7 +177,9 @@  discard block
 block discarded – undo
175 177
     }
176 178
     */
177 179
 
178
-    if (!are_libxml_errors_ok ()) $output = 'HTML code not valid.';
180
+    if (!are_libxml_errors_ok ()) {
181
+        $output = 'HTML code not valid.';
182
+    }
179 183
 
180 184
     libxml_use_internal_errors(false);
181 185
     return $output;
@@ -235,7 +239,9 @@  discard block
 block discarded – undo
235 239
 
236 240
             // set default to 1 for any without q factor
237 241
             foreach ($langs as $lang => $val) {
238
-                if ($val === '') $langs[$lang] = 1;
242
+                if ($val === '') {
243
+                    $langs[$lang] = 1;
244
+                }
239 245
             }
240 246
 
241 247
             // sort list based on value
@@ -257,8 +263,7 @@  discard block
 block discarded – undo
257 263
     $lang = 'en';
258 264
     if (!empty($config['cops_language'])) {
259 265
         $lang = $config['cops_language'];
260
-    }
261
-    elseif (isset($_SERVER['HTTP_ACCEPT_LANGUAGE'])) {
266
+    } elseif (isset($_SERVER['HTTP_ACCEPT_LANGUAGE'])) {
262 267
         $langs = getAcceptLanguages();
263 268
     }
264 269
     //echo var_dump($langs);
@@ -284,12 +289,15 @@  discard block
 block discarded – undo
284 289
 function localize($phrase, $count=-1, $reset=false)
285 290
 {
286 291
     global $config;
287
-    if ($count == 0)
288
-        $phrase .= '.none';
289
-    if ($count == 1)
290
-        $phrase .= '.one';
291
-    if ($count > 1)
292
-        $phrase .= '.many';
292
+    if ($count == 0) {
293
+            $phrase .= '.none';
294
+    }
295
+    if ($count == 1) {
296
+            $phrase .= '.one';
297
+    }
298
+    if ($count > 1) {
299
+            $phrase .= '.many';
300
+    }
293 301
 
294 302
     /* Static keyword is used to ensure the file is loaded only once */
295 303
     static $translations = NULL;
Please login to merge, or discard this patch.
lib/Author.php 2 patches
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -62,6 +62,9 @@  discard block
 block discarded – undo
62 62
         return self::getEntryArray (self::SQL_AUTHORS_BY_FIRST_LETTER, array ($letter . "%"));
63 63
     }
64 64
 
65
+    /**
66
+     * @param string $query
67
+     */
65 68
     public static function getAuthorsForSearch($query) {
66 69
         return self::getEntryArray (self::SQL_AUTHORS_FOR_SEARCH, array ($query . "%", $query . "%"));
67 70
     }
@@ -70,6 +73,9 @@  discard block
 block discarded – undo
70 73
         return self::getEntryArray (self::SQL_ALL_AUTHORS, array ());
71 74
     }
72 75
 
76
+    /**
77
+     * @param string $query
78
+     */
73 79
     public static function getEntryArray ($query, $params) {
74 80
         return Base::getEntryArrayWithBookNumber ($query, self::AUTHOR_COLUMNS, $params, "Author");
75 81
     }
Please login to merge, or discard this patch.
Braces   +25 added lines, -14 removed lines patch added patch discarded remove patch
@@ -19,37 +19,42 @@  discard block
 block discarded – undo
19 19
     public $name;
20 20
     public $sort;
21 21
 
22
-    public function __construct($post) {
22
+    public function __construct($post)
23
+    {
23 24
         $this->id = $post->id;
24 25
         $this->name = str_replace("|", ",", $post->name);
25 26
         $this->sort = $post->sort;
26 27
     }
27 28
 
28
-    public function getUri () {
29
+    public function getUri ()
30
+    {
29 31
         return "?page=".parent::PAGE_AUTHOR_DETAIL."&id=$this->id";
30 32
     }
31 33
 
32
-    public function getEntryId () {
34
+    public function getEntryId ()
35
+    {
33 36
         return self::ALL_AUTHORS_ID.":".$this->id;
34 37
     }
35 38
 
36
-    public static function getEntryIdByLetter ($startingLetter) {
39
+    public static function getEntryIdByLetter ($startingLetter)
40
+    {
37 41
         return self::ALL_AUTHORS_ID.":letter:".$startingLetter;
38 42
     }
39 43
 
40
-    public static function getCount() {
44
+    public static function getCount()
45
+    {
41 46
         // str_format (localize("authors.alphabetical", count(array))
42 47
         return parent::getCountGeneric ("authors", self::ALL_AUTHORS_ID, parent::PAGE_ALL_AUTHORS);
43 48
     }
44 49
 
45
-    public static function getAllAuthorsByFirstLetter() {
50
+    public static function getAllAuthorsByFirstLetter()
51
+    {
46 52
         list (, $result) = parent::executeQuery ("select {0}
47 53
 from authors
48 54
 group by substr (upper (sort), 1, 1)
49 55
 order by substr (upper (sort), 1, 1)", "substr (upper (sort), 1, 1) as title, count(*) as count", "", array (), -1);
50 56
         $entryArray = array();
51
-        while ($post = $result->fetchObject ())
52
-        {
57
+        while ($post = $result->fetchObject ()) {
53 58
             array_push ($entryArray, new Entry ($post->title, Author::getEntryIdByLetter ($post->title),
54 59
                 str_format (localize("authorword", $post->count), $post->count), "text",
55 60
                 array ( new LinkNavigation ("?page=".parent::PAGE_AUTHORS_FIRST_LETTER."&id=". rawurlencode ($post->title))), "", $post->count));
@@ -57,30 +62,36 @@  discard block
 block discarded – undo
57 62
         return $entryArray;
58 63
     }
59 64
 
60
-    public static function getAuthorsByStartingLetter($letter) {
65
+    public static function getAuthorsByStartingLetter($letter)
66
+    {
61 67
         return self::getEntryArray (self::SQL_AUTHORS_BY_FIRST_LETTER, array ($letter . "%"));
62 68
     }
63 69
 
64
-    public static function getAuthorsForSearch($query) {
70
+    public static function getAuthorsForSearch($query)
71
+    {
65 72
         return self::getEntryArray (self::SQL_AUTHORS_FOR_SEARCH, array ($query . "%", $query . "%"));
66 73
     }
67 74
 
68
-    public static function getAllAuthors() {
75
+    public static function getAllAuthors()
76
+    {
69 77
         return self::getEntryArray (self::SQL_ALL_AUTHORS, array ());
70 78
     }
71 79
 
72
-    public static function getEntryArray ($query, $params) {
80
+    public static function getEntryArray ($query, $params)
81
+    {
73 82
         return Base::getEntryArrayWithBookNumber ($query, self::AUTHOR_COLUMNS, $params, "Author");
74 83
     }
75 84
 
76
-    public static function getAuthorById ($authorId) {
85
+    public static function getAuthorById ($authorId)
86
+    {
77 87
         $result = parent::getDb ()->prepare('select ' . self::AUTHOR_COLUMNS . ' from authors where id = ?');
78 88
         $result->execute (array ($authorId));
79 89
         $post = $result->fetchObject ();
80 90
         return new Author ($post);
81 91
     }
82 92
 
83
-    public static function getAuthorByBookId ($bookId) {
93
+    public static function getAuthorByBookId ($bookId)
94
+    {
84 95
         $result = parent::getDb ()->prepare('select authors.id as id, authors.name as name, authors.sort as sort from authors, books_authors_link
85 96
 where author = authors.id
86 97
 and book = ?');
Please login to merge, or discard this patch.
lib/Base.php 2 patches
Doc Comments   +18 added lines patch added patch discarded remove patch
@@ -84,6 +84,9 @@  discard block
 block discarded – undo
84 84
         return "";
85 85
     }
86 86
 
87
+    /**
88
+     * @return string
89
+     */
87 90
     public static function getDbDirectory ($database = NULL) {
88 91
         global $config;
89 92
         if (self::isMultipleDatabaseEnabled ()) {
@@ -143,10 +146,18 @@  discard block
 block discarded – undo
143 146
         self::$db = NULL;
144 147
     }
145 148
 
149
+    /**
150
+     * @param string $query
151
+     */
146 152
     public static function executeQuerySingle ($query, $database = NULL) {
147 153
         return self::getDb ($database)->query($query)->fetchColumn();
148 154
     }
149 155
 
156
+    /**
157
+     * @param string $table
158
+     * @param string $id
159
+     * @param string $numberOfString
160
+     */
150 161
     public static function getCountGeneric($table, $id, $pageId, $numberOfString = NULL) {
151 162
         if (!$numberOfString) {
152 163
             $numberOfString = $table . ".alphabetical";
@@ -159,6 +170,10 @@  discard block
 block discarded – undo
159 170
         return $entry;
160 171
     }
161 172
 
173
+    /**
174
+     * @param string $columns
175
+     * @param string $category
176
+     */
162 177
     public static function getEntryArrayWithBookNumber ($query, $columns, $params, $category) {
163 178
         /* @var $result PDOStatement */
164 179
 
@@ -181,6 +196,9 @@  discard block
 block discarded – undo
181 196
         return $entryArray;
182 197
     }
183 198
 
199
+    /**
200
+     * @param string $filter
201
+     */
184 202
     public static function executeQuery($query, $columns, $filter, $params, $n, $database = NULL, $numberPerPage = NULL) {
185 203
         $totalResult = -1;
186 204
 
Please login to merge, or discard this patch.
Braces   +48 added lines, -25 removed lines patch added patch discarded remove patch
@@ -37,23 +37,27 @@  discard block
 block discarded – undo
37 37
 
38 38
     private static $db = NULL;
39 39
 
40
-    public static function isMultipleDatabaseEnabled () {
40
+    public static function isMultipleDatabaseEnabled ()
41
+    {
41 42
         global $config;
42 43
         return is_array ($config['calibre_directory']);
43 44
     }
44 45
 
45
-    public static function useAbsolutePath () {
46
+    public static function useAbsolutePath ()
47
+    {
46 48
         global $config;
47 49
         $path = self::getDbDirectory();
48 50
         return preg_match ('/^\//', $path) || // Linux /
49 51
                preg_match ('/^\w\:/', $path); // Windows X:
50 52
     }
51 53
 
52
-    public static function noDatabaseSelected () {
54
+    public static function noDatabaseSelected ()
55
+    {
53 56
         return self::isMultipleDatabaseEnabled () && is_null (GetUrlParam (DB));
54 57
     }
55 58
 
56
-    public static function getDbList () {
59
+    public static function getDbList ()
60
+    {
57 61
         global $config;
58 62
         if (self::isMultipleDatabaseEnabled ()) {
59 63
             return $config['calibre_directory'];
@@ -62,7 +66,8 @@  discard block
 block discarded – undo
62 66
         }
63 67
     }
64 68
 
65
-    public static function getDbNameList () {
69
+    public static function getDbNameList ()
70
+    {
66 71
         global $config;
67 72
         if (self::isMultipleDatabaseEnabled ()) {
68 73
             return array_keys ($config['calibre_directory']);
@@ -71,10 +76,13 @@  discard block
 block discarded – undo
71 76
         }
72 77
     }
73 78
 
74
-    public static function getDbName ($database = NULL) {
79
+    public static function getDbName ($database = NULL)
80
+    {
75 81
         global $config;
76 82
         if (self::isMultipleDatabaseEnabled ()) {
77
-            if (is_null ($database)) $database = GetUrlParam (DB, 0);
83
+            if (is_null ($database)) {
84
+                $database = GetUrlParam (DB, 0);
85
+            }
78 86
             if (!is_null($database) && !preg_match('/^\d+$/', $database)) {
79 87
                 self::error ($database);
80 88
             }
@@ -84,10 +92,13 @@  discard block
 block discarded – undo
84 92
         return "";
85 93
     }
86 94
 
87
-    public static function getDbDirectory ($database = NULL) {
95
+    public static function getDbDirectory ($database = NULL)
96
+    {
88 97
         global $config;
89 98
         if (self::isMultipleDatabaseEnabled ()) {
90
-            if (is_null ($database)) $database = GetUrlParam (DB, 0);
99
+            if (is_null ($database)) {
100
+                $database = GetUrlParam (DB, 0);
101
+            }
91 102
             if (!is_null($database) && !preg_match('/^\d+$/', $database)) {
92 103
                 self::error ($database);
93 104
             }
@@ -98,28 +109,34 @@  discard block
 block discarded – undo
98 109
     }
99 110
 
100 111
     // -DC- Add image directory
101
-    public static function getImgDirectory ($database = NULL) {
112
+    public static function getImgDirectory ($database = NULL)
113
+    {
102 114
     	global $config;
103 115
     	if (self::isMultipleDatabaseEnabled ()) {
104
-    		if (is_null ($database)) $database = GetUrlParam (DB, 0);
116
+    		if (is_null ($database)) {
117
+    		    $database = GetUrlParam (DB, 0);
118
+    		}
105 119
     		$array = array_values ($config['image_directory']);
106 120
     		return  $array[$database];
107 121
     	}
108 122
     	return $config['image_directory'];
109 123
     }
110 124
 
111
-    public static function getDbFileName ($database = NULL) {
125
+    public static function getDbFileName ($database = NULL)
126
+    {
112 127
         return self::getDbDirectory ($database) .'metadata.db';
113 128
     }
114 129
 
115
-    private static function error ($database) {
130
+    private static function error ($database)
131
+    {
116 132
         if (php_sapi_name() != "cli") {
117 133
             header("location: checkconfig.php?err=1");
118 134
         }
119 135
         throw new Exception("Database <{$database}> not found.");
120 136
     }
121 137
 
122
-    public static function getDb ($database = NULL) {
138
+    public static function getDb ($database = NULL)
139
+    {
123 140
         if (is_null (self::$db)) {
124 141
             try {
125 142
                 if (is_readable (self::getDbFileName ($database))) {
@@ -137,7 +154,8 @@  discard block
 block discarded – undo
137 154
         return self::$db;
138 155
     }
139 156
 
140
-    public static function checkDatabaseAvailability () {
157
+    public static function checkDatabaseAvailability ()
158
+    {
141 159
         if (self::noDatabaseSelected ()) {
142 160
             for ($i = 0; $i < count (self::getDbList ()); $i++) {
143 161
                 self::getDb ($i);
@@ -149,33 +167,38 @@  discard block
 block discarded – undo
149 167
         return true;
150 168
     }
151 169
 
152
-    public static function clearDb () {
170
+    public static function clearDb ()
171
+    {
153 172
         self::$db = NULL;
154 173
     }
155 174
 
156
-    public static function executeQuerySingle ($query, $database = NULL) {
175
+    public static function executeQuerySingle ($query, $database = NULL)
176
+    {
157 177
         return self::getDb ($database)->query($query)->fetchColumn();
158 178
     }
159 179
 
160
-    public static function getCountGeneric($table, $id, $pageId, $numberOfString = NULL) {
180
+    public static function getCountGeneric($table, $id, $pageId, $numberOfString = NULL)
181
+    {
161 182
         if (!$numberOfString) {
162 183
             $numberOfString = $table . ".alphabetical";
163 184
         }
164 185
         $count = self::executeQuerySingle ('select count(*) from ' . $table);
165
-        if ($count == 0) return NULL;
186
+        if ($count == 0) {
187
+            return NULL;
188
+        }
166 189
         $entry = new Entry (localize($table . ".title"), $id,
167 190
             str_format (localize($numberOfString, $count), $count), "text",
168 191
             array ( new LinkNavigation ("?page=".$pageId)), "", $count);
169 192
         return $entry;
170 193
     }
171 194
 
172
-    public static function getEntryArrayWithBookNumber ($query, $columns, $params, $category) {
195
+    public static function getEntryArrayWithBookNumber ($query, $columns, $params, $category)
196
+    {
173 197
         /* @var $result PDOStatement */
174 198
 
175 199
         list (, $result) = self::executeQuery ($query, $columns, "", $params, -1);
176 200
         $entryArray = array();
177
-        while ($post = $result->fetchObject ())
178
-        {
201
+        while ($post = $result->fetchObject ()) {
179 202
             /* @var $instance Author|Tag|Serie|Publisher */
180 203
 
181 204
             $instance = new $category ($post);
@@ -191,7 +214,8 @@  discard block
 block discarded – undo
191 214
         return $entryArray;
192 215
     }
193 216
 
194
-    public static function executeQuery($query, $columns, $filter, $params, $n, $database = NULL, $numberPerPage = NULL) {
217
+    public static function executeQuery($query, $columns, $filter, $params, $n, $database = NULL, $numberPerPage = NULL)
218
+    {
195 219
         $totalResult = -1;
196 220
 
197 221
         if (useNormAndUp ()) {
@@ -203,8 +227,7 @@  discard block
 block discarded – undo
203 227
             $numberPerPage = getCurrentOption ("max_item_per_page");
204 228
         }
205 229
 
206
-        if ($numberPerPage != -1 && $n != -1)
207
-        {
230
+        if ($numberPerPage != -1 && $n != -1) {
208 231
             // First check total number of results
209 232
             $result = self::getDb ($database)->prepare (str_format ($query, "count(*)", $filter));
210 233
             $result->execute ($params);
Please login to merge, or discard this patch.
lib/CustomColumnType.php 2 patches
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -39,6 +39,9 @@  discard block
 block discarded – undo
39 39
     /** @var null|Entry[] */
40 40
     private $customValues = NULL;
41 41
 
42
+    /**
43
+     * @param string $pdatatype
44
+     */
42 45
     protected function __construct($pcustomId, $pdatatype)
43 46
     {
44 47
         $this->columnTitle = self::getTitleByCustomID($pcustomId);
@@ -147,7 +150,7 @@  discard block
 block discarded – undo
147 150
     /**
148 151
      * Encode a value of this column ready to be displayed in an HTML document
149 152
      *
150
-     * @param integer|string $value
153
+     * @param string $value
151 154
      * @return string
152 155
      */
153 156
     public function encodeHTMLValue($value)
@@ -277,7 +280,7 @@  discard block
 block discarded – undo
277 280
     /**
278 281
      * Get a CustomColumn for a specified (by ID) value
279 282
      *
280
-     * @param string|integer $id the id of the searched value
283
+     * @param integer $id the id of the searched value
281 284
      * @return CustomColumn
282 285
      */
283 286
     abstract public function getCustom($id);
Please login to merge, or discard this patch.
Braces   +9 added lines, -6 removed lines patch added patch discarded remove patch
@@ -181,8 +181,9 @@  discard block
 block discarded – undo
181 181
     public static function createByCustomID($customId)
182 182
     {
183 183
         // Reuse already created CustomColumns for performance
184
-        if (array_key_exists($customId, self::$customColumnCacheID))
185
-            return self::$customColumnCacheID[$customId];
184
+        if (array_key_exists($customId, self::$customColumnCacheID)) {
185
+                    return self::$customColumnCacheID[$customId];
186
+        }
186 187
 
187 188
         $datatype = self::getDatatypeByCustomID($customId);
188 189
 
@@ -221,8 +222,9 @@  discard block
 block discarded – undo
221 222
     public static function createByLookup($lookup)
222 223
     {
223 224
         // Reuse already created CustomColumns for performance
224
-        if (array_key_exists($lookup, self::$customColumnCacheLookup))
225
-            return self::$customColumnCacheLookup[$lookup];
225
+        if (array_key_exists($lookup, self::$customColumnCacheLookup)) {
226
+                    return self::$customColumnCacheLookup[$lookup];
227
+        }
226 228
 
227 229
         $result = parent::getDb()->prepare('SELECT id FROM custom_columns WHERE label = ?');
228 230
         $result->execute(array($lookup));
@@ -241,8 +243,9 @@  discard block
 block discarded – undo
241 243
     public function getAllCustomValues()
242 244
     {
243 245
         // lazy loading
244
-        if ($this->customValues == NULL)
245
-            $this->customValues = $this->getAllCustomValuesFromDatabase();
246
+        if ($this->customValues == NULL) {
247
+                    $this->customValues = $this->getAllCustomValuesFromDatabase();
248
+        }
246 249
 
247 250
         return $this->customValues;
248 251
     }
Please login to merge, or discard this patch.
lib/LinkFacet.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -8,6 +8,9 @@
 block discarded – undo
8 8
 
9 9
 class LinkFacet extends Link
10 10
 {
11
+    /**
12
+     * @param string $phref
13
+     */
11 14
     public function __construct($phref, $ptitle = NULL, $pfacetGroup = NULL, $pactiveFacet = FALSE) {
12 15
         parent::__construct ($phref, Link::OPDS_PAGING_TYPE, "http://opds-spec.org/facet", $ptitle, $pfacetGroup, $pactiveFacet);
13 16
         if (!is_null (GetUrlParam (DB))) $this->href = addURLParameter ($this->href, DB, GetUrlParam (DB));
Please login to merge, or discard this patch.
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -8,9 +8,12 @@
 block discarded – undo
8 8
 
9 9
 class LinkFacet extends Link
10 10
 {
11
-    public function __construct($phref, $ptitle = NULL, $pfacetGroup = NULL, $pactiveFacet = FALSE) {
11
+    public function __construct($phref, $ptitle = NULL, $pfacetGroup = NULL, $pactiveFacet = FALSE)
12
+    {
12 13
         parent::__construct ($phref, Link::OPDS_PAGING_TYPE, "http://opds-spec.org/facet", $ptitle, $pfacetGroup, $pactiveFacet);
13
-        if (!is_null (GetUrlParam (DB))) $this->href = addURLParameter ($this->href, DB, GetUrlParam (DB));
14
+        if (!is_null (GetUrlParam (DB))) {
15
+            $this->href = addURLParameter ($this->href, DB, GetUrlParam (DB));
16
+        }
14 17
         $this->href = parent::getScriptName() . $this->href;
15 18
     }
16 19
 }
Please login to merge, or discard this patch.
lib/LinkNavigation.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -8,6 +8,9 @@
 block discarded – undo
8 8
 
9 9
 class LinkNavigation extends Link
10 10
 {
11
+    /**
12
+     * @param string $prel
13
+     */
11 14
     public function __construct($phref, $prel = NULL, $ptitle = NULL) {
12 15
         parent::__construct ($phref, Link::OPDS_NAVIGATION_TYPE, $prel, $ptitle);
13 16
         if (!is_null (GetUrlParam (DB))) $this->href = addURLParameter ($this->href, DB, GetUrlParam (DB));
Please login to merge, or discard this patch.
Braces   +8 added lines, -3 removed lines patch added patch discarded remove patch
@@ -8,10 +8,15 @@
 block discarded – undo
8 8
 
9 9
 class LinkNavigation extends Link
10 10
 {
11
-    public function __construct($phref, $prel = NULL, $ptitle = NULL) {
11
+    public function __construct($phref, $prel = NULL, $ptitle = NULL)
12
+    {
12 13
         parent::__construct ($phref, Link::OPDS_NAVIGATION_TYPE, $prel, $ptitle);
13
-        if (!is_null (GetUrlParam (DB))) $this->href = addURLParameter ($this->href, DB, GetUrlParam (DB));
14
-        if (!preg_match ("#^\?(.*)#", $this->href) && !empty ($this->href)) $this->href = "?" . $this->href;
14
+        if (!is_null (GetUrlParam (DB))) {
15
+            $this->href = addURLParameter ($this->href, DB, GetUrlParam (DB));
16
+        }
17
+        if (!preg_match ("#^\?(.*)#", $this->href) && !empty ($this->href)) {
18
+            $this->href = "?" . $this->href;
19
+        }
15 20
         if (preg_match ("/(bookdetail|getJSON).php/", parent::getScriptName())) {
16 21
             $this->href = "index.php" . $this->href;
17 22
         } else {
Please login to merge, or discard this patch.
lib/PageCustomize.php 2 patches
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -8,6 +8,9 @@  discard block
 block discarded – undo
8 8
 
9 9
 class PageCustomize extends Page
10 10
 {
11
+    /**
12
+     * @param string $key
13
+     */
11 14
     private function isChecked ($key, $testedValue = 1) {
12 15
         $value = getCurrentOption ($key);
13 16
         if (is_array ($value)) {
@@ -22,6 +25,9 @@  discard block
 block discarded – undo
22 25
         return "";
23 26
     }
24 27
 
28
+    /**
29
+     * @param string $key
30
+     */
25 31
     private function isSelected ($key, $value) {
26 32
         if (getCurrentOption ($key) == $value) {
27 33
             return "selected='selected'";
Please login to merge, or discard this patch.
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -8,7 +8,8 @@  discard block
 block discarded – undo
8 8
 
9 9
 class PageCustomize extends Page
10 10
 {
11
-    private function isChecked ($key, $testedValue = 1) {
11
+    private function isChecked ($key, $testedValue = 1)
12
+    {
12 13
         $value = getCurrentOption ($key);
13 14
         if (is_array ($value)) {
14 15
             if (in_array ($testedValue, $value)) {
@@ -22,14 +23,16 @@  discard block
 block discarded – undo
22 23
         return "";
23 24
     }
24 25
 
25
-    private function isSelected ($key, $value) {
26
+    private function isSelected ($key, $value)
27
+    {
26 28
         if (getCurrentOption ($key) == $value) {
27 29
             return "selected='selected'";
28 30
         }
29 31
         return "";
30 32
     }
31 33
 
32
-    private function getStyleList () {
34
+    private function getStyleList ()
35
+    {
33 36
         $result = array ();
34 37
         foreach (glob ("templates/" . getCurrentTemplate () . "/styles/style-*.css") as $filename) {
35 38
             if (preg_match ('/styles\/style-(.*?)\.css/', $filename, $m)) {
Please login to merge, or discard this patch.
lib/Rating.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -38,6 +38,9 @@
 block discarded – undo
38 38
         return self::getEntryArray (self::SQL_ALL_RATINGS, array ());
39 39
     }
40 40
 
41
+    /**
42
+     * @param string $query
43
+     */
41 44
     public static function getEntryArray ($query, $params) {
42 45
         list (, $result) = parent::executeQuery ($query, self::RATING_COLUMNS, "", $params, -1);
43 46
         $entryArray = array();
Please login to merge, or discard this patch.
Braces   +15 added lines, -9 removed lines patch added patch discarded remove patch
@@ -15,33 +15,38 @@  discard block
 block discarded – undo
15 15
     public $id;
16 16
     public $name;
17 17
 
18
-    public function __construct($pid, $pname) {
18
+    public function __construct($pid, $pname)
19
+    {
19 20
         $this->id = $pid;
20 21
         $this->name = $pname;
21 22
     }
22 23
 
23
-    public function getUri () {
24
+    public function getUri ()
25
+    {
24 26
         return "?page=".parent::PAGE_RATING_DETAIL."&id=$this->id";
25 27
     }
26 28
 
27
-    public function getEntryId () {
29
+    public function getEntryId ()
30
+    {
28 31
         return self::ALL_RATING_ID.":".$this->id;
29 32
     }
30 33
 
31
-    public static function getCount() {
34
+    public static function getCount()
35
+    {
32 36
         // str_format (localize("ratings", count(array))
33 37
         return parent::getCountGeneric ("ratings", self::ALL_RATING_ID, parent::PAGE_ALL_RATINGS, "ratings");
34 38
     }
35 39
 
36
-    public static function getAllRatings() {
40
+    public static function getAllRatings()
41
+    {
37 42
         return self::getEntryArray (self::SQL_ALL_RATINGS, array ());
38 43
     }
39 44
 
40
-    public static function getEntryArray ($query, $params) {
45
+    public static function getEntryArray ($query, $params)
46
+    {
41 47
         list (, $result) = parent::executeQuery ($query, self::RATING_COLUMNS, "", $params, -1);
42 48
         $entryArray = array();
43
-        while ($post = $result->fetchObject ())
44
-        {
49
+        while ($post = $result->fetchObject ()) {
45 50
             $ratingObj = new Rating ($post->id, $post->rating);
46 51
             $rating=$post->rating/2;
47 52
             $rating = str_format (localize("ratingword", $rating), $rating);
@@ -52,7 +57,8 @@  discard block
 block discarded – undo
52 57
         return $entryArray;
53 58
     }
54 59
 
55
-    public static function getRatingById ($ratingId) {
60
+    public static function getRatingById ($ratingId)
61
+    {
56 62
         $result = parent::getDb ()->prepare('select rating from ratings where id = ?');
57 63
         $result->execute (array ($ratingId));
58 64
         return new Rating ($ratingId, $result->fetchColumn ());
Please login to merge, or discard this patch.
transliteration.php 1 patch
Braces   +18 added lines, -30 removed lines patch added patch discarded remove patch
@@ -25,7 +25,8 @@  discard block
 block discarded – undo
25 25
  * @return
26 26
  *   Transliterated text.
27 27
  */
28
-function _transliteration_process($string, $unknown = '?', $source_langcode = NULL) {
28
+function _transliteration_process($string, $unknown = '?', $source_langcode = NULL)
29
+{
29 30
   // ASCII is always valid NFC! If we're only ever given plain ASCII, we can
30 31
   // avoid the overhead of initializing the decomposition tables by skipping
31 32
   // out early.
@@ -41,23 +42,17 @@  discard block
 block discarded – undo
41 42
     for ($n = 0; $n < 256; $n++) {
42 43
       if ($n < 0xc0) {
43 44
         $remaining = 0;
44
-      }
45
-      elseif ($n < 0xe0) {
45
+      } elseif ($n < 0xe0) {
46 46
         $remaining = 1;
47
-      }
48
-      elseif ($n < 0xf0) {
47
+      } elseif ($n < 0xf0) {
49 48
         $remaining = 2;
50
-      }
51
-      elseif ($n < 0xf8) {
49
+      } elseif ($n < 0xf8) {
52 50
         $remaining = 3;
53
-      }
54
-      elseif ($n < 0xfc) {
51
+      } elseif ($n < 0xfc) {
55 52
         $remaining = 4;
56
-      }
57
-      elseif ($n < 0xfe) {
53
+      } elseif ($n < 0xfe) {
58 54
         $remaining = 5;
59
-      }
60
-      else {
55
+      } else {
61 56
         $remaining = 0;
62 57
       }
63 58
       $tail_bytes[chr($n)] = $remaining;
@@ -100,15 +95,13 @@  discard block
 block discarded – undo
100 95
           if (--$len && ($c = $str[++$i]) >= "\x80" && $c < "\xc0") {
101 96
             // Legal tail bytes are nice.
102 97
             $sequence .= $c;
103
-          }
104
-          else {
98
+          } else {
105 99
             if ($len == 0) {
106 100
               // Premature end of string! Drop a replacement character into
107 101
               // output to represent the invalid UTF-8 sequence.
108 102
               $result .= $unknown;
109 103
               break 2;
110
-            }
111
-            else {
104
+            } else {
112 105
               // Illegal tail byte; abandon the sequence.
113 106
               $result .= $unknown;
114 107
               // Back up and reprocess this byte; it may itself be a legal
@@ -123,17 +116,13 @@  discard block
 block discarded – undo
123 116
         $n = ord($head);
124 117
         if ($n <= 0xdf) {
125 118
           $ord = ($n - 192) * 64 + (ord($sequence[1]) - 128);
126
-        }
127
-        elseif ($n <= 0xef) {
119
+        } elseif ($n <= 0xef) {
128 120
           $ord = ($n - 224) * 4096 + (ord($sequence[1]) - 128) * 64 + (ord($sequence[2]) - 128);
129
-        }
130
-        elseif ($n <= 0xf7) {
121
+        } elseif ($n <= 0xf7) {
131 122
           $ord = ($n - 240) * 262144 + (ord($sequence[1]) - 128) * 4096 + (ord($sequence[2]) - 128) * 64 + (ord($sequence[3]) - 128);
132
-        }
133
-        elseif ($n <= 0xfb) {
123
+        } elseif ($n <= 0xfb) {
134 124
           $ord = ($n - 248) * 16777216 + (ord($sequence[1]) - 128) * 262144 + (ord($sequence[2]) - 128) * 4096 + (ord($sequence[3]) - 128) * 64 + (ord($sequence[4]) - 128);
135
-        }
136
-        elseif ($n <= 0xfd) {
125
+        } elseif ($n <= 0xfd) {
137 126
           $ord = ($n - 252) * 1073741824 + (ord($sequence[1]) - 128) * 16777216 + (ord($sequence[2]) - 128) * 262144 + (ord($sequence[3]) - 128) * 4096 + (ord($sequence[4]) - 128) * 64 + (ord($sequence[5]) - 128);
138 127
         } else {
139 128
           $ord = $n;
@@ -174,7 +163,8 @@  discard block
 block discarded – undo
174 163
  * @return
175 164
  *   ASCII replacement character.
176 165
  */
177
-function _transliteration_replace($ord, $unknown = '?', $langcode = NULL) {
166
+function _transliteration_replace($ord, $unknown = '?', $langcode = NULL)
167
+{
178 168
   static $map = array();
179 169
 
180 170
   //GL: set language later
@@ -196,12 +186,10 @@  discard block
 block discarded – undo
196 186
       if ($langcode != 'en' && isset($variant[$langcode])) {
197 187
         // Merge in language specific mappings.
198 188
         $map[$bank][$langcode] = $variant[$langcode] + $base;
199
-      }
200
-      else {
189
+      } else {
201 190
         $map[$bank][$langcode] = $base;
202 191
       }
203
-    }
204
-    else {
192
+    } else {
205 193
       $map[$bank][$langcode] = array();
206 194
     }
207 195
   }
Please login to merge, or discard this patch.