Test Setup Failed
Pull Request — master (#497)
by
unknown
02:29
created
lib/JSON_renderer.php 1 patch
Spacing   +99 added lines, -99 removed lines patch added patch discarded remove patch
@@ -14,53 +14,53 @@  discard block
 block discarded – undo
14 14
      * @param Book $book
15 15
      * @return array
16 16
      */
17
-    public static function getBookContentArray ($book) {
17
+    public static function getBookContentArray($book) {
18 18
         global $config;
19 19
         $i = 0;
20
-        $preferedData = array ();
20
+        $preferedData = array();
21 21
         foreach ($config['cops_prefered_format'] as $format)
22 22
         {
23 23
             if ($i == 2) { break; }
24
-            if ($data = $book->getDataFormat ($format)) {
24
+            if ($data = $book->getDataFormat($format)) {
25 25
                 $i++;
26
-                array_push ($preferedData, array ("url" => $data->getHtmlLink (),
27
-                  "viewUrl" => $data->getViewHtmlLink (), "name" => $format));
26
+                array_push($preferedData, array("url" => $data->getHtmlLink(),
27
+                  "viewUrl" => $data->getViewHtmlLink(), "name" => $format));
28 28
             }
29 29
         }
30 30
 
31 31
         $publisher = $book->getPublisher();
32
-        if (is_null ($publisher)) {
32
+        if (is_null($publisher)) {
33 33
             $pn = "";
34 34
             $pu = "";
35 35
         } else {
36 36
             $pn = $publisher->name;
37
-            $link = new LinkNavigation ($publisher->getUri ());
38
-            $pu = $link->hrefXhtml ();
37
+            $link = new LinkNavigation($publisher->getUri());
38
+            $pu = $link->hrefXhtml();
39 39
         }
40 40
 
41
-        $serie = $book->getSerie ();
42
-        if (is_null ($serie)) {
41
+        $serie = $book->getSerie();
42
+        if (is_null($serie)) {
43 43
             $sn = "";
44 44
             $scn = "";
45 45
             $su = "";
46 46
         } else {
47 47
             $sn = $serie->name;
48
-            $scn = str_format (localize ("content.series.data"), $book->seriesIndex, $serie->name);
49
-            $link = new LinkNavigation ($serie->getUri ());
50
-            $su = $link->hrefXhtml ();
48
+            $scn = str_format(localize("content.series.data"), $book->seriesIndex, $serie->name);
49
+            $link = new LinkNavigation($serie->getUri());
50
+            $su = $link->hrefXhtml();
51 51
         }
52 52
         $cc = $book->getCustomColumnValues($config['cops_calibre_custom_column_list'], true);
53 53
 
54
-        return array ("id" => $book->id,
54
+        return array("id" => $book->id,
55 55
                       "hasCover" => $book->hasCover,
56 56
                       "preferedData" => $preferedData,
57
-                      "rating" => $book->getRating (),
57
+                      "rating" => $book->getRating(),
58 58
                       "publisherName" => $pn,
59 59
                       "publisherurl" => $pu,
60
-                      "pubDate" => $book->getPubDate (),
61
-                      "languagesName" => $book->getLanguages (),
62
-                      "authorsName" => $book->getAuthorsName (),
63
-                      "tagsName" => $book->getTagsName (),
60
+                      "pubDate" => $book->getPubDate(),
61
+                      "languagesName" => $book->getLanguages(),
62
+                      "authorsName" => $book->getAuthorsName(),
63
+                      "tagsName" => $book->getTagsName(),
64 64
                       "seriesName" => $sn,
65 65
                       "seriesIndex" => $book->seriesIndex,
66 66
                       "seriesCompleteName" => $scn,
@@ -72,45 +72,45 @@  discard block
 block discarded – undo
72 72
      * @param Book $book
73 73
      * @return array
74 74
      */
75
-    public static function getFullBookContentArray ($book) {
75
+    public static function getFullBookContentArray($book) {
76 76
         global $config;
77
-        $out = self::getBookContentArray ($book);
78
-        $database = GetUrlParam (DB);
77
+        $out = self::getBookContentArray($book);
78
+        $database = GetUrlParam(DB);
79 79
 
80
-        $out ["coverurl"] = Data::getLink ($book, "jpg", "image/jpeg", Link::OPDS_IMAGE_TYPE, "cover.jpg", NULL)->hrefXhtml ();
81
-        $out ["thumbnailurl"] = Data::getLink ($book, "jpg", "image/jpeg", Link::OPDS_THUMBNAIL_TYPE, "cover.jpg", NULL, NULL, $config['cops_html_thumbnail_height'] * 2)->hrefXhtml ();
82
-        $out ["content"] = $book->getComment (false);
83
-        $out ["datas"] = array ();
84
-        $dataKindle = $book->GetMostInterestingDataToSendToKindle ();
80
+        $out ["coverurl"] = Data::getLink($book, "jpg", "image/jpeg", Link::OPDS_IMAGE_TYPE, "cover.jpg", NULL)->hrefXhtml();
81
+        $out ["thumbnailurl"] = Data::getLink($book, "jpg", "image/jpeg", Link::OPDS_THUMBNAIL_TYPE, "cover.jpg", NULL, NULL, $config['cops_html_thumbnail_height'] * 2)->hrefXhtml();
82
+        $out ["content"] = $book->getComment(false);
83
+        $out ["datas"] = array();
84
+        $dataKindle = $book->GetMostInterestingDataToSendToKindle();
85 85
         foreach ($book->getDatas() as $data) {
86
-            $tab = array ("id" => $data->id,
86
+            $tab = array("id" => $data->id,
87 87
                 "format" => $data->format, 
88
-                "url" => $data->getHtmlLink (),
89
-                "viewUrl" => $data->getViewHtmlLink (),
88
+                "url" => $data->getHtmlLink(),
89
+                "viewUrl" => $data->getViewHtmlLink(),
90 90
                 "mail" => 0, 
91 91
                 "readerUrl" => "");
92
-            if (!empty ($config['cops_mail_configuration']) && !is_null ($dataKindle) && $data->id == $dataKindle->id) {
92
+            if (!empty ($config['cops_mail_configuration']) && !is_null($dataKindle) && $data->id == $dataKindle->id) {
93 93
                 $tab ["mail"] = 1;
94 94
             }
95 95
             if ($data->format == "EPUB") {
96 96
                 $tab ["readerUrl"] = "epubreader.php?data={$data->id}&db={$database}";
97 97
             }
98
-            array_push ($out ["datas"], $tab);
98
+            array_push($out ["datas"], $tab);
99 99
         }
100
-        $out ["authors"] = array ();
101
-        foreach ($book->getAuthors () as $author) {
102
-            $link = new LinkNavigation ($author->getUri ());
103
-            array_push ($out ["authors"], array ("name" => $author->name, "url" => $link->hrefXhtml ()));
100
+        $out ["authors"] = array();
101
+        foreach ($book->getAuthors() as $author) {
102
+            $link = new LinkNavigation($author->getUri());
103
+            array_push($out ["authors"], array("name" => $author->name, "url" => $link->hrefXhtml()));
104 104
         }
105
-        $out ["tags"] = array ();
106
-        foreach ($book->getTags () as $tag) {
107
-            $link = new LinkNavigation ($tag->getUri ());
108
-            array_push ($out ["tags"], array ("name" => $tag->name, "url" => $link->hrefXhtml ()));
105
+        $out ["tags"] = array();
106
+        foreach ($book->getTags() as $tag) {
107
+            $link = new LinkNavigation($tag->getUri());
108
+            array_push($out ["tags"], array("name" => $tag->name, "url" => $link->hrefXhtml()));
109 109
         }
110 110
 
111
-        $out ["identifiers"] = array ();
112
-        foreach ($book->getIdentifiers () as $ident) {
113
-            array_push ($out ["identifiers"], array ("name" => $ident->formattedType, "url" => $ident->getUri ()));
111
+        $out ["identifiers"] = array();
112
+        foreach ($book->getIdentifiers() as $ident) {
113
+            array_push($out ["identifiers"], array("name" => $ident->formattedType, "url" => $ident->getUri()));
114 114
         }
115 115
 
116 116
         $out ["customcolumns_preview"] = $book->getCustomColumnValues($config['cops_calibre_custom_column_preview'], true);
@@ -118,51 +118,51 @@  discard block
 block discarded – undo
118 118
         return $out;
119 119
     }
120 120
 
121
-    public static function getContentArray ($entry) {
121
+    public static function getContentArray($entry) {
122 122
         if ($entry instanceof EntryBook) {
123
-            $out = array ( "title" => $entry->title);
124
-            $out ["book"] = self::getBookContentArray ($entry->book);
123
+            $out = array("title" => $entry->title);
124
+            $out ["book"] = self::getBookContentArray($entry->book);
125 125
             return $out;
126 126
         }
127
-        return array ( "title" => $entry->title, "content" => $entry->content, "navlink" => $entry->getNavLink (), "number" => $entry->numberOfElement );
127
+        return array("title" => $entry->title, "content" => $entry->content, "navlink" => $entry->getNavLink(), "number" => $entry->numberOfElement);
128 128
     }
129 129
 
130
-    public static function getContentArrayTypeahead ($page) {
131
-        $out = array ();
130
+    public static function getContentArrayTypeahead($page) {
131
+        $out = array();
132 132
         foreach ($page->entryArray as $entry) {
133 133
             if ($entry instanceof EntryBook) {
134
-                array_push ($out, array ("class" => $entry->className, "title" => $entry->title, "navlink" => $entry->book->getDetailUrl ()));
134
+                array_push($out, array("class" => $entry->className, "title" => $entry->title, "navlink" => $entry->book->getDetailUrl()));
135 135
             } else {
136
-                if (empty ($entry->className) xor Base::noDatabaseSelected ()) {
137
-                    array_push ($out, array ("class" => $entry->className, "title" => $entry->title, "navlink" => $entry->getNavLink ()));
136
+                if (empty ($entry->className) xor Base::noDatabaseSelected()) {
137
+                    array_push($out, array("class" => $entry->className, "title" => $entry->title, "navlink" => $entry->getNavLink()));
138 138
                 } else {
139
-                    array_push ($out, array ("class" => $entry->className, "title" => $entry->content, "navlink" => $entry->getNavLink ()));
139
+                    array_push($out, array("class" => $entry->className, "title" => $entry->content, "navlink" => $entry->getNavLink()));
140 140
                 }
141 141
             }
142 142
         }
143 143
         return $out;
144 144
     }
145 145
 
146
-    public static function addCompleteArray ($in) {
146
+    public static function addCompleteArray($in) {
147 147
         global $config;
148 148
         $out = $in;
149 149
 
150
-        $out ["c"] = array ("version" => VERSION, "i18n" => array (
150
+        $out ["c"] = array("version" => VERSION, "i18n" => array(
151 151
                            "coverAlt" => localize("i18n.coversection"),
152 152
                            "authorsTitle" => localize("authors.title"),
153 153
                            "bookwordTitle" => localize("bookword.title"),
154 154
                            "tagsTitle" => localize("tags.title"),
155 155
                            "linksTitle" => localize("links.title"),
156 156
                            "seriesTitle" => localize("series.title"),
157
-                           "customizeTitle" => localize ("customize.title"),
158
-                           "aboutTitle" => localize ("about.title"),
159
-                           "previousAlt" => localize ("paging.previous.alternate"),
160
-                           "nextAlt" => localize ("paging.next.alternate"),
161
-                           "searchAlt" => localize ("search.alternate"),
162
-                           "sortAlt" => localize ("sort.alternate"),
163
-                           "homeAlt" => localize ("home.alternate"),
164
-                           "cogAlt" => localize ("cog.alternate"),
165
-                           "permalinkAlt" => localize ("permalink.alternate"),
157
+                           "customizeTitle" => localize("customize.title"),
158
+                           "aboutTitle" => localize("about.title"),
159
+                           "previousAlt" => localize("paging.previous.alternate"),
160
+                           "nextAlt" => localize("paging.next.alternate"),
161
+                           "searchAlt" => localize("search.alternate"),
162
+                           "sortAlt" => localize("sort.alternate"),
163
+                           "homeAlt" => localize("home.alternate"),
164
+                           "cogAlt" => localize("cog.alternate"),
165
+                           "permalinkAlt" => localize("permalink.alternate"),
166 166
                            "publisherName" => localize("publisher.name"),
167 167
                            "pubdateTitle" => localize("pubdate.title"),
168 168
                            "languagesTitle" => localize("language.title"),
@@ -171,15 +171,15 @@  discard block
 block discarded – undo
171 171
                            "sortorderAsc" => localize("search.sortorder.asc"),
172 172
                            "sortorderDesc" => localize("search.sortorder.desc"),
173 173
                            "customizeEmail" => localize("customize.email")),
174
-                       "url" => array (
174
+                       "url" => array(
175 175
                            "detailUrl" => "index.php?page=13&id={0}&db={1}",
176 176
                            "coverUrl" => "fetch.php?id={0}&db={1}",
177 177
                            "thumbnailUrl" => "fetch.php?height=" . $config['cops_html_thumbnail_height'] . "&id={0}&db={1}"),
178
-                       "config" => array (
178
+                       "config" => array(
179 179
                            "use_fancyapps" => $config ["cops_use_fancyapps"],
180 180
                            "max_item_per_page" => $config['cops_max_item_per_page'],
181 181
                            "kindleHack"        => "",
182
-                           "server_side_rendering" => useServerSideRendering (),
182
+                           "server_side_rendering" => useServerSideRendering(),
183 183
                            "html_tag_filter" => $config['cops_html_tag_filter']));
184 184
         if ($config['cops_thumbnail_handling'] == "1") {
185 185
             $out ["c"]["url"]["thumbnailUrl"] = $out ["c"]["url"]["coverUrl"];
@@ -192,32 +192,32 @@  discard block
 block discarded – undo
192 192
         return $out;
193 193
     }
194 194
 
195
-    public static function getJson ($complete = false) {
195
+    public static function getJson($complete = false) {
196 196
         global $config;
197
-        $page = getURLParam ("page", Base::PAGE_INDEX);
198
-        $query = getURLParam ("query");
199
-        $search = getURLParam ("search");
200
-        $qid = getURLParam ("id");
201
-        $n = getURLParam ("n", "1");
202
-        $database = GetUrlParam (DB);
197
+        $page = getURLParam("page", Base::PAGE_INDEX);
198
+        $query = getURLParam("query");
199
+        $search = getURLParam("search");
200
+        $qid = getURLParam("id");
201
+        $n = getURLParam("n", "1");
202
+        $database = GetUrlParam(DB);
203 203
 
204
-        $currentPage = Page::getPage ($page, $qid, $query, $n);
205
-        $currentPage->InitializeContent ();
204
+        $currentPage = Page::getPage($page, $qid, $query, $n);
205
+        $currentPage->InitializeContent();
206 206
 
207 207
         if ($search) {
208
-            return self::getContentArrayTypeahead ($currentPage);
208
+            return self::getContentArrayTypeahead($currentPage);
209 209
         }
210 210
 
211
-        $out = array ( "title" => $currentPage->title);
212
-        $entries = array ();
211
+        $out = array("title" => $currentPage->title);
212
+        $entries = array();
213 213
         foreach ($currentPage->entryArray as $entry) {
214
-            array_push ($entries, self::getContentArray ($entry));
214
+            array_push($entries, self::getContentArray($entry));
215 215
         }
216
-        if (!is_null ($currentPage->book)) {
217
-            $out ["book"] = self::getFullBookContentArray ($currentPage->book);
216
+        if (!is_null($currentPage->book)) {
217
+            $out ["book"] = self::getFullBookContentArray($currentPage->book);
218 218
         }
219
-        $out ["databaseId"] = GetUrlParam (DB, "");
220
-        $out ["databaseName"] = Base::getDbName ();
219
+        $out ["databaseId"] = GetUrlParam(DB, "");
220
+        $out ["databaseName"] = Base::getDbName();
221 221
         if ($out ["databaseId"] == "") {
222 222
             $out ["databaseName"] = "";
223 223
         }
@@ -226,42 +226,42 @@  discard block
 block discarded – undo
226 226
             $out ["fullTitle"] = $out ["databaseName"] . " > " . $out ["fullTitle"];
227 227
         }
228 228
         $out ["page"] = $page;
229
-        $out ["multipleDatabase"] = Base::isMultipleDatabaseEnabled () ? 1 : 0;
229
+        $out ["multipleDatabase"] = Base::isMultipleDatabaseEnabled()?1:0;
230 230
         $out ["entries"] = $entries;
231 231
         $out ["isPaginated"] = 0;
232
-        if ($currentPage->isPaginated ()) {
233
-            $prevLink = $currentPage->getPrevLink ();
234
-            $nextLink = $currentPage->getNextLink ();
232
+        if ($currentPage->isPaginated()) {
233
+            $prevLink = $currentPage->getPrevLink();
234
+            $nextLink = $currentPage->getNextLink();
235 235
             $out ["isPaginated"] = 1;
236 236
             $out ["prevLink"] = "";
237
-            if (!is_null ($prevLink)) {
238
-                $out ["prevLink"] = $prevLink->hrefXhtml ();
237
+            if (!is_null($prevLink)) {
238
+                $out ["prevLink"] = $prevLink->hrefXhtml();
239 239
             }
240 240
             $out ["nextLink"] = "";
241
-            if (!is_null ($nextLink)) {
242
-                $out ["nextLink"] = $nextLink->hrefXhtml ();
241
+            if (!is_null($nextLink)) {
242
+                $out ["nextLink"] = $nextLink->hrefXhtml();
243 243
             }
244
-            $out ["maxPage"] = $currentPage->getMaxPage ();
244
+            $out ["maxPage"] = $currentPage->getMaxPage();
245 245
             $out ["currentPage"] = $currentPage->n;
246 246
         }
247
-        if (!is_null (getURLParam ("complete")) || $complete) {
248
-            $out = self::addCompleteArray ($out);
247
+        if (!is_null(getURLParam("complete")) || $complete) {
248
+            $out = self::addCompleteArray($out);
249 249
        }
250 250
 
251 251
         $out ["containsBook"] = 0;
252
-        if ($currentPage->containsBook ()) {
252
+        if ($currentPage->containsBook()) {
253 253
             $out ["containsBook"] = 1;
254 254
         }
255 255
 
256
-        $out["abouturl"] = "index.php" . addURLParameter ("?page=" . Base::PAGE_ABOUT, DB, $database);
256
+        $out["abouturl"] = "index.php" . addURLParameter("?page=" . Base::PAGE_ABOUT, DB, $database);
257 257
 
258 258
         if ($page == Base::PAGE_ABOUT) {
259
-            $temp = preg_replace ("/\<h1\>About COPS\<\/h1\>/", "<h1>About COPS " . VERSION . "</h1>", file_get_contents('about.html'));
259
+            $temp = preg_replace("/\<h1\>About COPS\<\/h1\>/", "<h1>About COPS " . VERSION . "</h1>", file_get_contents('about.html'));
260 260
             $out ["fullhtml"] = $temp;
261 261
         }
262 262
 
263 263
         $out ["homeurl"] = "index.php";
264
-        if ($page != Base::PAGE_INDEX && !is_null ($database)) $out ["homeurl"] = $out ["homeurl"] .  "?" . addURLParameter ("", DB, $database);
264
+        if ($page != Base::PAGE_INDEX && !is_null($database)) $out ["homeurl"] = $out ["homeurl"] . "?" . addURLParameter("", DB, $database);
265 265
 
266 266
         return $out;
267 267
     }
Please login to merge, or discard this patch.
lib/Book.php 1 patch
Spacing   +59 added lines, -59 removed lines patch added patch discarded remove patch
@@ -7,55 +7,55 @@  discard block
 block discarded – undo
7 7
  */
8 8
 
9 9
 // Silly thing because PHP forbid string concatenation in class const
10
-define ('SQL_BOOKS_LEFT_JOIN', 'left outer join comments on comments.book = books.id
10
+define('SQL_BOOKS_LEFT_JOIN', 'left outer join comments on comments.book = books.id
11 11
                                 left outer join books_ratings_link on books_ratings_link.book = books.id
12 12
                                 left outer join ratings on books_ratings_link.rating = ratings.id ');
13
-define ('SQL_BOOKS_ALL', 'select {0} from books ' . SQL_BOOKS_LEFT_JOIN . ' order by books.sort ');
14
-define ('SQL_BOOKS_BY_PUBLISHER', 'select {0} from books_publishers_link, books ' . SQL_BOOKS_LEFT_JOIN . '
13
+define('SQL_BOOKS_ALL', 'select {0} from books ' . SQL_BOOKS_LEFT_JOIN . ' order by books.sort ');
14
+define('SQL_BOOKS_BY_PUBLISHER', 'select {0} from books_publishers_link, books ' . SQL_BOOKS_LEFT_JOIN . '
15 15
                                                     where books_publishers_link.book = books.id and publisher = ? {1} order by publisher');
16
-define ('SQL_BOOKS_BY_FIRST_LETTER', 'select {0} from books ' . SQL_BOOKS_LEFT_JOIN . '
16
+define('SQL_BOOKS_BY_FIRST_LETTER', 'select {0} from books ' . SQL_BOOKS_LEFT_JOIN . '
17 17
                                                     where upper (books.sort) like ? order by books.sort');
18
-define ('SQL_BOOKS_BY_AUTHOR', 'select {0} from books_authors_link, books ' . SQL_BOOKS_LEFT_JOIN . '
18
+define('SQL_BOOKS_BY_AUTHOR', 'select {0} from books_authors_link, books ' . SQL_BOOKS_LEFT_JOIN . '
19 19
                                                     left outer join books_series_link on books_series_link.book = books.id
20 20
                                                     where books_authors_link.book = books.id and author = ? {1} order by series desc, series_index asc, pubdate asc');
21
-define ('SQL_BOOKS_BY_SERIE', 'select {0} from books_series_link, books ' . SQL_BOOKS_LEFT_JOIN . '
21
+define('SQL_BOOKS_BY_SERIE', 'select {0} from books_series_link, books ' . SQL_BOOKS_LEFT_JOIN . '
22 22
                                                     where books_series_link.book = books.id and series = ? {1} order by series_index');
23
-define ('SQL_BOOKS_BY_TAG', 'select {0} from books_tags_link, books ' . SQL_BOOKS_LEFT_JOIN . '
23
+define('SQL_BOOKS_BY_TAG', 'select {0} from books_tags_link, books ' . SQL_BOOKS_LEFT_JOIN . '
24 24
                                                     where books_tags_link.book = books.id and tag = ? {1} order by sort');
25
-define ('SQL_BOOKS_BY_LANGUAGE', 'select {0} from books_languages_link, books ' . SQL_BOOKS_LEFT_JOIN . '
25
+define('SQL_BOOKS_BY_LANGUAGE', 'select {0} from books_languages_link, books ' . SQL_BOOKS_LEFT_JOIN . '
26 26
                                                     where books_languages_link.book = books.id and lang_code = ? {1} order by sort');
27
-define ('SQL_BOOKS_BY_CUSTOM', 'select {0} from {2}, books ' . SQL_BOOKS_LEFT_JOIN . '
27
+define('SQL_BOOKS_BY_CUSTOM', 'select {0} from {2}, books ' . SQL_BOOKS_LEFT_JOIN . '
28 28
                                                     where {2}.book = books.id and {2}.{3} = ? {1} order by sort');
29
-define ('SQL_BOOKS_BY_CUSTOM_BOOL_TRUE', 'select {0} from {2}, books ' . SQL_BOOKS_LEFT_JOIN . '
29
+define('SQL_BOOKS_BY_CUSTOM_BOOL_TRUE', 'select {0} from {2}, books ' . SQL_BOOKS_LEFT_JOIN . '
30 30
                                                     where {2}.book = books.id and {2}.value = 1 {1} order by sort');
31
-define ('SQL_BOOKS_BY_CUSTOM_BOOL_FALSE', 'select {0} from {2}, books ' . SQL_BOOKS_LEFT_JOIN . '
31
+define('SQL_BOOKS_BY_CUSTOM_BOOL_FALSE', 'select {0} from {2}, books ' . SQL_BOOKS_LEFT_JOIN . '
32 32
                                                     where {2}.book = books.id and {2}.value = 0 {1} order by sort');
33
-define ('SQL_BOOKS_BY_CUSTOM_BOOL_NULL', 'select {0} from books ' . SQL_BOOKS_LEFT_JOIN . '
33
+define('SQL_BOOKS_BY_CUSTOM_BOOL_NULL', 'select {0} from books ' . SQL_BOOKS_LEFT_JOIN . '
34 34
                                                     where books.id not in (select book from {2}) {1} order by sort');
35
-define ('SQL_BOOKS_BY_CUSTOM_RATING', 'select {0} from books ' . SQL_BOOKS_LEFT_JOIN . '
35
+define('SQL_BOOKS_BY_CUSTOM_RATING', 'select {0} from books ' . SQL_BOOKS_LEFT_JOIN . '
36 36
                                                     left join {2} on {2}.book = books.id
37 37
                                                     left join {3} on {3}.id = {2}.{4}
38 38
                                                     where {3}.value = ?  order by sort');
39
-define ('SQL_BOOKS_BY_CUSTOM_RATING_NULL', 'select {0} from books ' . SQL_BOOKS_LEFT_JOIN . '
39
+define('SQL_BOOKS_BY_CUSTOM_RATING_NULL', 'select {0} from books ' . SQL_BOOKS_LEFT_JOIN . '
40 40
 								                    left join {2} on {2}.book = books.id
41 41
 								                    left join {3} on {3}.id = {2}.{4}
42 42
                                                     where ((books.id not in (select {2}.book from {2})) or ({3}.value = 0)) {1} order by sort');
43
-define ('SQL_BOOKS_BY_CUSTOM_DATE', 'select {0} from {2}, books ' . SQL_BOOKS_LEFT_JOIN . '
43
+define('SQL_BOOKS_BY_CUSTOM_DATE', 'select {0} from {2}, books ' . SQL_BOOKS_LEFT_JOIN . '
44 44
                                                     where {2}.book = books.id and date({2}.value) = ? {1} order by sort');
45
-define ('SQL_BOOKS_BY_CUSTOM_DIRECT', 'select {0} from {2}, books ' . SQL_BOOKS_LEFT_JOIN . '
45
+define('SQL_BOOKS_BY_CUSTOM_DIRECT', 'select {0} from {2}, books ' . SQL_BOOKS_LEFT_JOIN . '
46 46
                                                     where {2}.book = books.id and {2}.value = ? {1} order by sort');
47
-define ('SQL_BOOKS_BY_CUSTOM_DIRECT_ID', 'select {0} from {2}, books ' . SQL_BOOKS_LEFT_JOIN . '
47
+define('SQL_BOOKS_BY_CUSTOM_DIRECT_ID', 'select {0} from {2}, books ' . SQL_BOOKS_LEFT_JOIN . '
48 48
                                                     where {2}.book = books.id and {2}.id = ? {1} order by sort');
49
-define ('SQL_BOOKS_QUERY', 'select {0} from books ' . SQL_BOOKS_LEFT_JOIN . '
49
+define('SQL_BOOKS_QUERY', 'select {0} from books ' . SQL_BOOKS_LEFT_JOIN . '
50 50
                                                     where (
51 51
                                                     exists (select null from authors, books_authors_link where book = books.id and author = authors.id and authors.name like ?) or
52 52
                                                     exists (select null from tags, books_tags_link where book = books.id and tag = tags.id and tags.name like ?) or
53 53
                                                     exists (select null from series, books_series_link on book = books.id and books_series_link.series = series.id and series.name like ?) or
54 54
                                                     exists (select null from publishers, books_publishers_link where book = books.id and books_publishers_link.publisher = publishers.id and publishers.name like ?) or
55 55
                                                     title like ?) {1} order by books.sort');
56
-define ('SQL_BOOKS_RECENT', 'select {0} from books ' . SQL_BOOKS_LEFT_JOIN . '
56
+define('SQL_BOOKS_RECENT', 'select {0} from books ' . SQL_BOOKS_LEFT_JOIN . '
57 57
                                                     where 1=1 {1} order by timestamp desc limit ');
58
-define ('SQL_BOOKS_BY_RATING', 'select {0} from books ' . SQL_BOOKS_LEFT_JOIN . '
58
+define('SQL_BOOKS_BY_RATING', 'select {0} from books ' . SQL_BOOKS_LEFT_JOIN . '
59 59
                                                     where books_ratings_link.book = books.id and ratings.id = ? {1} order by sort');
60 60
 
61 61
 require('Identifier.php');
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
     public $tags = NULL;
109 109
     public $identifiers = NULL;
110 110
     public $languages = NULL;
111
-    public $format = array ();
111
+    public $format = array();
112 112
 
113 113
 
114 114
     public function __construct($line) {
@@ -130,24 +130,24 @@  discard block
 block discarded – undo
130 130
     }
131 131
 
132 132
     public function getEntryId() {
133
-        return self::ALL_BOOKS_UUID.':'.$this->uuid;
133
+        return self::ALL_BOOKS_UUID . ':' . $this->uuid;
134 134
     }
135 135
 
136
-    public static function getEntryIdByLetter ($startingLetter) {
137
-        return self::ALL_BOOKS_ID.':letter:'.$startingLetter;
136
+    public static function getEntryIdByLetter($startingLetter) {
137
+        return self::ALL_BOOKS_ID . ':letter:' . $startingLetter;
138 138
     }
139 139
 
140
-    public function getUri () {
141
-        return '?page='.parent::PAGE_BOOK_DETAIL.'&id=' . $this->id;
140
+    public function getUri() {
141
+        return '?page=' . parent::PAGE_BOOK_DETAIL . '&id=' . $this->id;
142 142
     }
143 143
 
144
-    public function getDetailUrl () {
144
+    public function getDetailUrl() {
145 145
         $urlParam = $this->getUri();
146
-        if (!is_null(GetUrlParam(DB))) $urlParam = addURLParameter($urlParam, DB, GetUrlParam (DB));
146
+        if (!is_null(GetUrlParam(DB))) $urlParam = addURLParameter($urlParam, DB, GetUrlParam(DB));
147 147
         return 'index.php' . $urlParam;
148 148
     }
149 149
 
150
-    public function getTitle () {
150
+    public function getTitle() {
151 151
         return $this->title;
152 152
     }
153 153
 
@@ -156,22 +156,22 @@  discard block
 block discarded – undo
156 156
     /**
157 157
      * @return Author[]
158 158
      */
159
-    public function getAuthors () {
159
+    public function getAuthors() {
160 160
         if (is_null($this->authors)) {
161 161
             $this->authors = Author::getAuthorByBookId($this->id);
162 162
         }
163 163
         return $this->authors;
164 164
     }
165 165
 
166
-    public function getAuthorsName () {
167
-        return implode(', ', array_map(function ($author) { return $author->name; }, $this->getAuthors()));
166
+    public function getAuthorsName() {
167
+        return implode(', ', array_map(function($author) { return $author->name; }, $this->getAuthors()));
168 168
     }
169 169
 
170
-    public function getAuthorsSort () {
171
-        return implode(', ', array_map(function ($author) { return $author->sort; }, $this->getAuthors()));
170
+    public function getAuthorsSort() {
171
+        return implode(', ', array_map(function($author) { return $author->sort; }, $this->getAuthors()));
172 172
     }
173 173
 
174
-    public function getPublisher () {
174
+    public function getPublisher() {
175 175
         if (is_null($this->publisher)) {
176 176
             $this->publisher = Publisher::getPublisherByBookId($this->id);
177 177
         }
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
210 210
      * @return Tag[]
211 211
      */
212 212
     public function getTags() {
213
-        if (is_null ($this->tags)) {
213
+        if (is_null($this->tags)) {
214 214
             $this->tags = array();
215 215
 
216 216
             $result = parent::getDb()->prepare('select tags.id as id, name
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
228 228
     }
229 229
 
230 230
     public function getTagsName() {
231
-        return implode(', ', array_map(function ($tag) { return $tag->name; }, $this->getTags()));
231
+        return implode(', ', array_map(function($tag) { return $tag->name; }, $this->getTags()));
232 232
     }
233 233
 
234 234
 
@@ -236,7 +236,7 @@  discard block
 block discarded – undo
236 236
      * @return Identifiers[]
237 237
      */
238 238
     public function getIdentifiers() {
239
-        if (is_null ($this->identifiers)) {
239
+        if (is_null($this->identifiers)) {
240 240
             $this->identifiers = array();
241 241
 
242 242
             $result = parent::getDb()->prepare('select type, val, id
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
 
303 303
     public function getDataById($idData)
304 304
     {
305
-        $reduced = array_filter($this->getDatas(), function ($data) use ($idData) {
305
+        $reduced = array_filter($this->getDatas(), function($data) use ($idData) {
306 306
             return $data->id == $idData;
307 307
         });
308 308
         return reset($reduced);
@@ -326,7 +326,7 @@  discard block
 block discarded – undo
326 326
         if (empty ($this->pubdate)) {
327 327
             return '';
328 328
         }
329
-        $dateY = (int) substr($this->pubdate, 0, 4);
329
+        $dateY = (int)substr($this->pubdate, 0, 4);
330 330
         if ($dateY > 102) {
331 331
             return str_pad($dateY, 4, '0', STR_PAD_LEFT);
332 332
         }
@@ -335,8 +335,8 @@  discard block
 block discarded – undo
335 335
 
336 336
     public function getComment($withSerie = true) {
337 337
         $addition = '';
338
-        $se = $this->getSerie ();
339
-        if (!is_null ($se) && $withSerie) {
338
+        $se = $this->getSerie();
339
+        if (!is_null($se) && $withSerie) {
340 340
             $addition = $addition . '<strong>' . localize('content.series') . '</strong>' . str_format(localize('content.series.data'), $this->seriesIndex, htmlspecialchars($se->name)) . "<br />\n";
341 341
         }
342 342
         if (preg_match('/<\/(div|p|a|span)>/', $this->comment))
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
     }
351 351
 
352 352
     public function getDataFormat($format) {
353
-        $reduced = array_filter($this->getDatas(), function ($data) use ($format) {
353
+        $reduced = array_filter($this->getDatas(), function($data) use ($format) {
354 354
             return $data->format == $format;
355 355
         });
356 356
         return reset($reduced);
@@ -371,11 +371,11 @@  discard block
 block discarded – undo
371 371
 
372 372
         if ($relative)
373 373
         {
374
-            return $this->relativePath.'/'.$file;
374
+            return $this->relativePath . '/' . $file;
375 375
         }
376 376
         else
377 377
         {
378
-            return $this->path.'/'.$file;
378
+            return $this->path . '/' . $file;
379 379
         }
380 380
     }
381 381
 
@@ -395,7 +395,7 @@  discard block
 block discarded – undo
395 395
             }
396 396
             $epub->Authors($authorArray);
397 397
             $epub->Language($this->getLanguages());
398
-            $epub->Description ($this->getComment(false));
398
+            $epub->Description($this->getComment(false));
399 399
             $epub->Subjects($this->getTagsName());
400 400
             $epub->Cover2($this->getFilePath('jpg'), 'image/jpeg');
401 401
             $epub->Calibre($this->uuid);
@@ -405,7 +405,7 @@  discard block
 block discarded – undo
405 405
                 $epub->SerieIndex($this->seriesIndex);
406 406
             }
407 407
             $filename = $data->getUpdatedFilenameEpub();
408
-            if ($config['cops_provide_kepub'] == '1'  && preg_match('/Kobo/', $_SERVER['HTTP_USER_AGENT'])) {
408
+            if ($config['cops_provide_kepub'] == '1' && preg_match('/Kobo/', $_SERVER['HTTP_USER_AGENT'])) {
409 409
                 $epub->updateForKepub();
410 410
                 $filename = $data->getUpdatedFilenameKepub();
411 411
             }
@@ -431,11 +431,11 @@  discard block
 block discarded – undo
431 431
             if (!is_null($width)) {
432 432
                 $nw = $width;
433 433
                 if ($nw >= $w) { return false; }
434
-                $nh = ($nw*$h)/$w;
434
+                $nh = ($nw * $h) / $w;
435 435
             } else {
436 436
                 $nh = $height;
437 437
                 if ($nh >= $h) { return false; }
438
-                $nw = ($nh*$w)/$h;
438
+                $nw = ($nh * $w) / $h;
439 439
             }
440 440
         } else {
441 441
             return false;
@@ -443,16 +443,16 @@  discard block
 block discarded – undo
443 443
 
444 444
         //draw the image
445 445
         $src_img = imagecreatefromjpeg($file);
446
-        $dst_img = imagecreatetruecolor($nw,$nh);
447
-        imagecopyresampled($dst_img, $src_img, 0, 0, 0, 0, $nw, $nh, $w, $h);//resizing the image
448
-        imagejpeg($dst_img,$outputfile,80);
446
+        $dst_img = imagecreatetruecolor($nw, $nh);
447
+        imagecopyresampled($dst_img, $src_img, 0, 0, 0, 0, $nw, $nh, $w, $h); //resizing the image
448
+        imagejpeg($dst_img, $outputfile, 80);
449 449
         imagedestroy($src_img);
450 450
         imagedestroy($dst_img);
451 451
 
452 452
         return true;
453 453
     }
454 454
 
455
-    public function getLinkArray ()
455
+    public function getLinkArray()
456 456
     {
457 457
         $linkArray = array();
458 458
 
@@ -477,7 +477,7 @@  discard block
 block discarded – undo
477 477
         }
478 478
 
479 479
         $serie = $this->getSerie();
480
-        if (!is_null ($serie)) {
480
+        if (!is_null($serie)) {
481 481
             array_push($linkArray, new LinkNavigation($serie->getUri(), 'related', str_format(localize('content.series.data'), $this->seriesIndex, $serie->name)));
482 482
         }
483 483
 
@@ -502,13 +502,13 @@  discard block
 block discarded – undo
502 502
         $entry = new Entry(localize('allbooks.title'),
503 503
                           self::ALL_BOOKS_ID,
504 504
                           str_format(localize('allbooks.alphabetical', $nBooks), $nBooks), 'text',
505
-                          array(new LinkNavigation('?page='.parent::PAGE_ALL_BOOKS)), '', $nBooks);
505
+                          array(new LinkNavigation('?page=' . parent::PAGE_ALL_BOOKS)), '', $nBooks);
506 506
         array_push($result, $entry);
507 507
         if ($config['cops_recentbooks_limit'] > 0) {
508 508
             $entry = new Entry(localize('recent.title'),
509 509
                               self::ALL_RECENT_BOOKS_ID,
510 510
                               str_format(localize('recent.list'), $config['cops_recentbooks_limit']), 'text',
511
-                              array ( new LinkNavigation ('?page='.parent::PAGE_ALL_RECENT_BOOKS)), '', $config['cops_recentbooks_limit']);
511
+                              array(new LinkNavigation('?page=' . parent::PAGE_ALL_RECENT_BOOKS)), '', $config['cops_recentbooks_limit']);
512 512
             array_push($result, $entry);
513 513
         }
514 514
         return $result;
@@ -604,7 +604,7 @@  discard block
 block discarded – undo
604 604
     }
605 605
 
606 606
     public static function getBooks($n) {
607
-        list ($entryArray, $totalNumber) = self::getEntryArray(self::SQL_BOOKS_ALL , array (), $n);
607
+        list ($entryArray, $totalNumber) = self::getEntryArray(self::SQL_BOOKS_ALL, array(), $n);
608 608
         return array($entryArray, $totalNumber);
609 609
     }
610 610
 
@@ -621,7 +621,7 @@  discard block
 block discarded – undo
621 621
         {
622 622
             array_push($entryArray, new Entry($post->title, Book::getEntryIdByLetter($post->title),
623 623
                 str_format(localize('bookword', $post->count), $post->count), 'text',
624
-                array(new LinkNavigation('?page='.parent::PAGE_ALL_BOOKS_LETTER.'&id='. rawurlencode($post->title))), '', $post->count));
624
+                array(new LinkNavigation('?page=' . parent::PAGE_ALL_BOOKS_LETTER . '&id=' . rawurlencode($post->title))), '', $post->count));
625 625
         }
626 626
         return $entryArray;
627 627
     }
@@ -646,7 +646,7 @@  discard block
 block discarded – undo
646 646
 
647 647
     public static function getAllRecentBooks() {
648 648
         global $config;
649
-        list ($entryArray, ) = self::getEntryArray(self::SQL_BOOKS_RECENT . $config['cops_recentbooks_limit'], array(), -1);
649
+        list ($entryArray,) = self::getEntryArray(self::SQL_BOOKS_RECENT . $config['cops_recentbooks_limit'], array(), -1);
650 650
         return $entryArray;
651 651
     }
652 652
 
Please login to merge, or discard this patch.
lib/Identifier.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
     public function __construct($post)
18 18
     {
19 19
         $this->id = $post->id;
20
-        $this->type = strtolower($post->type);;
20
+        $this->type = strtolower($post->type); ;
21 21
         $this->val = $post->val;
22 22
         $this->formatType();
23 23
     }
Please login to merge, or discard this patch.