+global\Author::getAllAuthorsByFirstLetter()

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	2

2 Methods

Rating	Name	Duplication	Size	Complexity
A	Author::__construct()	0	5	1
A	Author::getUri()	0	3	1

<?php
/**
 * COPS (Calibre OPDS PHP Server) class file
 *
 * @license    GPL 2 (http://www.gnu.org/licenses/gpl.html)
 * @author     S�bastien Lucas <sebastien@slucas.fr>
 */

require_once('base.php');

class Author extends Base {
    const ALL_AUTHORS_ID = "cops:authors";

    const SQL_AUTHORS_BY_FIRST_LETTER = 
    	"select authors.id as id, authors.name as name, authors.sort as sort, count(*) as count 
    	 from authors
    		inner join books_authors_link as link on link.author = authors.id
    		inner join ({0}) as filter on filter.id = link.book
    	 where upper (authors.sort) like ? 
    	 group by authors.id, authors.name, authors.sort 
    	 order by sort";
    const SQL_AUTHORS_FOR_SEARCH = 
    	"select authors.id as id, authors.name as name, authors.sort as sort, count(*) as count 
    	 from authors
    		inner join books_authors_link as link on link.author = authors.id
    		inner join ({0}) as filter on filter.id = link.book 
    	 where (upper (authors.sort) like ? or upper (authors.name) like ?) 
    	 group by authors.id, authors.name, authors.sort 
    	 order by sort";
    const SQL_ALL_AUTHORS = 
    	"select authors.id as id, authors.name as name, authors.sort as sort, count(*) as count 
    	 from authors 
    		inner join books_authors_link as link on author = authors.id
    		inner join ({0}) as filter on filter.id = link.book 
    	 group by authors.id, authors.name, authors.sort 
    	 order by sort";
    const SQL_ALL_AUTHORS_FIRST_LETTERS = 
    	"select substr (upper (sort), 1, 1) as title, count(*) as count
		 from authors
    		inner join books_authors_link as link on link.author = authors.id
    		inner join ({0}) as filter on filter.id = link.book
		 group by substr (upper (sort), 1, 1)
		 order by substr (upper (sort), 1, 1)";

    public $id;
    public $name;
    public $sort;

    public function __construct($post) {
        $this->id = $post->id;
        $this->name = str_replace("|", ",", $post->name);
        $this->sort = $post->sort;
    }

    public function getUri () {
        return "?page=".parent::PAGE_AUTHOR_DETAIL."&id=$this->id";
    }

    public function getEntryId () {
        return self::ALL_AUTHORS_ID.":".$this->id;
    }

    public static function getEntryIdByLetter ($startingLetter) {
        return self::ALL_AUTHORS_ID.":letter:".$startingLetter;
    }

    public static function getCount() {
        // str_format (localize("authors.alphabetical", count(array))
        return parent::getCountGeneric ("authors", self::ALL_AUTHORS_ID, parent::PAGE_ALL_AUTHORS);

It seems like you call parent on a different method (getCountGeneric() instead of getCount()). Are you sure this is correct? If so, you might want to change this to $this->getCountGeneric().

    }

    public static function getAllAuthorsFirstLetters() {
        list (, $result) = parent::executeFilteredQuery(self::SQL_ALL_AUTHORS_FIRST_LETTERS, array(), -1);

It seems like you call parent on a different method (executeFilteredQuery() instead of getAllAuthorsFirstLetters()). Are you sure this is correct? If so, you might want to change this to $this->executeFilteredQuery().

        $entryArray = array();
        while ($post = $result->fetchObject ())
        {
            array_push ($entryArray, new Entry ($post->title, Author::getEntryIdByLetter ($post->title),
                str_format (localize("authorword", $post->count), $post->count), "text",
                array ( new LinkNavigation ("?page=".parent::PAGE_AUTHORS_FIRST_LETTER."&id=". rawurlencode ($post->title))), "", $post->count));
        }
        return $entryArray;
    }

    public static function getAuthorsByStartingLetter($letter) {
        return self::getEntryArray (self::SQL_AUTHORS_BY_FIRST_LETTER, array ($letter . "%"));
    }

    public static function getAuthorsForSearch($query) {
        return self::getEntryArray (self::SQL_AUTHORS_FOR_SEARCH, array ($query . "%", $query . "%"));
    }

    public static function getAllAuthors() {
        return self::getEntryArray (self::SQL_ALL_AUTHORS, array ());
    }

    public static function getEntryArray ($query, $params) {
        return Base::getEntryArrayWithBookNumber ($query, $params, "Author");
    }

    public static function getAuthorById ($authorId) {
        $result = parent::getDb ()->prepare('select authors.id as id, authors.name as name, authors.sort as sort, count(*) as count from authors where id = ?');

It seems like you call parent on a different method (getDb() instead of getAuthorById()). Are you sure this is correct? If so, you might want to change this to $this->getDb().

        $result->execute (array ($authorId));
        $post = $result->fetchObject ();
        return new Author ($post);
    }

    public static function getAuthorByBookId ($bookId) {
        $result = parent::getDb ()->prepare('select authors.id as id, authors.name as name, authors.sort as sort from authors, books_authors_link

It seems like you call parent on a different method (getDb() instead of getAuthorByBookId()). Are you sure this is correct? If so, you might want to change this to $this->getDb().

where author = authors.id
and book = ?');
        $result->execute (array ($bookId));
        $authorArray = array ();
        while ($post = $result->fetchObject ()) {
            array_push ($authorArray, new Author ($post));
        }
        return $authorArray;
    }
}