Inspection of "Remove IE9 from sauce (way too old to maintain)" - seblucas/cops - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6fb385...fab96a )

by Sébastien

created 2016-12-23 08:33 UTC

Status

Upper-Lower-Casing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -23,9 +23,9 @@
 block discarded – undo
     header('Pragma: public');
     header('Cache-Control: maxage=' . $expires);
     header('Expires: ' . gmdate('D, d M Y H:i:s', time()+$expires) . ' GMT');
-    $bookId = getURLParam('id', NULL);
+    $bookId = getURLParam('id', null);
     $type   = getURLParam('type', 'jpg');
-    $idData = getURLParam('data', NULL);
+    $idData = getURLParam('data', null);
     if (is_null($bookId)) {
         $book = Book::getBookByDataId($idData);
     } else {

Please login to merge, or discard this patch.

config_default.php 1 patch

Upper-Lower-Casing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -231,7 +231,7 @@  discard block
 block discarded – undo
      *                                           "address.from"  => "[email protected]"
      *                                           );
      */
-    $config['cops_mail_configuration'] = NULL;
+    $config['cops_mail_configuration'] = null;
 
     /*
      * Use filter in HTML catalog
@@ -303,7 +303,7 @@  discard block
 block discarded – undo
      * array( "username" => "xxx", "password" => "secret") : Enable PHP password protection
      * NULL : Disable PHP password protection (You can still use htpasswd)
      */
-    $config['cops_basic_authentication'] = NULL;
+    $config['cops_basic_authentication'] = null;
 
     /*
      * Which template is used by default :

Please login to merge, or discard this patch.

index.php 1 patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -50,7 +50,7 @@
 block discarded – undo
     }
     $headcontent = file_get_contents('templates/' . getCurrentTemplate() . '/file.html');
     $template = new doT();
-    $dot = $template->template($headcontent, NULL);
+    $dot = $template->template($headcontent, null);
     echo($dot($data));
 ?><body>
 <?php

Please login to merge, or discard this patch.

transliteration.php 1 patch

Upper-Lower-Casing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -25,7 +25,7 @@  discard block
 block discarded – undo
  * @return
  *   Transliterated text.
  */
-function _transliteration_process($string, $unknown = '?', $source_langcode = NULL) {
+function _transliteration_process($string, $unknown = '?', $source_langcode = null) {
   // ASCII is always valid NFC! If we're only ever given plain ASCII, we can
   // avoid the overhead of initializing the decomposition tables by skipping
   // out early.
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
  * @return
  *   ASCII replacement character.
  */
-function _transliteration_replace($ord, $unknown = '?', $langcode = NULL) {
+function _transliteration_replace($ord, $unknown = '?', $langcode = null) {
   static $map = array();
 
   //GL: set language later

Please login to merge, or discard this patch.

lib/CustomColumnTypeInteger.php 1 patch

Upper-Lower-Casing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -55,7 +55,7 @@  discard block
 block discarded – undo
     public function getDescription()
     {
         $desc = $this->getDatabaseDescription();
-        if ($desc === NULL || empty($desc)) $desc = str_format(localize("customcolumn.description"), $this->getTitle());
+        if ($desc === null || empty($desc)) $desc = str_format(localize("customcolumn.description"), $this->getTitle());
         return $desc;
     }
 
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
         if ($post = $result->fetchObject()) {
             return new CustomColumn($post->value, $post->value, $this);
         }
-        return new CustomColumn(NULL, localize("customcolumn.int.unknown"), $this);
+        return new CustomColumn(null, localize("customcolumn.int.unknown"), $this);
     }
 
     public function isSearchable()

Please login to merge, or discard this patch.

lib/CustomColumnType.php 1 patch

Upper-Lower-Casing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -37,14 +37,14 @@  discard block
 block discarded – undo
     /** @var string the datatype of this column (one of the CUSTOM_TYPE_* constant values) */
     public $datatype;
     /** @var null|Entry[] */
-    private $customValues = NULL;
+    private $customValues = null;
 
     protected function __construct($pcustomId, $pdatatype)
     {
         $this->columnTitle = self::getTitleByCustomID($pcustomId);
         $this->customId = $pcustomId;
         $this->datatype = $pdatatype;
-        $this->customValues = NULL;
+        $this->customValues = null;
     }
 
     /**
@@ -110,9 +110,9 @@  discard block
 block discarded – undo
         $result->execute(array($this->customId));
         if ($post = $result->fetchObject()) {
             $json = json_decode($post->display);
-            return (isset($json->description) && !empty($json->description)) ? $json->description : NULL;
+            return (isset($json->description) && !empty($json->description)) ? $json->description : null;
         }
-        return NULL;
+        return null;
     }
 
     /**
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
         if ($post = $result->fetchObject()) {
             return $post->datatype;
         }
-        return NULL;
+        return null;
     }
 
     /**
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
             case self::CUSTOM_TYPE_BOOL:
                 return self::$customColumnCacheID[$customId] = new CustomColumnTypeBool($customId);
             case self::CUSTOM_TYPE_COMPOSITE:
-                return NULL; //TODO Currently not supported
+                return null; //TODO Currently not supported
             default:
                 throw new Exception("Unkown column type: " . $datatype);
         }
@@ -229,7 +229,7 @@  discard block
 block discarded – undo
         if ($post = $result->fetchObject()) {
             return self::$customColumnCacheLookup[$lookup] = self::createByCustomID($post->id);
         }
-        return self::$customColumnCacheLookup[$lookup] = NULL;
+        return self::$customColumnCacheLookup[$lookup] = null;
     }
 
     /**
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
     public function getAllCustomValues()
     {
         // lazy loading
-        if ($this->customValues == NULL)
+        if ($this->customValues == null)
             $this->customValues = $this->getAllCustomValuesFromDatabase();
 
         return $this->customValues;

Please login to merge, or discard this patch.

lib/Language.php 1 patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -45,7 +45,7 @@
 block discarded – undo
         if ($post = $result->fetchObject ()) {
             return new Language ($post->id, Language::getLanguageString ($post->lang_code));
         }
-        return NULL;
+        return null;
     }
 
 

Please login to merge, or discard this patch.

lib/CustomColumnTypeComment.php 1 patch

Upper-Lower-Casing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -41,13 +41,13 @@  discard block
 block discarded – undo
 
     protected function getAllCustomValuesFromDatabase()
     {
-        return NULL;
+        return null;
     }
 
     public function getDescription()
     {
         $desc = $this->getDatabaseDescription();
-        if ($desc === NULL || empty($desc)) $desc = str_format(localize("customcolumn.description"), $this->getTitle());
+        if ($desc === null || empty($desc)) $desc = str_format(localize("customcolumn.description"), $this->getTitle());
         return $desc;
     }
 
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
         if ($post = $result->fetchObject()) {
             return new CustomColumn($post->id, $post->value, $this);
         }
-        return new CustomColumn(NULL, localize("customcolumn.float.unknown"), $this);
+        return new CustomColumn(null, localize("customcolumn.float.unknown"), $this);
     }
 
     public function isSearchable()

Please login to merge, or discard this patch.

lib/JSON_renderer.php 1 patch

Upper-Lower-Casing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -76,8 +76,8 @@
 block discarded – undo
         $out = self::getBookContentArray ($book);
         $database = GetUrlParam (DB);
 
-        $out ["coverurl"] = Data::getLink ($book, "jpg", "image/jpeg", Link::OPDS_IMAGE_TYPE, "cover.jpg", NULL)->hrefXhtml ();
-        $out ["thumbnailurl"] = Data::getLink ($book, "jpg", "image/jpeg", Link::OPDS_THUMBNAIL_TYPE, "cover.jpg", NULL, NULL, $config['cops_html_thumbnail_height'] * 2)->hrefXhtml ();
+        $out ["coverurl"] = Data::getLink ($book, "jpg", "image/jpeg", Link::OPDS_IMAGE_TYPE, "cover.jpg", null)->hrefXhtml ();
+        $out ["thumbnailurl"] = Data::getLink ($book, "jpg", "image/jpeg", Link::OPDS_THUMBNAIL_TYPE, "cover.jpg", null, null, $config['cops_html_thumbnail_height'] * 2)->hrefXhtml ();
         $out ["content"] = $book->getComment (false);
         $out ["datas"] = array ();
         $dataKindle = $book->GetMostInterestingDataToSendToKindle ();

Please login to merge, or discard this patch.

		@@ -231,7 +231,7 @@ discard block
		block discarded – undo
231	231	* "address.from" => "[email protected]"
232	232	* );
233	233	*/
234		- $config['cops_mail_configuration'] = NULL;
	234	+ $config['cops_mail_configuration'] = null;
235	235
236	236	/*
237	237	* Use filter in HTML catalog
		@@ -303,7 +303,7 @@ discard block
		block discarded – undo
303	303	* array( "username" => "xxx", "password" => "secret") : Enable PHP password protection
304	304	* NULL : Disable PHP password protection (You can still use htpasswd)
305	305	*/
306		- $config['cops_basic_authentication'] = NULL;
	306	+ $config['cops_basic_authentication'] = null;
307	307
308	308	/*
309	309	* Which template is used by default :

		@@ -41,13 +41,13 @@ discard block
		block discarded – undo
41	41
42	42	protected function getAllCustomValuesFromDatabase()
43	43	{
44		- return NULL;
	44	+ return null;
45	45	}
46	46
47	47	public function getDescription()
48	48	{
49	49	$desc = $this->getDatabaseDescription();
50		- if ($desc === NULL \|\| empty($desc)) $desc = str_format(localize("customcolumn.description"), $this->getTitle());
	50	+ if ($desc === null \|\| empty($desc)) $desc = str_format(localize("customcolumn.description"), $this->getTitle());
51	51	return $desc;
52	52	}
53	53
		@@ -60,7 +60,7 @@ discard block
		block discarded – undo
60	60	if ($post = $result->fetchObject()) {
61	61	return new CustomColumn($post->id, $post->value, $this);
62	62	}
63		- return new CustomColumn(NULL, localize("customcolumn.float.unknown"), $this);
	63	+ return new CustomColumn(null, localize("customcolumn.float.unknown"), $this);
64	64	}
65	65
66	66	public function isSearchable()

		@@ -76,8 +76,8 @@
		block discarded – undo
76	76	$out = self::getBookContentArray ($book);
77	77	$database = GetUrlParam (DB);
78	78
79		- $out ["coverurl"] = Data::getLink ($book, "jpg", "image/jpeg", Link::OPDS_IMAGE_TYPE, "cover.jpg", NULL)->hrefXhtml ();
80		- $out ["thumbnailurl"] = Data::getLink ($book, "jpg", "image/jpeg", Link::OPDS_THUMBNAIL_TYPE, "cover.jpg", NULL, NULL, $config['cops_html_thumbnail_height'] * 2)->hrefXhtml ();
	79	+ $out ["coverurl"] = Data::getLink ($book, "jpg", "image/jpeg", Link::OPDS_IMAGE_TYPE, "cover.jpg", null)->hrefXhtml ();
	80	+ $out ["thumbnailurl"] = Data::getLink ($book, "jpg", "image/jpeg", Link::OPDS_THUMBNAIL_TYPE, "cover.jpg", null, null, $config['cops_html_thumbnail_height'] * 2)->hrefXhtml ();
81	81	$out ["content"] = $book->getComment (false);
82	82	$out ["datas"] = array ();
83	83	$dataKindle = $book->GetMostInterestingDataToSendToKindle ();

		@@ -23,9 +23,9 @@
		block discarded – undo
23	23	header('Pragma: public');
24	24	header('Cache-Control: maxage=' . $expires);
25	25	header('Expires: ' . gmdate('D, d M Y H:i:s', time()+$expires) . ' GMT');
26		- $bookId = getURLParam('id', NULL);
	26	+ $bookId = getURLParam('id', null);
27	27	$type = getURLParam('type', 'jpg');
28		- $idData = getURLParam('data', NULL);
	28	+ $idData = getURLParam('data', null);
29	29	if (is_null($bookId)) {
30	30	$book = Book::getBookByDataId($idData);
31	31	} else {

		@@ -50,7 +50,7 @@
		block discarded – undo
50	50	}
51	51	$headcontent = file_get_contents('templates/' . getCurrentTemplate() . '/file.html');
52	52	$template = new doT();
53		- $dot = $template->template($headcontent, NULL);
	53	+ $dot = $template->template($headcontent, null);
54	54	echo($dot($data));
55	55	?><body>
56	56	<?php

		@@ -25,7 +25,7 @@ discard block
		block discarded – undo
25	25	* @return
26	26	* Transliterated text.
27	27	*/
28		-function _transliteration_process($string, $unknown = '?', $source_langcode = NULL) {
	28	+function _transliteration_process($string, $unknown = '?', $source_langcode = null) {
29	29	// ASCII is always valid NFC! If we're only ever given plain ASCII, we can
30	30	// avoid the overhead of initializing the decomposition tables by skipping
31	31	// out early.
		@@ -174,7 +174,7 @@ discard block
		block discarded – undo
174	174	* @return
175	175	* ASCII replacement character.
176	176	*/
177		-function _transliteration_replace($ord, $unknown = '?', $langcode = NULL) {
	177	+function _transliteration_replace($ord, $unknown = '?', $langcode = null) {
178	178	static $map = array();
179	179
180	180	//GL: set language later

		@@ -55,7 +55,7 @@ discard block
		block discarded – undo
55	55	public function getDescription()
56	56	{
57	57	$desc = $this->getDatabaseDescription();
58		- if ($desc === NULL \|\| empty($desc)) $desc = str_format(localize("customcolumn.description"), $this->getTitle());
	58	+ if ($desc === null \|\| empty($desc)) $desc = str_format(localize("customcolumn.description"), $this->getTitle());
59	59	return $desc;
60	60	}
61	61
		@@ -68,7 +68,7 @@ discard block
		block discarded – undo
68	68	if ($post = $result->fetchObject()) {
69	69	return new CustomColumn($post->value, $post->value, $this);
70	70	}
71		- return new CustomColumn(NULL, localize("customcolumn.int.unknown"), $this);
	71	+ return new CustomColumn(null, localize("customcolumn.int.unknown"), $this);
72	72	}
73	73
74	74	public function isSearchable()

		@@ -37,14 +37,14 @@ discard block
		block discarded – undo
37	37	/** @var string the datatype of this column (one of the CUSTOM_TYPE_* constant values) */
38	38	public $datatype;
39	39	/** @var null\|Entry[] */
40		- private $customValues = NULL;
	40	+ private $customValues = null;
41	41
42	42	protected function __construct($pcustomId, $pdatatype)
43	43	{
44	44	$this->columnTitle = self::getTitleByCustomID($pcustomId);
45	45	$this->customId = $pcustomId;
46	46	$this->datatype = $pdatatype;
47		- $this->customValues = NULL;
	47	+ $this->customValues = null;
48	48	}
49	49
50	50	/**
		@@ -110,9 +110,9 @@ discard block
		block discarded – undo
110	110	$result->execute(array($this->customId));
111	111	if ($post = $result->fetchObject()) {
112	112	$json = json_decode($post->display);
113		- return (isset($json->description) && !empty($json->description)) ? $json->description : NULL;
	113	+ return (isset($json->description) && !empty($json->description)) ? $json->description : null;
114	114	}
115		- return NULL;
	115	+ return null;
116	116	}
117	117
118	118	/**
		@@ -168,7 +168,7 @@ discard block
		block discarded – undo
168	168	if ($post = $result->fetchObject()) {
169	169	return $post->datatype;
170	170	}
171		- return NULL;
	171	+ return null;
172	172	}
173	173
174	174	/**
		@@ -206,7 +206,7 @@ discard block
		block discarded – undo
206	206	case self::CUSTOM_TYPE_BOOL:
207	207	return self::$customColumnCacheID[$customId] = new CustomColumnTypeBool($customId);
208	208	case self::CUSTOM_TYPE_COMPOSITE:
209		- return NULL; //TODO Currently not supported
	209	+ return null; //TODO Currently not supported
210	210	default:
211	211	throw new Exception("Unkown column type: " . $datatype);
212	212	}
		@@ -229,7 +229,7 @@ discard block
		block discarded – undo
229	229	if ($post = $result->fetchObject()) {
230	230	return self::$customColumnCacheLookup[$lookup] = self::createByCustomID($post->id);
231	231	}
232		- return self::$customColumnCacheLookup[$lookup] = NULL;
	232	+ return self::$customColumnCacheLookup[$lookup] = null;
233	233	}
234	234
235	235	/**
		@@ -241,7 +241,7 @@ discard block
		block discarded – undo
241	241	public function getAllCustomValues()
242	242	{
243	243	// lazy loading
244		- if ($this->customValues == NULL)
	244	+ if ($this->customValues == null)
245	245	$this->customValues = $this->getAllCustomValuesFromDatabase();
246	246
247	247	return $this->customValues;

		@@ -45,7 +45,7 @@
		block discarded – undo
45	45	if ($post = $result->fetchObject ()) {
46	46	return new Language ($post->id, Language::getLanguageString ($post->lang_code));
47	47	}
48		- return NULL;
	48	+ return null;
49	49	}
50	50
51	51

seblucas / cops

Push — master ( 6fb385...fab96a )

Status

Category

Upper-Lower-Casing +2 added lines, -2 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +2 added lines, -2 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +2 added lines, -2 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +2 added lines, -2 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +8 added lines, -8 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +3 added lines, -3 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +2 added lines, -2 removed lines patch added patch discarded remove patch