TrelloItemNotFoundException::getNotFoundMessage() - Code Metrics - Inspection of "[WIP] Throw exception when Trello item are not fou..." - seblegall/php-trello-burndown - Measure and Improve Code Quality continuously with Scrutinizer

Cancelled

Pull Request — master (#1)

by Sébastien

created 2016-06-03 14:39 UTC

TrelloItemNotFoundException::getNotFoundMessage() A

↳ Parent: TrelloItemNotFoundException

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	8
ccs	4
cts	4
cp	1
rs	9.4285
cc	2
eloc	4
nc	2
nop	2
crap	2

<?php

namespace TrelloBurndown\Exception;

/**
 * Class TrelloItemNotFoundException.
 */
class TrelloItemNotFoundException extends \Exception
{
    /**
     * @var array
     */
    private static $itemTypes = [
        'board',
        'list',
        'card',
    ];

    /**
     * @var string
     */
    private $itemType;

    /**
     * @var string
     */
    private $itemName;

    /**
     * TrelloItemNotFoundException constructor.
     *
     * @param string          $itemType
     * @param string          $itemName
     * @param int             $code
     * @param \Exception|null $previous
     */
    public function __construct(String $itemType, String $itemName, $code = 0, \Exception $previous = null)
    {
        $this->itemName = $itemName;
        $this->itemType = $itemType;

        try {
            $message = self::getNotFoundMessage($itemType, $itemName);
            parent::__construct($message, 404, $previous);
        } catch (\Exception $e) {
            parent::__construct($e->getMessage());
        }
    }

    /**
     * @param $itemType
     * @param $itemName
     *
     * @return string
     *
     * @throws \Exception
     */
    private static function getNotFoundMessage($itemType, $itemName)
    {
        if (in_array($itemType, self::$itemTypes)) {
            return 'The trello '.$itemType.' named '.$itemName.' could not be found.';
        }

        throw new \Exception('The declare Trello item type does not match any known type.');
    }

    /**
     * @return string
     */
    public function getItemName()
    {
        return $this->itemName;
    }

    /**
     * @return string
     */
    public function getItemType()
    {
        return $this->itemType;
    }
}


1		<?php
2
3		namespace TrelloBurndown\Exception;
4
5		/**
6		* Class TrelloItemNotFoundException.
7		*/
8		class TrelloItemNotFoundException extends \Exception
9		{
10		/**
11		* @var array
12		*/
13		private static $itemTypes = [
14		'board',
15		'list',
16		'card',
17		];
18
19		/**
20		* @var string
21		*/
22		private $itemType;
23
24		/**
25		* @var string
26		*/
27		private $itemName;
28
29		/**
30		* TrelloItemNotFoundException constructor.
31		*
32		* @param string $itemType
33		* @param string $itemName
34		* @param int $code
35		* @param \Exception\|null $previous
36		*/
37	7	public function __construct(String $itemType, String $itemName, $code = 0, \Exception $previous = null)
38		{
39	7	$this->itemName = $itemName;
40	7	$this->itemType = $itemType;
41
42		try {
43	7	$message = self::getNotFoundMessage($itemType, $itemName);
44	6	parent::__construct($message, 404, $previous);
45	1	} catch (\Exception $e) {
46	1	parent::__construct($e->getMessage());
47		}
48	7	}
49
50		/**
51		* @param $itemType
52		* @param $itemName
53		*
54		* @return string
55		*
56		* @throws \Exception
57		*/
58	7	private static function getNotFoundMessage($itemType, $itemName)
59		{
60	7	if (in_array($itemType, self::$itemTypes)) {
61	6	return 'The trello '.$itemType.' named '.$itemName.' could not be found.';
62		}
63
64	1	throw new \Exception('The declare Trello item type does not match any known type.');
65		}
66
67		/**
68		* @return string
69		*/
70	4	public function getItemName()
71		{
72	4	return $this->itemName;
73		}
74
75		/**
76		* @return string
77		*/
78	4	public function getItemType()
79		{
80	4	return $this->itemType;
81		}
82		}
83

seblegall / php-trello-burndown

Pull Request — master (#1)

TrelloItemNotFoundException::getNotFoundMessage() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like