Inspection of "Add validation tests" - sebastianfeldmann/phpbu - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f86624...031313 )

by Sebastian

created 2019-04-01 10:12 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -222,7 +222,7 @@
 block discarded – undo
             throw new Exception('backup requires a target config');
         }
         $compress = Arr::getValue($json['target'], 'compress');
-        $filename = $this->getAdapterizedValue(Arr::getValue($json['target'], 'filename',''));
+        $filename = $this->getAdapterizedValue(Arr::getValue($json['target'], 'filename', ''));
         $dirname  = $this->getAdapterizedValue(Arr::getValue($json['target'], 'dirname', ''));
 
         if ($dirname) {

Please login to merge, or discard this patch.

src/Log/Mail.php 2 patches

Indentation +56 added lines, -56 removed lines patch added patch discarded remove patch

@@ -191,12 +191,12 @@  discard block
 block discarded – undo
             $info    = $this->getInfoHtml($result);
             $footer  = $this->getFooterHtml();
             $body    = '<html><body ' . TPL::getSnippet('sBody') . '>'
-                     . $header
-                     . $status
-                     . $errors
-                     . $info
-                     . $footer
-                     . '</body></html>';
+                        . $header
+                        . $status
+                        . $errors
+                        . $info
+                        . $footer
+                        . '</body></html>';
             $state   = $result->allOk() ? 'OK' : ($result->backupOkButSkipsOrFails() ? 'WARNING' : 'ERROR');
 
             $this->mailer->Subject = $this->subject . ' [' . $state . ']';
@@ -359,7 +359,7 @@  discard block
 block discarded – undo
     protected function getHeaderHtml()
     {
         return '<table ' . TPL::getSnippet('sTableContent') . '><tr><td ' . TPL::getSnippet('sTableContentCol') . '>' .
-               '<table ' . TPL::getSnippet('sTableHeader') . '><tr><td>PHPBU - backup report</td></tr></table>';
+                '<table ' . TPL::getSnippet('sTableHeader') . '><tr><td>PHPBU - backup report</td></tr></table>';
     }
 
     /**
@@ -398,11 +398,11 @@  discard block
 block discarded – undo
             Str::appendPluralS('cleanup', $this->numCleanups)
         );
         $html = '<table ' . sprintf(TPL::getSnippet('sTableStatus'), $color) . '>' .
-                 '<tr><td>' .
-                  '<span ' . TPL::getSnippet('sTableStatusText') . '>' . date('Y-m-d H:i') . '</span>' .
-                  '<h1 ' . TPL::getSnippet('sTableStatusHead') . '>' . $status . '</h1>' .
-                  '<span ' . TPL::getSnippet('sTableStatusText') . '>' . $info . '</span>' .
-                 '</td></tr>' .
+                    '<tr><td>' .
+                    '<span ' . TPL::getSnippet('sTableStatusText') . '>' . date('Y-m-d H:i') . '</span>' .
+                    '<h1 ' . TPL::getSnippet('sTableStatusHead') . '>' . $status . '</h1>' .
+                    '<span ' . TPL::getSnippet('sTableStatusText') . '>' . $info . '</span>' .
+                    '</td></tr>' .
                 '</table>';
 
         return $html;
@@ -465,65 +465,65 @@  discard block
 block discarded – undo
                     $status = 'FAILURE';
                 }
                 $html .= '<tr>' .
-                          '<td ' . sprintf(TPL::getSnippet('sTableBackupStatusColumn'), $color) . ' colspan="4">' .
-                          sprintf('backup <em>%s</em>', $backup->getName()) .
-                          ' <span ' . TPL::getSnippet('sTableBackupStatusText') . '>' . $status . '</span>' .
-                          '</td>' .
-                         '</tr>' .
-                         '<tr>' .
-                          '<td ' . TPL::getSnippet('sRowHead') . '>&nbsp;</td>' .
-                          '<td ' . TPL::getSnippet('sRowHead') . ' align="right">executed</td>' .
-                          '<td ' . TPL::getSnippet('sRowHead') . ' align="right">skipped</td>' .
-                          '<td ' . TPL::getSnippet('sRowHead') . ' align="right">failed</td>' .
-                         '</tr>';
+                            '<td ' . sprintf(TPL::getSnippet('sTableBackupStatusColumn'), $color) . ' colspan="4">' .
+                            sprintf('backup <em>%s</em>', $backup->getName()) .
+                            ' <span ' . TPL::getSnippet('sTableBackupStatusText') . '>' . $status . '</span>' .
+                            '</td>' .
+                            '</tr>' .
+                            '<tr>' .
+                            '<td ' . TPL::getSnippet('sRowHead') . '>&nbsp;</td>' .
+                            '<td ' . TPL::getSnippet('sRowHead') . ' align="right">executed</td>' .
+                            '<td ' . TPL::getSnippet('sRowHead') . ' align="right">skipped</td>' .
+                            '<td ' . TPL::getSnippet('sRowHead') . ' align="right">failed</td>' .
+                            '</tr>';
 
                 $html .= '<tr>' .
-                          '<td ' . TPL::getSnippet('sRowCheck') . '>checks</td>' .
-                          '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">' .
+                            '<td ' . TPL::getSnippet('sRowCheck') . '>checks</td>' .
+                            '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">' .
                             $backup->checkCount() . '
                            </td>' .
-                          '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">
+                            '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">
                             &nbsp;
                            </td>' .
-                          '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">' .
+                            '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">' .
                             $backup->checkCountFailed() .
-                          '</td>' .
-                         '</tr>' .
-                         '<tr>' .
-                          '<td ' . TPL::getSnippet('sRowCrypt') . '>crypts</td>' .
-                          '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
+                            '</td>' .
+                            '</tr>' .
+                            '<tr>' .
+                            '<td ' . TPL::getSnippet('sRowCrypt') . '>crypts</td>' .
+                            '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
                             $backup->cryptCount() .
-                          '</td>' .
-                          '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
+                            '</td>' .
+                            '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
                             $backup->cryptCountSkipped() .
-                          '</td>' .
-                          '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
+                            '</td>' .
+                            '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
                             $backup->cryptCountFailed() .
-                          '</td>' .
-                         '</tr>' .
-                         '<tr>' .
-                          '<td ' . TPL::getSnippet('sRowSync') . '>syncs</td>' .
-                          '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
+                            '</td>' .
+                            '</tr>' .
+                            '<tr>' .
+                            '<td ' . TPL::getSnippet('sRowSync') . '>syncs</td>' .
+                            '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
                             $backup->syncCount() . '</td>' .
-                          '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
+                            '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
                             $backup->syncCountSkipped() .
-                          '</td>' .
-                          '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
+                            '</td>' .
+                            '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
                             $backup->syncCountFailed() .
-                          '</td>' .
-                         '</tr>' .
-                         '<tr>' .
-                          '<td ' . TPL::getSnippet('sRowCleanup') . '>cleanups</td>' .
-                          '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
+                            '</td>' .
+                            '</tr>' .
+                            '<tr>' .
+                            '<td ' . TPL::getSnippet('sRowCleanup') . '>cleanups</td>' .
+                            '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
                             $backup->cleanupCount() .
-                          '</td>' .
-                          '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
+                            '</td>' .
+                            '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
                             $backup->cleanupCountSkipped() .
-                          '</td>' .
-                          '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
+                            '</td>' .
+                            '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
                             $backup->cleanupCountFailed() .
-                          '</td>' .
-                         '</tr>';
+                            '</td>' .
+                            '</tr>';
 
             }
             $html .= '</table>';
@@ -540,6 +540,6 @@  discard block
 block discarded – undo
     protected function getFooterHtml()
     {
         return '<p ' . TPL::getSnippet('sStats') . '>' . Statistics::resourceUsage() . '</p>' .
-               '</td></tr></table>';
+                '</td></tr></table>';
     }
 }

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -197,7 +197,7 @@  discard block
 block discarded – undo
                      . $info
                      . $footer
                      . '</body></html>';
-            $state   = $result->allOk() ? 'OK' : ($result->backupOkButSkipsOrFails() ? 'WARNING' : 'ERROR');
+            $state = $result->allOk() ? 'OK' : ($result->backupOkButSkipsOrFails() ? 'WARNING' : 'ERROR');
 
             $this->mailer->Subject = $this->subject . ' [' . $state . ']';
             $this->mailer->setFrom($this->senderMail, $this->senderName);
@@ -361,7 +361,7 @@  discard block
 block discarded – undo
             if (!$this->mailer->send()) {
                 throw new Exception($this->mailer->ErrorInfo);
             }
-        } catch (\Exception $e)  {
+        } catch (\Exception $e) {
             throw new Exception($e->getMessage());
         }
     }

Please login to merge, or discard this patch.

src/Configuration/Generator.php 1 patch

Upper-Lower-Casing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -34,7 +34,7 @@  discard block
 block discarded – undo
     </backups>
 </phpbu>
 
-EOT;
+eot;
 
     /**
      * @var string
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
   ]
 }
 
-EOT;
+eot;
 
     /**
      * Return the config file content

Please login to merge, or discard this patch.

src/Cmd.php 2 patches

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -194,7 +194,7 @@
 block discarded – undo
 
         if ($configLoader->hasValidationErrors()) {
             echo "  Warning - The configuration file did not pass validation!" . \PHP_EOL .
-                 "  The following problems have been detected:" . \PHP_EOL;
+                    "  The following problems have been detected:" . \PHP_EOL;
 
             foreach ($configLoader->getValidationErrors() as $line => $errors) {
                 echo \sprintf("\n  Line %d:\n", $line);

Please login to merge, or discard this patch.

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -406,7 +406,7 @@
 block discarded – undo
   -v, --verbose            Output more verbose information.
   -V, --version            Output version information and exit.
 
-EOT;
+eot;
         if ($this->isPhar) {
             echo '  --version-check        Check whether phpbu is up to date.' . PHP_EOL;
             echo '  --self-update          Upgrade phpbu to the latest version.' . PHP_EOL;

Please login to merge, or discard this patch.

		@@ -222,7 +222,7 @@
		block discarded – undo
222	222	throw new Exception('backup requires a target config');
223	223	}
224	224	$compress = Arr::getValue($json['target'], 'compress');
225		- $filename = $this->getAdapterizedValue(Arr::getValue($json['target'], 'filename',''));
	225	+ $filename = $this->getAdapterizedValue(Arr::getValue($json['target'], 'filename', ''));
226	226	$dirname = $this->getAdapterizedValue(Arr::getValue($json['target'], 'dirname', ''));
227	227
228	228	if ($dirname) {

		@@ -191,12 +191,12 @@ discard block
		block discarded – undo
191	191	$info = $this->getInfoHtml($result);
192	192	$footer = $this->getFooterHtml();
193	193	$body = '<html><body ' . TPL::getSnippet('sBody') . '>'
194		- . $header
195		- . $status
196		- . $errors
197		- . $info
198		- . $footer
199		- . '</body></html>';
	194	+ . $header
	195	+ . $status
	196	+ . $errors
	197	+ . $info
	198	+ . $footer
	199	+ . '</body></html>';
200	200	$state = $result->allOk() ? 'OK' : ($result->backupOkButSkipsOrFails() ? 'WARNING' : 'ERROR');
201	201
202	202	$this->mailer->Subject = $this->subject . ' [' . $state . ']';
		@@ -359,7 +359,7 @@ discard block
		block discarded – undo
359	359	protected function getHeaderHtml()
360	360	{
361	361	return '<table ' . TPL::getSnippet('sTableContent') . '><tr><td ' . TPL::getSnippet('sTableContentCol') . '>' .
362		- '<table ' . TPL::getSnippet('sTableHeader') . '><tr><td>PHPBU - backup report</td></tr></table>';
	362	+ '<table ' . TPL::getSnippet('sTableHeader') . '><tr><td>PHPBU - backup report</td></tr></table>';
363	363	}
364	364
365	365	/**
		@@ -398,11 +398,11 @@ discard block
		block discarded – undo
398	398	Str::appendPluralS('cleanup', $this->numCleanups)
399	399	);
400	400	$html = '<table ' . sprintf(TPL::getSnippet('sTableStatus'), $color) . '>' .
401		- '<tr><td>' .
402		- '<span ' . TPL::getSnippet('sTableStatusText') . '>' . date('Y-m-d H:i') . '</span>' .
403		- '<h1 ' . TPL::getSnippet('sTableStatusHead') . '>' . $status . '</h1>' .
404		- '<span ' . TPL::getSnippet('sTableStatusText') . '>' . $info . '</span>' .
405		- '</td></tr>' .
	401	+ '<tr><td>' .
	402	+ '<span ' . TPL::getSnippet('sTableStatusText') . '>' . date('Y-m-d H:i') . '</span>' .
	403	+ '<h1 ' . TPL::getSnippet('sTableStatusHead') . '>' . $status . '</h1>' .
	404	+ '<span ' . TPL::getSnippet('sTableStatusText') . '>' . $info . '</span>' .
	405	+ '</td></tr>' .
406	406	'</table>';
407	407
408	408	return $html;
		@@ -465,65 +465,65 @@ discard block
		block discarded – undo
465	465	$status = 'FAILURE';
466	466	}
467	467	$html .= '<tr>' .
468		- '<td ' . sprintf(TPL::getSnippet('sTableBackupStatusColumn'), $color) . ' colspan="4">' .
469		- sprintf('backup <em>%s</em>', $backup->getName()) .
470		- ' <span ' . TPL::getSnippet('sTableBackupStatusText') . '>' . $status . '</span>' .
471		- '</td>' .
472		- '</tr>' .
473		- '<tr>' .
474		- '<td ' . TPL::getSnippet('sRowHead') . '> </td>' .
475		- '<td ' . TPL::getSnippet('sRowHead') . ' align="right">executed</td>' .
476		- '<td ' . TPL::getSnippet('sRowHead') . ' align="right">skipped</td>' .
477		- '<td ' . TPL::getSnippet('sRowHead') . ' align="right">failed</td>' .
478		- '</tr>';
	468	+ '<td ' . sprintf(TPL::getSnippet('sTableBackupStatusColumn'), $color) . ' colspan="4">' .
	469	+ sprintf('backup <em>%s</em>', $backup->getName()) .
	470	+ ' <span ' . TPL::getSnippet('sTableBackupStatusText') . '>' . $status . '</span>' .
	471	+ '</td>' .
	472	+ '</tr>' .
	473	+ '<tr>' .
	474	+ '<td ' . TPL::getSnippet('sRowHead') . '> </td>' .
	475	+ '<td ' . TPL::getSnippet('sRowHead') . ' align="right">executed</td>' .
	476	+ '<td ' . TPL::getSnippet('sRowHead') . ' align="right">skipped</td>' .
	477	+ '<td ' . TPL::getSnippet('sRowHead') . ' align="right">failed</td>' .
	478	+ '</tr>';
479	479
480	480	$html .= '<tr>' .
481		- '<td ' . TPL::getSnippet('sRowCheck') . '>checks</td>' .
482		- '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">' .
	481	+ '<td ' . TPL::getSnippet('sRowCheck') . '>checks</td>' .
	482	+ '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">' .
483	483	$backup->checkCount() . '
484	484	</td>' .
485		- '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">
	485	+ '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">
486	486
487	487	</td>' .
488		- '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">' .
	488	+ '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">' .
489	489	$backup->checkCountFailed() .
490		- '</td>' .
491		- '</tr>' .
492		- '<tr>' .
493		- '<td ' . TPL::getSnippet('sRowCrypt') . '>crypts</td>' .
494		- '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
	490	+ '</td>' .
	491	+ '</tr>' .
	492	+ '<tr>' .
	493	+ '<td ' . TPL::getSnippet('sRowCrypt') . '>crypts</td>' .
	494	+ '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
495	495	$backup->cryptCount() .
496		- '</td>' .
497		- '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
	496	+ '</td>' .
	497	+ '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
498	498	$backup->cryptCountSkipped() .
499		- '</td>' .
500		- '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
	499	+ '</td>' .
	500	+ '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
501	501	$backup->cryptCountFailed() .
502		- '</td>' .
503		- '</tr>' .
504		- '<tr>' .
505		- '<td ' . TPL::getSnippet('sRowSync') . '>syncs</td>' .
506		- '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
	502	+ '</td>' .
	503	+ '</tr>' .
	504	+ '<tr>' .
	505	+ '<td ' . TPL::getSnippet('sRowSync') . '>syncs</td>' .
	506	+ '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
507	507	$backup->syncCount() . '</td>' .
508		- '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
	508	+ '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
509	509	$backup->syncCountSkipped() .
510		- '</td>' .
511		- '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
	510	+ '</td>' .
	511	+ '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
512	512	$backup->syncCountFailed() .
513		- '</td>' .
514		- '</tr>' .
515		- '<tr>' .
516		- '<td ' . TPL::getSnippet('sRowCleanup') . '>cleanups</td>' .
517		- '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
	513	+ '</td>' .
	514	+ '</tr>' .
	515	+ '<tr>' .
	516	+ '<td ' . TPL::getSnippet('sRowCleanup') . '>cleanups</td>' .
	517	+ '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
518	518	$backup->cleanupCount() .
519		- '</td>' .
520		- '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
	519	+ '</td>' .
	520	+ '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
521	521	$backup->cleanupCountSkipped() .
522		- '</td>' .
523		- '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
	522	+ '</td>' .
	523	+ '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
524	524	$backup->cleanupCountFailed() .
525		- '</td>' .
526		- '</tr>';
	525	+ '</td>' .
	526	+ '</tr>';
527	527
528	528	}
529	529	$html .= '</table>';
		@@ -540,6 +540,6 @@ discard block
		block discarded – undo
540	540	protected function getFooterHtml()
541	541	{
542	542	return '<p ' . TPL::getSnippet('sStats') . '>' . Statistics::resourceUsage() . '</p>' .
543		- '</td></tr></table>';
	543	+ '</td></tr></table>';
544	544	}
545	545	}

		@@ -406,7 +406,7 @@
		block discarded – undo
406	406	-v, --verbose Output more verbose information.
407	407	-V, --version Output version information and exit.
408	408
409		-EOT;
	409	+eot;
410	410	if ($this->isPhar) {
411	411	echo ' --version-check Check whether phpbu is up to date.' . PHP_EOL;
412	412	echo ' --self-update Upgrade phpbu to the latest version.' . PHP_EOL;

		@@ -197,7 +197,7 @@ discard block
		block discarded – undo
197	197	. $info
198	198	. $footer
199	199	. '</body></html>';
200		- $state = $result->allOk() ? 'OK' : ($result->backupOkButSkipsOrFails() ? 'WARNING' : 'ERROR');
	200	+ $state = $result->allOk() ? 'OK' : ($result->backupOkButSkipsOrFails() ? 'WARNING' : 'ERROR');
201	201
202	202	$this->mailer->Subject = $this->subject . ' [' . $state . ']';
203	203	$this->mailer->setFrom($this->senderMail, $this->senderName);
		@@ -361,7 +361,7 @@ discard block
		block discarded – undo
361	361	if (!$this->mailer->send()) {
362	362	throw new Exception($this->mailer->ErrorInfo);
363	363	}
364		- } catch (\Exception $e) {
	364	+ } catch (\Exception $e) {
365	365	throw new Exception($e->getMessage());
366	366	}
367	367	}

		@@ -34,7 +34,7 @@ discard block
		block discarded – undo
34	34	</backups>
35	35	</phpbu>
36	36
37		-EOT;
	37	+eot;
38	38
39	39	/**
40	40	* @var string
		@@ -64,7 +64,7 @@ discard block
		block discarded – undo
64	64	]
65	65	}
66	66
67		-EOT;
	67	+eot;
68	68
69	69	/**
70	70	* Return the config file content

		@@ -194,7 +194,7 @@
		block discarded – undo
194	194
195	195	if ($configLoader->hasValidationErrors()) {
196	196	echo " Warning - The configuration file did not pass validation!" . \PHP_EOL .
197		- " The following problems have been detected:" . \PHP_EOL;
	197	+ " The following problems have been detected:" . \PHP_EOL;
198	198
199	199	foreach ($configLoader->getValidationErrors() as $line => $errors) {
200	200	echo \sprintf("\n Line %d:\n", $line);

sebastianfeldmann / phpbu

Push — master ( f86624...031313 )

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +56 added lines, -56 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

Upper-Lower-Casing +1 added lines, -1 removed lines patch added patch discarded remove patch