Inspection of "Adds Early Exits" - sebastianfeldmann/phpbu - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#238)

unknown

created 2020-04-12 14:12 UTC

Status

Indentation +56 added lines, -56 removed lines patch added patch discarded remove patch

@@ -195,12 +195,12 @@  discard block
 block discarded – undo
         $info    = $this->getInfoHtml($result);
         $footer  = $this->getFooterHtml();
         $body    = '<html><body ' . TPL::getSnippet('sBody') . '>'
-                 . $header
-                 . $status
-                 . $errors
-                 . $info
-                 . $footer
-                 . '</body></html>';
+                    . $header
+                    . $status
+                    . $errors
+                    . $info
+                    . $footer
+                    . '</body></html>';
         $state   = $result->allOk() ? 'OK' : ($result->backupOkButSkipsOrFails() ? 'WARNING' : 'ERROR');
 
         $this->mailer->Subject = $this->subject . ' [' . ($this->isSimulation ? 'SIMULATION' : $state) . ']';
@@ -378,7 +378,7 @@  discard block
 block discarded – undo
     protected function getHeaderHtml()
     {
         return '<table ' . TPL::getSnippet('sTableContent') . '><tr><td ' . TPL::getSnippet('sTableContentCol') . '>' .
-               '<table ' . TPL::getSnippet('sTableHeader') . '><tr><td>PHPBU - backup report</td></tr></table>';
+                '<table ' . TPL::getSnippet('sTableHeader') . '><tr><td>PHPBU - backup report</td></tr></table>';
     }
 
     /**
@@ -417,11 +417,11 @@  discard block
 block discarded – undo
             Str::appendPluralS('cleanup', $this->numCleanups)
         );
         $html = '<table ' . sprintf(TPL::getSnippet('sTableStatus'), $color) . '>' .
-                 '<tr><td>' .
-                  '<span ' . TPL::getSnippet('sTableStatusText') . '>' . date('Y-m-d H:i') . '</span>' .
-                  '<h1 ' . TPL::getSnippet('sTableStatusHead') . '>' . $status . '</h1>' .
-                  '<span ' . TPL::getSnippet('sTableStatusText') . '>' . $info . '</span>' .
-                 '</td></tr>' .
+                    '<tr><td>' .
+                    '<span ' . TPL::getSnippet('sTableStatusText') . '>' . date('Y-m-d H:i') . '</span>' .
+                    '<h1 ' . TPL::getSnippet('sTableStatusHead') . '>' . $status . '</h1>' .
+                    '<span ' . TPL::getSnippet('sTableStatusText') . '>' . $info . '</span>' .
+                    '</td></tr>' .
                 '</table>';
 
         return $html;
@@ -491,65 +491,65 @@  discard block
 block discarded – undo
                 $status = 'FAILURE';
             }
             $html .= '<tr>' .
-                      '<td ' . sprintf(TPL::getSnippet('sTableBackupStatusColumn'), $color) . ' colspan="4">' .
-                      sprintf('backup <em>%s</em>', $backup->getName()) .
-                      ' <span ' . TPL::getSnippet('sTableBackupStatusText') . '>' . $status . '</span>' .
-                      '</td>' .
-                     '</tr>' .
-                     '<tr>' .
-                      '<td ' . TPL::getSnippet('sRowHead') . '>&nbsp;</td>' .
-                      '<td ' . TPL::getSnippet('sRowHead') . ' align="right">executed</td>' .
-                      '<td ' . TPL::getSnippet('sRowHead') . ' align="right">skipped</td>' .
-                      '<td ' . TPL::getSnippet('sRowHead') . ' align="right">failed</td>' .
-                     '</tr>';
+                        '<td ' . sprintf(TPL::getSnippet('sTableBackupStatusColumn'), $color) . ' colspan="4">' .
+                        sprintf('backup <em>%s</em>', $backup->getName()) .
+                        ' <span ' . TPL::getSnippet('sTableBackupStatusText') . '>' . $status . '</span>' .
+                        '</td>' .
+                        '</tr>' .
+                        '<tr>' .
+                        '<td ' . TPL::getSnippet('sRowHead') . '>&nbsp;</td>' .
+                        '<td ' . TPL::getSnippet('sRowHead') . ' align="right">executed</td>' .
+                        '<td ' . TPL::getSnippet('sRowHead') . ' align="right">skipped</td>' .
+                        '<td ' . TPL::getSnippet('sRowHead') . ' align="right">failed</td>' .
+                        '</tr>';
 
             $html .= '<tr>' .
-                      '<td ' . TPL::getSnippet('sRowCheck') . '>checks</td>' .
-                      '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">' .
+                        '<td ' . TPL::getSnippet('sRowCheck') . '>checks</td>' .
+                        '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">' .
                         $backup->checkCount() . '
                        </td>' .
-                      '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">
+                        '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">
                         &nbsp;
                        </td>' .
-                      '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">' .
+                        '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">' .
                         $backup->checkCountFailed() .
-                      '</td>' .
-                     '</tr>' .
-                     '<tr>' .
-                      '<td ' . TPL::getSnippet('sRowCrypt') . '>crypts</td>' .
-                      '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
+                        '</td>' .
+                        '</tr>' .
+                        '<tr>' .
+                        '<td ' . TPL::getSnippet('sRowCrypt') . '>crypts</td>' .
+                        '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
                         $backup->cryptCount() .
-                      '</td>' .
-                      '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
+                        '</td>' .
+                        '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
                         $backup->cryptCountSkipped() .
-                      '</td>' .
-                      '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
+                        '</td>' .
+                        '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
                         $backup->cryptCountFailed() .
-                      '</td>' .
-                     '</tr>' .
-                     '<tr>' .
-                      '<td ' . TPL::getSnippet('sRowSync') . '>syncs</td>' .
-                      '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
+                        '</td>' .
+                        '</tr>' .
+                        '<tr>' .
+                        '<td ' . TPL::getSnippet('sRowSync') . '>syncs</td>' .
+                        '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
                         $backup->syncCount() . '</td>' .
-                      '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
+                        '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
                         $backup->syncCountSkipped() .
-                      '</td>' .
-                      '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
+                        '</td>' .
+                        '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
                         $backup->syncCountFailed() .
-                      '</td>' .
-                     '</tr>' .
-                     '<tr>' .
-                      '<td ' . TPL::getSnippet('sRowCleanup') . '>cleanups</td>' .
-                      '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
+                        '</td>' .
+                        '</tr>' .
+                        '<tr>' .
+                        '<td ' . TPL::getSnippet('sRowCleanup') . '>cleanups</td>' .
+                        '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
                         $backup->cleanupCount() .
-                      '</td>' .
-                      '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
+                        '</td>' .
+                        '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
                         $backup->cleanupCountSkipped() .
-                      '</td>' .
-                      '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
+                        '</td>' .
+                        '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
                         $backup->cleanupCountFailed() .
-                      '</td>' .
-                     '</tr>';
+                        '</td>' .
+                        '</tr>';
         }
         $html .= '</table>';
 
@@ -565,6 +565,6 @@  discard block
 block discarded – undo
     protected function getFooterHtml()
     {
         return '<p ' . TPL::getSnippet('sStats') . '>' . Statistics::resourceUsage() . '</p>' .
-               '</td></tr></table>';
+                '</td></tr></table>';
     }
 }

Please login to merge, or discard this patch.

		@@ -195,12 +195,12 @@ discard block
		block discarded – undo
195	195	$info = $this->getInfoHtml($result);
196	196	$footer = $this->getFooterHtml();
197	197	$body = '<html><body ' . TPL::getSnippet('sBody') . '>'
198		- . $header
199		- . $status
200		- . $errors
201		- . $info
202		- . $footer
203		- . '</body></html>';
	198	+ . $header
	199	+ . $status
	200	+ . $errors
	201	+ . $info
	202	+ . $footer
	203	+ . '</body></html>';
204	204	$state = $result->allOk() ? 'OK' : ($result->backupOkButSkipsOrFails() ? 'WARNING' : 'ERROR');
205	205
206	206	$this->mailer->Subject = $this->subject . ' [' . ($this->isSimulation ? 'SIMULATION' : $state) . ']';
		@@ -378,7 +378,7 @@ discard block
		block discarded – undo
378	378	protected function getHeaderHtml()
379	379	{
380	380	return '<table ' . TPL::getSnippet('sTableContent') . '><tr><td ' . TPL::getSnippet('sTableContentCol') . '>' .
381		- '<table ' . TPL::getSnippet('sTableHeader') . '><tr><td>PHPBU - backup report</td></tr></table>';
	381	+ '<table ' . TPL::getSnippet('sTableHeader') . '><tr><td>PHPBU - backup report</td></tr></table>';
382	382	}
383	383
384	384	/**
		@@ -417,11 +417,11 @@ discard block
		block discarded – undo
417	417	Str::appendPluralS('cleanup', $this->numCleanups)
418	418	);
419	419	$html = '<table ' . sprintf(TPL::getSnippet('sTableStatus'), $color) . '>' .
420		- '<tr><td>' .
421		- '<span ' . TPL::getSnippet('sTableStatusText') . '>' . date('Y-m-d H:i') . '</span>' .
422		- '<h1 ' . TPL::getSnippet('sTableStatusHead') . '>' . $status . '</h1>' .
423		- '<span ' . TPL::getSnippet('sTableStatusText') . '>' . $info . '</span>' .
424		- '</td></tr>' .
	420	+ '<tr><td>' .
	421	+ '<span ' . TPL::getSnippet('sTableStatusText') . '>' . date('Y-m-d H:i') . '</span>' .
	422	+ '<h1 ' . TPL::getSnippet('sTableStatusHead') . '>' . $status . '</h1>' .
	423	+ '<span ' . TPL::getSnippet('sTableStatusText') . '>' . $info . '</span>' .
	424	+ '</td></tr>' .
425	425	'</table>';
426	426
427	427	return $html;
		@@ -491,65 +491,65 @@ discard block
		block discarded – undo
491	491	$status = 'FAILURE';
492	492	}
493	493	$html .= '<tr>' .
494		- '<td ' . sprintf(TPL::getSnippet('sTableBackupStatusColumn'), $color) . ' colspan="4">' .
495		- sprintf('backup <em>%s</em>', $backup->getName()) .
496		- ' <span ' . TPL::getSnippet('sTableBackupStatusText') . '>' . $status . '</span>' .
497		- '</td>' .
498		- '</tr>' .
499		- '<tr>' .
500		- '<td ' . TPL::getSnippet('sRowHead') . '> </td>' .
501		- '<td ' . TPL::getSnippet('sRowHead') . ' align="right">executed</td>' .
502		- '<td ' . TPL::getSnippet('sRowHead') . ' align="right">skipped</td>' .
503		- '<td ' . TPL::getSnippet('sRowHead') . ' align="right">failed</td>' .
504		- '</tr>';
	494	+ '<td ' . sprintf(TPL::getSnippet('sTableBackupStatusColumn'), $color) . ' colspan="4">' .
	495	+ sprintf('backup <em>%s</em>', $backup->getName()) .
	496	+ ' <span ' . TPL::getSnippet('sTableBackupStatusText') . '>' . $status . '</span>' .
	497	+ '</td>' .
	498	+ '</tr>' .
	499	+ '<tr>' .
	500	+ '<td ' . TPL::getSnippet('sRowHead') . '> </td>' .
	501	+ '<td ' . TPL::getSnippet('sRowHead') . ' align="right">executed</td>' .
	502	+ '<td ' . TPL::getSnippet('sRowHead') . ' align="right">skipped</td>' .
	503	+ '<td ' . TPL::getSnippet('sRowHead') . ' align="right">failed</td>' .
	504	+ '</tr>';
505	505
506	506	$html .= '<tr>' .
507		- '<td ' . TPL::getSnippet('sRowCheck') . '>checks</td>' .
508		- '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">' .
	507	+ '<td ' . TPL::getSnippet('sRowCheck') . '>checks</td>' .
	508	+ '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">' .
509	509	$backup->checkCount() . '
510	510	</td>' .
511		- '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">
	511	+ '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">
512	512
513	513	</td>' .
514		- '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">' .
	514	+ '<td ' . TPL::getSnippet('sRowCheck') . ' align="right">' .
515	515	$backup->checkCountFailed() .
516		- '</td>' .
517		- '</tr>' .
518		- '<tr>' .
519		- '<td ' . TPL::getSnippet('sRowCrypt') . '>crypts</td>' .
520		- '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
	516	+ '</td>' .
	517	+ '</tr>' .
	518	+ '<tr>' .
	519	+ '<td ' . TPL::getSnippet('sRowCrypt') . '>crypts</td>' .
	520	+ '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
521	521	$backup->cryptCount() .
522		- '</td>' .
523		- '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
	522	+ '</td>' .
	523	+ '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
524	524	$backup->cryptCountSkipped() .
525		- '</td>' .
526		- '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
	525	+ '</td>' .
	526	+ '<td ' . TPL::getSnippet('sRowCrypt') . ' align="right">' .
527	527	$backup->cryptCountFailed() .
528		- '</td>' .
529		- '</tr>' .
530		- '<tr>' .
531		- '<td ' . TPL::getSnippet('sRowSync') . '>syncs</td>' .
532		- '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
	528	+ '</td>' .
	529	+ '</tr>' .
	530	+ '<tr>' .
	531	+ '<td ' . TPL::getSnippet('sRowSync') . '>syncs</td>' .
	532	+ '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
533	533	$backup->syncCount() . '</td>' .
534		- '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
	534	+ '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
535	535	$backup->syncCountSkipped() .
536		- '</td>' .
537		- '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
	536	+ '</td>' .
	537	+ '<td ' . TPL::getSnippet('sRowSync') . ' align="right">' .
538	538	$backup->syncCountFailed() .
539		- '</td>' .
540		- '</tr>' .
541		- '<tr>' .
542		- '<td ' . TPL::getSnippet('sRowCleanup') . '>cleanups</td>' .
543		- '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
	539	+ '</td>' .
	540	+ '</tr>' .
	541	+ '<tr>' .
	542	+ '<td ' . TPL::getSnippet('sRowCleanup') . '>cleanups</td>' .
	543	+ '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
544	544	$backup->cleanupCount() .
545		- '</td>' .
546		- '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
	545	+ '</td>' .
	546	+ '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
547	547	$backup->cleanupCountSkipped() .
548		- '</td>' .
549		- '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
	548	+ '</td>' .
	549	+ '<td ' . TPL::getSnippet('sRowCleanup') . ' align="right">' .
550	550	$backup->cleanupCountFailed() .
551		- '</td>' .
552		- '</tr>';
	551	+ '</td>' .
	552	+ '</tr>';
553	553	}
554	554	$html .= '</table>';
555	555
		@@ -565,6 +565,6 @@ discard block
		block discarded – undo
565	565	protected function getFooterHtml()
566	566	{
567	567	return '<p ' . TPL::getSnippet('sStats') . '>' . Statistics::resourceUsage() . '</p>' .
568		- '</td></tr></table>';
	568	+ '</td></tr></table>';
569	569	}
570	570	}

sebastianfeldmann / phpbu

Pull Request — master (#238)

Status

Category

Indentation +56 added lines, -56 removed lines patch added patch discarded remove patch