phpbu\App\Backup\Source\Redis

Complexity

Total Complexity

13

Size/Duplication

Total Lines	187
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	10

Importance

Changes	1
Bugs	0	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	setup()	0	14	2
A	backup()	0	22	2
A	getExecutable()	0	12	2
A	getLastBackupTime()	0	10	2
A	isDumpCreatedYet()	0	12	3
A	copyDumpToTargetDir()	0	9	2

<?php
namespace phpbu\App\Backup\Source;

use phpbu\App\Backup\Cli;
use phpbu\App\Backup\Source;
use phpbu\App\Backup\Target;
use phpbu\App\Cli\Executable;
use phpbu\App\Exception;
use phpbu\App\Result;
use phpbu\App\Util;

/**
 * Tar source class.
 *
 * @package    phpbu
 * @subpackage Backup
 * @author     Sebastian Feldmann <sebastian@phpbu.de>
 * @copyright  Sebastian Feldmann <sebastian@phpbu.de>
 * @license    https://opensource.org/licenses/MIT The MIT License (MIT)
 * @link       http://phpbu.de/
 * @since      Class available since Release 2.1.12
 */
class Redis extends Cli implements Source
{
    /**
     * Redis Executable
     *
     * @var \phpbu\App\Cli\Executable\RedisCli
     */
    private $executableLast;

The property $executableLast is not used and could be removed.

    /**
     * Path to executable.
     *
     * @var string
     */
    private $pathToRedisCli;

    /**
     * Show stdErr
     *
     * @var boolean
     */
    private $showStdErr;

    /**
     * Time to wait for the dump to finish
     *
     * @var integer
     */
    private $timeout;

    /**
     * Host to backup
     *
     * @var string
     */
    private $host;

    /**
     * Port to connect to
     *
     * @var boolean
     */
    private $port;

    /**
     * Password for authentication
     *
     * @var string
     */
    private $password;

    /**
     * Path to the redis rdb directory, for Debian it's /var/lib/redis/{PORT}/dump.rdb
     *
     * @var string
     */
    private $pathToRedisData;

    /**
     * Setup.
     *
     * @see    \phpbu\App\Backup\Source
     * @param  array $conf
     * @throws \phpbu\App\Exception
     */
    public function setup(array $conf = array())
    {
        $this->pathToRedisCli  = Util\Arr::getValue($conf, 'pathToRedisCli');
        $this->showStdErr      = Util\Str::toBoolean(Util\Arr::getValue($conf, 'showStdErr', ''), false);
        $this->pathToRedisData = Util\Arr::getValue($conf, 'pathToRedisData');
        $this->timeout         = Util\Arr::getValue($conf, 'timeout', 45);
        $this->host            = Util\Arr::getValue($conf, 'host');
        $this->port            = Util\Arr::getValue($conf, 'port');
        $this->password        = Util\Arr::getValue($conf, 'password');

        if (empty($this->pathToRedisData)) {
            throw new Exception('pathToRedisData option is mandatory');
        }
    }

    /**
     * Execute the backup.
     *
     * @see    \phpbu\App\Backup\Source
     * @param  \phpbu\App\Backup\Target $target
     * @param  \phpbu\App\Result        $result
     * @return \phpbu\App\Backup\Source\Status
     * @throws \phpbu\App\Exception
     */
    public function backup(Target $target, Result $result)
    {
        // set uncompressed default MIME type
        $target->setMimeType('application/octet-stream');

        $redisSave = $this->getExecutable($target);
        $redisLast = clone($redisSave);
        $redisLast->lastBackupTime();

It seems like you code against a concrete implementation and not the interface phpbu\App\Cli\Executable as the method lastBackupTime() does only exist in the following implementations of said interface: phpbu\App\Cli\Executable\RedisCli.

        $lastBackupTimestamp = $this->getLastBackupTime($redisLast);

$redisLast of type object<phpbu\App\Cli\Executable> is not a sub-type of object<phpbu\App\Cli\Executable\RedisCli>. It seems like you assume a concrete implementation of the interface phpbu\App\Cli\Executable to be always present.

        $saveResult = $redisSave->run();
        $result->debug($saveResult->getCmd());
        if (!$saveResult->wasSuccessful()) {
            throw new Exception('redis-cli BGSAVE failed');
        }
        $this->isDumpCreatedYet($lastBackupTimestamp, $redisLast);

$redisLast of type object<phpbu\App\Cli\Executable> is not a sub-type of object<phpbu\App\Cli\Executable\RedisCli>. It seems like you assume a concrete implementation of the interface phpbu\App\Cli\Executable to be always present.

        $pathToDump = $this->copyDumpToTargetDir($target);

        return Status::create()->uncompressed()->dataPath($pathToDump);
    }

    /**
     * Setup the Executable to run the 'tar' command.
     *
     * @param  \phpbu\App\Backup\Target
     * @return \phpbu\App\Cli\Executable
     */
    public function getExecutable(Target $target)
    {
        if (null == $this->executable) {
            $this->executable = new Executable\RedisCli($this->pathToRedisCli);
            $this->executable->backup()
                             ->useHost($this->host)
                             ->usePort($this->port)

$this->port is of type boolean, but the function expects a integer.

                             ->usePassword($this->password)
                             ->showStdErr($this->showStdErr);
        }
        return $this->executable;
    }

    /**
     * Return last successful save timestamp.
     *
     * @param  \phpbu\App\Cli\Executable\RedisCli $redis
     * @return int
     * @throws \phpbu\App\Exception
     */
    private function getLastBackupTime(Executable\RedisCli $redis)
    {
        $result  = $redis->run();
        $output  = $result->getOutputAsString();
        $matches = [];
        if (!preg_match('#\(integer\) ([0-9]+)#i', $output, $matches)) {
            throw new Exception('invalid redis-cli LASTSAVE output');
        }
        return $matches[1];
    }

    /**
     * Check the dump date and return true if BGSAVE is finished.
     *
     * @param  int $lastTimestamp
     * @param  \phpbu\App\Cli\Executable\RedisCli $redis
     * @return bool
     * @throws \phpbu\App\Exception
     */
    private function isDumpCreatedYet($lastTimestamp, $redis)
    {
        $i = 0;
        while ($this->getLastBackupTime($redis) <= $lastTimestamp) {
            if ($i > $this->timeout) {
                throw new Exception('redis-cli BGSAVE is taking to long, increase timeout');
            }
            $i++;
            sleep(1);
        }
        return true;
    }

    /**
     * Copy the redis RDB file to its backup location.
     *
     * @param  \phpbu\App\Backup\Target $target
     * @return string
     * @throws \phpbu\App\Exception
     */
    private function copyDumpToTargetDir(Target $target)
    {
        if (!file_exists($this->pathToRedisData)) {
            throw new Exception('Redis data not found at: \'' . $this->pathToRedisCli . '\'');
        }
        $targetFile = $target->getPathnamePlain();
        copy($this->pathToRedisData, $targetFile);
        return $targetFile;
    }
}