AmazonS3v3::getBackupFiles() - Code Metrics - Inspection of "WIP: Remote cleanup" - sebastianfeldmann/phpbu - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#140)

unknown

created 2018-05-07 16:50 UTC

AmazonS3v3::getBackupFiles() B

↳ Parent: AmazonS3v3

Complexity

Conditions	6
Paths	5

Size

Total Lines	24
Code Lines	13

Duplication

Lines	3
Ratio	12.5 %

Code Coverage

Tests	0
CRAP Score	42

Importance

Changes

Metric	Value
dl	3
loc	24
ccs	0
cts	20
cp	0
rs	8.5125
c	0
b	0
f	0
cc	6
eloc	13
nc	5
nop	0
crap	42

<?php
namespace phpbu\App\Backup\Collector;

use Aws\S3\S3Client;
use phpbu\App\Backup\Collector;
use phpbu\App\Backup\Target;

class AmazonS3v3 extends Collector
{
    /**
     * @var S3Client
     */
    protected $client;

    /**
     * AmazonS3 bucket name
     *
     * @var string
     */
    protected $bucket;

    /**
     * AmazonS3 remote path
     *
     * @var string
     */
    protected $path;

    /**
     * OpenStack constructor.
     *
     * @param \phpbu\App\Backup\Target $target
     * @param S3Client                 $client
     * @param string                   $bucket
     * @param string                   $path
     */
    public function __construct(Target $target, S3Client $client, string $bucket, string $path)
    {
        $this->client = $client;
        $this->bucket = $bucket;
        $this->path = ltrim($path, '/');
        $this->setUp($target);
    }

    /**
     * Get all created backups.
     *
     * @return \phpbu\App\Backup\File[]
     */
    public function getBackupFiles(): array
    {
        $result = $this->client->listObjects([
            'Bucket' => $this->bucket,
            'Prefix' => $this->path,
            'Delimiter' => '/',
        ]);

        if (!$result['Contents'] || !is_array($result['Contents'])) {
            return [];
        }

        foreach ($result['Contents'] as $object) {
            // skip currently created backup
            if ($object['Key'] == $this->path . $this->target->getFilename()) {
                continue;
            }
            if (preg_match('#' . $this->fileRegex . '#i', basename($object['Key']))) {
                $this->files[] = new \phpbu\App\Backup\File\AmazonS3v3($this->client, $this->bucket, $object);
            }
        }

        return $this->files;
    }
}

1		<?php
2		namespace phpbu\App\Backup\Collector;
3
4		use Aws\S3\S3Client;
5		use phpbu\App\Backup\Collector;
6		use phpbu\App\Backup\Target;
7
8		class AmazonS3v3 extends Collector
9		{
10		/**
11		* @var S3Client
12		*/
13		protected $client;
14
15		/**
16		* AmazonS3 bucket name
17		*
18		* @var string
19		*/
20		protected $bucket;
21
22		/**
23		* AmazonS3 remote path
24		*
25		* @var string
26		*/
27		protected $path;
28
29		/**
30		* OpenStack constructor.
31		*
32		* @param \phpbu\App\Backup\Target $target
33		* @param S3Client $client
34		* @param string $bucket
35		* @param string $path
36		*/
37		public function __construct(Target $target, S3Client $client, string $bucket, string $path)
38		{
39		$this->client = $client;
40		$this->bucket = $bucket;
41		$this->path = ltrim($path, '/');
42		$this->setUp($target);
43		}
44
45		/**
46		* Get all created backups.
47		*
48		* @return \phpbu\App\Backup\File[]
49		*/
50		public function getBackupFiles(): array
51		{
52		$result = $this->client->listObjects([
53		'Bucket' => $this->bucket,
54		'Prefix' => $this->path,
55		'Delimiter' => '/',
56		]);
57
58		if (!$result['Contents'] \|\| !is_array($result['Contents'])) {
59		return [];
60		}
61
62		foreach ($result['Contents'] as $object) {
63		// skip currently created backup
64		if ($object['Key'] == $this->path . $this->target->getFilename()) {
65		continue;
66		}
67	View Code Duplication	if (preg_match('#' . $this->fileRegex . '#i', basename($object['Key']))) {
68		$this->files[] = new \phpbu\App\Backup\File\AmazonS3v3($this->client, $this->bucket, $object);
69		}
70		}
71
72		return $this->files;
73		}
74		}

sebastianfeldmann / phpbu

Pull Request — master (#140)

AmazonS3v3::getBackupFiles() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like