phpbu\App\Backup\Source\Mysqldump::backup()

Complexity

Conditions	7
Paths	8

Size

Total Lines	37
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	7

Importance

Changes	3
Bugs	0	Features	0

<?php
    public function backup(Target $target, Result $result) : Status
    {
        // create the writable dump directory for tables files
        $dumpTarget = $this->getDumpTarget($target);
        if ($this->filePerTable && !is_dir($dumpTarget)) {
            $fileMode = 0777;

            if (PHP_OS !== 'WINNT') {
                // get the permissions of the first directory that exists
                $pathSegments = explode(DIRECTORY_SEPARATOR, $dumpTarget);

                do {
                    $filename = implode(DIRECTORY_SEPARATOR, $pathSegments);

                    if (is_dir($filename) === false) {
                        continue;
                    }

                    $fileMode = substr(fileperms($filename), -4);
                    break;
                } while (array_pop($pathSegments) !== null);
            }

            $old = umask(0);
            mkdir($dumpTarget, $fileMode, true);

It seems like $fileMode can also be of type string; however, parameter $mode of mkdir() does only seem to accept integer, maybe add an additional type check?

            umask($old);
        }

        $mysqldump = $this->execute($target);

        $result->debug($this->getExecutable($target)->getCommandPrintable());

        if (!$mysqldump->isSuccessful()) {
            throw new Exception('mysqldump failed:' . $mysqldump->getStdErr());
        }

        return $this->createStatus($target);
    }