phpbu\App\Runner\Check

Complexity

Total Complexity

6

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	hasFailed()	0	4	1
A	run()	0	17	3
A	check()	0	4	2

<?php
namespace phpbu\App\Runner;

use phpbu\App\Backup\Check as CheckExe;
use phpbu\App\Backup\Check\Exception;
use phpbu\App\Backup\Collector;
use phpbu\App\Backup\Target;
use phpbu\App\Configuration\Backup\Check as CheckConfig;
use phpbu\App\Result;

/**
 * Check Runner class.
 *
 * @package    phpbu
 * @subpackage App
 * @author     Sebastian Feldmann <sebastian@phpbu.de>
 * @copyright  Sebastian Feldmann <sebastian@phpbu.de>
 * @license    https://opensource.org/licenses/MIT The MIT License (MIT)
 * @link       http://phpbu.de/
 * @since      Class available since Release 3.0.0
 */
class Check extends Abstraction
{
    /**
     * Failure state of all executed Checks.
     *
     * @var boolean
     */
    private $failure = false;

    /**
     * Executes a backup check.
     *
     * @param \phpbu\App\Backup\Check               $check
     * @param \phpbu\App\Configuration\Backup\Check $config
     * @param \phpbu\App\Backup\Target              $target
     * @param \phpbu\App\Backup\Collector           $collector
     * @param \phpbu\App\Result                     $result
     */
    public function run(CheckExe $check, CheckConfig $config, Target $target, Collector $collector, Result $result)
    {
        try {
            $result->checkStart($config);

            if ($this->check($check, $config->value, $target, $collector, $result)) {

The call to Check::check() has too many arguments starting with $result.

                $result->checkEnd($config);
            } else {
                $this->failure = true;
                $result->checkFailed($config);
            }
        } catch (Exception $e) {
            $this->failure = true;
            $result->addError($e);
            $result->checkFailed($config);
        }
    }

    /**
     * Return true if the last check did fail.
     *
     * @return boolean
     */
    public function hasFailed()
    {
        return $this->failure;
    }

    /**
     * Executes the actual check.
     *
     * @param  \phpbu\App\Backup\Check     $check
     * @param  string                      $value
     * @param  \phpbu\App\Backup\Target    $target
     * @param  \phpbu\App\Backup\Collector $collector
     * @return bool
     */
    protected function check(CheckExe $check, $value, Target $target, Collector $collector)

Please use __construct() instead of a PHP4-style constructor that is named after the class.

    {
        return $this->isSimulation() ? true : $check->pass($target, $value, $collector);
    }

}