Diff::compare() - Code Metrics - Inspection of "Add 'diff-tree' command to the DiffOperator" - sebastianfeldmann/git - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 266e11...aef73b )

by Sebastian

created 2019-04-05 09:57 UTC

Diff::compare() A

↳ Parent: Diff

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
eloc	4
dl	0
loc	8
ccs	5
cts	5
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2
crap	1

<?php
/**
 * This file is part of SebastianFeldmann\Git.
 *
 * (c) Sebastian Feldmann <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace SebastianFeldmann\Git\Operator;

use SebastianFeldmann\Git\Command\Diff\Compare;
use SebastianFeldmann\Git\Command\DiffTree\ChangedFiles;

/**
 * Diff operator
 *
 * @package SebastianFeldmann\Git
 * @author  Sebastian Feldmann <[email protected]>
 * @link    https://github.com/sebastianfeldmann/git
 * @since   Class available since Release 1.2.0
 */
class Diff extends Base
{
    /**
     * Returns a list of files and their changes.
     *
     * @param  string $from
     * @param  string $to
     * @return \SebastianFeldmann\Git\Diff\File[]
     */
    public function compare(string $from, string $to): array
    {
        $compare = (new Compare($this->repo->getRoot()))->revisions($from, $to)
                                                        ->ignoreWhitespacesAtEndOfLine();

        $result = $this->runner->run($compare, new Compare\FullDiffList());

        return $result->getFormattedOutput();

    }

    /**
     * Uses 'diff-tree' to list the files that changed between two revisions
     *
     * @param  string $from
     * @param  string $to
     * @return string[]
     */
    public function getChangedFiles(string $from, string $to): array
    {
        $cmd    = (new ChangedFiles($this->repo->getRoot()))->fromRevision($from)->toRevision($to);
        $result = $this->runner->run($cmd);

        return $result->getBufferedOutput();
    }
}


1		<?php
2		/**
3		* This file is part of SebastianFeldmann\Git.
4		*
5		* (c) Sebastian Feldmann <[email protected]>
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*/
10		namespace SebastianFeldmann\Git\Operator;
11
12		use SebastianFeldmann\Git\Command\Diff\Compare;
13		use SebastianFeldmann\Git\Command\DiffTree\ChangedFiles;
14
15		/**
16		* Diff operator
17		*
18		* @package SebastianFeldmann\Git
19		* @author Sebastian Feldmann <[email protected]>
20		* @link https://github.com/sebastianfeldmann/git
21		* @since Class available since Release 1.2.0
22		*/
23		class Diff extends Base
24		{
25		/**
26		* Returns a list of files and their changes.
27		*
28		* @param string $from
29		* @param string $to
30		* @return \SebastianFeldmann\Git\Diff\File[]
31		*/
32	1	public function compare(string $from, string $to): array
33		{
34	1	$compare = (new Compare($this->repo->getRoot()))->revisions($from, $to)
35	1	->ignoreWhitespacesAtEndOfLine();
36
37	1	$result = $this->runner->run($compare, new Compare\FullDiffList());
38
39	1	return $result->getFormattedOutput();
		0 ignored issues – show Bug Best Practice introduced 2018-08-14 15:17 UTC by Report Bug Copy Issue Report The expression `return $result->getFormattedOutput()` returns the type `iterable` which is incompatible with the type-hinted return `array`. Loading history...
40		}
41
42		/**
43		* Uses 'diff-tree' to list the files that changed between two revisions
44		*
45		* @param string $from
46		* @param string $to
47		* @return string[]
48		*/
49	1	public function getChangedFiles(string $from, string $to): array
50		{
51	1	$cmd = (new ChangedFiles($this->repo->getRoot()))->fromRevision($from)->toRevision($to);
52	1	$result = $this->runner->run($cmd);
53
54	1	return $result->getBufferedOutput();
55		}
56		}
57

sebastianfeldmann / git

Push — master ( 266e11...aef73b )

Diff::compare() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like