Result - Code Metrics - Inspection of "Change single process to processor" - sebastianfeldmann/cli - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 65a442...e3692b )

by Sebastian

created 2017-01-22 16:19 UTC

Result A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	5
lcom	1
cbo	1
dl	0
loc	65
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	__construct()	5	1
A	getCommandResult()	4	1
A	isSuccessful()	4	1
A	getOutput()	4	1
A	getFormattedOutput()	4	1

<?php
/**
 * This file is part of SebastianFeldmann\Cli.
 *
 * (c) Sebastian Feldmann <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace SebastianFeldmann\Cli\Command\Runner;

use SebastianFeldmann\Cli\Command\Result as CommandResult;

/**
 * Class Result
 *
 * @package SebastianFeldmann\Cli
 */
class Result
{
    /**
     * @var \SebastianFeldmann\Cli\Command\Result
     */
    private $cmdResult;

    /**
     * @var iterable
     */
    private $formatted;

    /**
     * Result constructor.
     *
     * @param \SebastianFeldmann\Cli\Command\Result $cmdResult
     * @param iterable                              $formatted
     */
    public function __construct(CommandResult $cmdResult, $formatted = [])
    {
        $this->cmdResult = $cmdResult;
        $this->formatted = $formatted;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    /**
     * Get the raw command result.
     *
     * @return \SebastianFeldmann\Cli\Command\Result
     */
    public function getCommandResult() : CommandResult
    {
        return $this->cmdResult;
    }

    /**
     * Return true if command execution was successful.
     *
     * @return bool
     */
    public function isSuccessful() : bool
    {
        return $this->cmdResult->isSuccessful();
    }

    /**
     * Return cmd output as array.
     *
     * @return array
     */
    public function getOutput() : array
    {
        return $this->cmdResult->getStdOutAsArray();
    }

    /**
     * Return formatted output.
     *
     * @return array
     * @throws \Exception
     */
    public function getFormattedOutput()
    {
        return $this->formatted;
    }
}


1			<?php
2			/**
3			* This file is part of SebastianFeldmann\Cli.
4			*
5			* (c) Sebastian Feldmann <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10			namespace SebastianFeldmann\Cli\Command\Runner;
11
12			use SebastianFeldmann\Cli\Command\Result as CommandResult;
13
14			/**
15			* Class Result
16			*
17			* @package SebastianFeldmann\Cli
18			*/
19			class Result
20			{
21			/**
22			* @var \SebastianFeldmann\Cli\Command\Result
23			*/
24			private $cmdResult;
25
26			/**
27			* @var iterable
28			*/
29			private $formatted;
30
31			/**
32			* Result constructor.
33			*
34			* @param \SebastianFeldmann\Cli\Command\Result $cmdResult
35			* @param iterable $formatted
36			*/
37			public function __construct(CommandResult $cmdResult, $formatted = [])
38			{
39			$this->cmdResult = $cmdResult;
40			$this->formatted = $formatted;
			1 ignored issue – show Documentation Bug introduced 2017-01-22 16:27 UTC by Report Bug Copy Issue Report It seems like `$formatted` can also be of type `array`. However, the property `$formatted` is declared as type `object<SebastianFeldmann...ommand\Runner\iterable>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
41			}
42
43			/**
44			* Get the raw command result.
45			*
46			* @return \SebastianFeldmann\Cli\Command\Result
47			*/
48			public function getCommandResult() : CommandResult
49			{
50			return $this->cmdResult;
51			}
52
53			/**
54			* Return true if command execution was successful.
55			*
56			* @return bool
57			*/
58			public function isSuccessful() : bool
59			{
60			return $this->cmdResult->isSuccessful();
61			}
62
63			/**
64			* Return cmd output as array.
65			*
66			* @return array
67			*/
68			public function getOutput() : array
69			{
70			return $this->cmdResult->getStdOutAsArray();
71			}
72
73			/**
74			* Return formatted output.
75			*
76			* @return array
77			* @throws \Exception
78			*/
79			public function getFormattedOutput()
80			{
81			return $this->formatted;
82			}
83			}
84

sebastianfeldmann / cli

Push — master ( 65a442...e3692b )

Result A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Duplication Side-by-Side

Filter issues like