SebastianFeldmann\Cli\Processor\ProcOpen::run()

Complexity

Conditions	5
Paths	3

Size

Total Lines

34

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	16
CRAP Score	5.005

Importance

Changes

0

<?php
    public function run(string $cmd, array $acceptableExitCodes = [0]) : Result
    {
        $old            = error_reporting(0);
        $descriptorSpec = [
            ['pipe', 'r'],
            ['pipe', 'w'],
            ['pipe', 'w'],
        ];

        $process = proc_open($cmd, $descriptorSpec, $pipes);
        if (!is_resource($process)) {
            throw new RuntimeException('can\'t execute \'proc_open\'');
        }

        // Loop on process until it exits normally.
        do {
            $status = proc_get_status($process);
        } while ($status && $status['running']);

The expression $status of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

        $code   = $status['exitcode'] ?? -1;
        $stdOut = stream_get_contents($pipes[1]);
        $stdErr = stream_get_contents($pipes[2]);

        // make sure all pipes are closed before calling proc_close
        foreach ($pipes as $index => $pipe) {
            fclose($pipe);
            unset($pipes[$index]);
        }

        proc_close($process);
        error_reporting($old);

        return new Result($cmd, $code, $stdOut, $stdErr, '', $acceptableExitCodes);
    }
}