CreateControllerTest::testOnDispatchFail() - Code Metrics - sebaks/crud - Measure and Improve Code Quality continuously with Scrutinizer

CreateControllerTest::testOnDispatchFail() A
last analyzed 2016-02-05 10:48 UTC

↳ Parent: CreateControllerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	19
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	19
rs	9.4285
cc	1
eloc	13
nc	1
nop	0

<?php

namespace Sebaks\CrudTest\Controller\Admin;

use Sebaks\Crud\Controller\CreateController;
use Sebaks\Crud\View\Model\CreateViewModel;

class CreateControllerTest extends \PHPUnit_Framework_TestCase
{
    private $controller;
    private $data;

    private $creatorMock;
    private $view;
    private $eventMock;

    public function setUp()
    {
        $this->data = [
            'foo' => 'bar'
        ];

        $this->creatorMock = $this->getMockBuilder('T4webDomainInterface\Service\CreatorInterface')
            ->disableOriginalConstructor()
            ->getMock();

        $this->eventMock = $this->getMock('Zend\Mvc\MvcEvent');

        $this->view = new CreateViewModel();

        $this->controller = new CreateController(
            $this->data,
            $this->creatorMock,
            $this->view
        );
    }

    public function testOnDispatchSuccess()
    {
        $entityMock = $this->getMock('T4webDomainInterface\EntityInterface');

        $this->creatorMock->method('create')
            ->with($this->data)
            ->willReturn($entityMock);

        $this->eventMock->method('setResult')
            ->with($this->view);

        $actualViewModel = $this->controller->onDispatch($this->eventMock);

        $this->assertSame($this->view, $actualViewModel);
        $this->assertSame($entityMock, $actualViewModel->getEntity());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    public function testOnDispatchFail()
    {
        $this->creatorMock->method('create')
            ->with($this->data)
            ->willReturn(null);

        $this->creatorMock->method('getErrors')
            ->willReturn(['errorField' => 'error message']);

        $this->eventMock->method('setResult')
            ->with($this->view);

        $actualViewModel = $this->controller->onDispatch($this->eventMock);

        $this->assertSame($this->view, $actualViewModel);
        $this->assertNull($actualViewModel->getEntity());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->assertEquals(['errorField' => 'error message'], $actualViewModel->getErrors());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->assertSame($this->data, $actualViewModel->getInputData());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

}

1			<?php
2
3			namespace Sebaks\CrudTest\Controller\Admin;
4
5			use Sebaks\Crud\Controller\CreateController;
6			use Sebaks\Crud\View\Model\CreateViewModel;
7
8			class CreateControllerTest extends \PHPUnit_Framework_TestCase
9			{
10			private $controller;
11			private $data;
			0 ignored issues – show Comprehensibility introduced 2015-11-24 20:35 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
12			private $creatorMock;
13			private $view;
14			private $eventMock;
15
16			public function setUp()
17			{
18			$this->data = [
19			'foo' => 'bar'
20			];
21
22			$this->creatorMock = $this->getMockBuilder('T4webDomainInterface\Service\CreatorInterface')
23			->disableOriginalConstructor()
24			->getMock();
25
26			$this->eventMock = $this->getMock('Zend\Mvc\MvcEvent');
27
28			$this->view = new CreateViewModel();
29
30			$this->controller = new CreateController(
31			$this->data,
32			$this->creatorMock,
33			$this->view
34			);
35			}
36
37			public function testOnDispatchSuccess()
38			{
39			$entityMock = $this->getMock('T4webDomainInterface\EntityInterface');
40
41			$this->creatorMock->method('create')
42			->with($this->data)
43			->willReturn($entityMock);
44
45			$this->eventMock->method('setResult')
46			->with($this->view);
47
48			$actualViewModel = $this->controller->onDispatch($this->eventMock);
49
50			$this->assertSame($this->view, $actualViewModel);
51			$this->assertSame($entityMock, $actualViewModel->getEntity());
			0 ignored issues – show Bug introduced 2015-11-24 20:35 UTC by Report Bug Copy Issue Report The method `getEntity` does only exist in `Sebaks\Crud\View\Model\CreateViewModelInterface`, but not in `Zend\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
52			}
53
54			public function testOnDispatchFail()
55			{
56			$this->creatorMock->method('create')
57			->with($this->data)
58			->willReturn(null);
59
60			$this->creatorMock->method('getErrors')
61			->willReturn(['errorField' => 'error message']);
62
63			$this->eventMock->method('setResult')
64			->with($this->view);
65
66			$actualViewModel = $this->controller->onDispatch($this->eventMock);
67
68			$this->assertSame($this->view, $actualViewModel);
69			$this->assertNull($actualViewModel->getEntity());
			0 ignored issues – show Bug introduced 2015-11-24 20:35 UTC by Report Bug Copy Issue Report The method `getEntity` does only exist in `Sebaks\Crud\View\Model\CreateViewModelInterface`, but not in `Zend\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
70			$this->assertEquals(['errorField' => 'error message'], $actualViewModel->getErrors());
			0 ignored issues – show Bug introduced 2015-11-24 20:35 UTC by Report Bug Copy Issue Report The method `getErrors` does only exist in `Sebaks\Crud\View\Model\CreateViewModelInterface`, but not in `Zend\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
71			$this->assertSame($this->data, $actualViewModel->getInputData());
			0 ignored issues – show Bug introduced 2015-11-24 20:35 UTC by Report Bug Copy Issue Report The method `getInputData` does only exist in `Sebaks\Crud\View\Model\CreateViewModelInterface`, but not in `Zend\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
72			}
73
74			}

sebaks / crud

CreateControllerTest::testOnDispatchFail() A last analyzed 2016-02-05 10:48 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

CreateControllerTest::testOnDispatchFail() A
last analyzed 2016-02-05 10:48 UTC