Inspection of "Merge pull request #12 from seb86/issue-10" - seb86/woocommerce-subscribe-to-all-the-things-signup-trial-add-on - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9c0c61...cda7a3 )

by Sébastien

created 2016-08-12 18:21 UTC

Status

Indentation +63 added lines, -63 removed lines patch added patch discarded remove patch

@@ -8,69 +8,69 @@
 block discarded – undo
 
 class WCSATT_STT_Cart extends WCS_ATT_Cart {
 
-	/**
-	 * Initialize the cart.
-	 *
-	 * @access public
-	 * @static
-	 */
-	public static function init() {
-		// Overrides the price of the subscription for sign up fee and/or trial on the 'wcsatt_cart_item' filter.
-		add_filter( 'wcsatt_cart_item', __CLASS__ . '::update_cart_item_sub_data', 10, 1 );
-	}
-
-	/**
-	 * Updates the cart item data for a subscription product that
-	 * has a sign-up fee and/or trial period applied.
-	 *
-	 * @access public
-	 * @static
-	 * @param  array $cart_item
-	 * @return array
-	 */
-	public static function update_cart_item_sub_data( $cart_item ) {
-		$active_scheme = WCS_ATT_Schemes::get_active_subscription_scheme( $cart_item );
-
-		$subscription_prices = WCS_ATT_Scheme_Prices::get_active_subscription_scheme_prices( $cart_item, $active_scheme );
-
-		if ( $active_scheme && $cart_item['data']->is_converted_to_sub == 'yes' ) {
-
-			// Subscription Price
-			$price = $cart_item['data']->subscription_price;
-
-			// Is there a sign up fee?
-			$sign_up_fee = isset( $subscription_prices['sign_up_fee'] ) ? $subscription_prices['sign_up_fee'] : '';
-
-			// Checks if the cart item is a supported bundle type child.
-			$container_key = WCS_ATT_Integrations::has_bundle_type_container( $cart_item );
-
-			// If the cart item is a child item then reset the sign-up fee.
-			if ( false !== $container_key ) { $sign_up_fee = ''; }
-
-			// Put both the subscription price and the sign-up fee together.
-			$new_price = round( $price + $sign_up_fee, wc_get_price_decimals() );
-
-			if ( $sign_up_fee > 0 ) {
-				$cart_item['data']->initial_amount = $new_price;
-				$cart_item['data']->subscription_sign_up_fee = $sign_up_fee;
-			}
-
-			$trial_length = isset( $subscription_prices['trial_length'] ) ? $subscription_prices['trial_length'] : 0;
-			$trial_period = isset( $subscription_prices['trial_period'] ) ? $subscription_prices['trial_period'] : '';
-
-			// If a trial length is more than zero then set the conditions for the cart.
-			if ( $trial_length > 0 ) {
-				$cart_item['data']->subscription_trial_length = $trial_length;
-				$cart_item['data']->subscription_trial_period = $trial_period;
-			} else {
-				$cart_item['data']->subscription_trial_length = 0;
-				$cart_item['data']->subscription_trial_period = '';
-			}
-
-		}
-
-		return $cart_item;
-	} // END update_cart_item_sub_data()
+    /**
+     * Initialize the cart.
+     *
+     * @access public
+     * @static
+     */
+    public static function init() {
+        // Overrides the price of the subscription for sign up fee and/or trial on the 'wcsatt_cart_item' filter.
+        add_filter( 'wcsatt_cart_item', __CLASS__ . '::update_cart_item_sub_data', 10, 1 );
+    }
+
+    /**
+     * Updates the cart item data for a subscription product that
+     * has a sign-up fee and/or trial period applied.
+     *
+     * @access public
+     * @static
+     * @param  array $cart_item
+     * @return array
+     */
+    public static function update_cart_item_sub_data( $cart_item ) {
+        $active_scheme = WCS_ATT_Schemes::get_active_subscription_scheme( $cart_item );
+
+        $subscription_prices = WCS_ATT_Scheme_Prices::get_active_subscription_scheme_prices( $cart_item, $active_scheme );
+
+        if ( $active_scheme && $cart_item['data']->is_converted_to_sub == 'yes' ) {
+
+            // Subscription Price
+            $price = $cart_item['data']->subscription_price;
+
+            // Is there a sign up fee?
+            $sign_up_fee = isset( $subscription_prices['sign_up_fee'] ) ? $subscription_prices['sign_up_fee'] : '';
+
+            // Checks if the cart item is a supported bundle type child.
+            $container_key = WCS_ATT_Integrations::has_bundle_type_container( $cart_item );
+
+            // If the cart item is a child item then reset the sign-up fee.
+            if ( false !== $container_key ) { $sign_up_fee = ''; }
+
+            // Put both the subscription price and the sign-up fee together.
+            $new_price = round( $price + $sign_up_fee, wc_get_price_decimals() );
+
+            if ( $sign_up_fee > 0 ) {
+                $cart_item['data']->initial_amount = $new_price;
+                $cart_item['data']->subscription_sign_up_fee = $sign_up_fee;
+            }
+
+            $trial_length = isset( $subscription_prices['trial_length'] ) ? $subscription_prices['trial_length'] : 0;
+            $trial_period = isset( $subscription_prices['trial_period'] ) ? $subscription_prices['trial_period'] : '';
+
+            // If a trial length is more than zero then set the conditions for the cart.
+            if ( $trial_length > 0 ) {
+                $cart_item['data']->subscription_trial_length = $trial_length;
+                $cart_item['data']->subscription_trial_period = $trial_period;
+            } else {
+                $cart_item['data']->subscription_trial_length = 0;
+                $cart_item['data']->subscription_trial_period = '';
+            }
+
+        }
+
+        return $cart_item;
+    } // END update_cart_item_sub_data()
 
 }
 

Please login to merge, or discard this patch.

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -16,7 +16,7 @@  discard block
 block discarded – undo
 	 */
 	public static function init() {
 		// Overrides the price of the subscription for sign up fee and/or trial on the 'wcsatt_cart_item' filter.
-		add_filter( 'wcsatt_cart_item', __CLASS__ . '::update_cart_item_sub_data', 10, 1 );
+		add_filter('wcsatt_cart_item', __CLASS__.'::update_cart_item_sub_data', 10, 1);
 	}
 
 	/**
@@ -28,38 +28,38 @@  discard block
 block discarded – undo
 	 * @param  array $cart_item
 	 * @return array
 	 */
-	public static function update_cart_item_sub_data( $cart_item ) {
-		$active_scheme = WCS_ATT_Schemes::get_active_subscription_scheme( $cart_item );
+	public static function update_cart_item_sub_data($cart_item) {
+		$active_scheme = WCS_ATT_Schemes::get_active_subscription_scheme($cart_item);
 
-		$subscription_prices = WCS_ATT_Scheme_Prices::get_active_subscription_scheme_prices( $cart_item, $active_scheme );
+		$subscription_prices = WCS_ATT_Scheme_Prices::get_active_subscription_scheme_prices($cart_item, $active_scheme);
 
-		if ( $active_scheme && $cart_item['data']->is_converted_to_sub == 'yes' ) {
+		if ($active_scheme && $cart_item['data']->is_converted_to_sub == 'yes') {
 
 			// Subscription Price
 			$price = $cart_item['data']->subscription_price;
 
 			// Is there a sign up fee?
-			$sign_up_fee = isset( $subscription_prices['sign_up_fee'] ) ? $subscription_prices['sign_up_fee'] : '';
+			$sign_up_fee = isset($subscription_prices['sign_up_fee']) ? $subscription_prices['sign_up_fee'] : '';
 
 			// Checks if the cart item is a supported bundle type child.
-			$container_key = WCS_ATT_Integrations::has_bundle_type_container( $cart_item );
+			$container_key = WCS_ATT_Integrations::has_bundle_type_container($cart_item);
 
 			// If the cart item is a child item then reset the sign-up fee.
-			if ( false !== $container_key ) { $sign_up_fee = ''; }
+			if (false !== $container_key) { $sign_up_fee = ''; }
 
 			// Put both the subscription price and the sign-up fee together.
-			$new_price = round( $price + $sign_up_fee, wc_get_price_decimals() );
+			$new_price = round($price + $sign_up_fee, wc_get_price_decimals());
 
-			if ( $sign_up_fee > 0 ) {
+			if ($sign_up_fee > 0) {
 				$cart_item['data']->initial_amount = $new_price;
 				$cart_item['data']->subscription_sign_up_fee = $sign_up_fee;
 			}
 
-			$trial_length = isset( $subscription_prices['trial_length'] ) ? $subscription_prices['trial_length'] : 0;
-			$trial_period = isset( $subscription_prices['trial_period'] ) ? $subscription_prices['trial_period'] : '';
+			$trial_length = isset($subscription_prices['trial_length']) ? $subscription_prices['trial_length'] : 0;
+			$trial_period = isset($subscription_prices['trial_period']) ? $subscription_prices['trial_period'] : '';
 
 			// If a trial length is more than zero then set the conditions for the cart.
-			if ( $trial_length > 0 ) {
+			if ($trial_length > 0) {
 				$cart_item['data']->subscription_trial_length = $trial_length;
 				$cart_item['data']->subscription_trial_period = $trial_period;
 			} else {

Please login to merge, or discard this patch.

		@@ -16,7 +16,7 @@ discard block
		block discarded – undo
16	16	*/
17	17	public static function init() {
18	18	// Overrides the price of the subscription for sign up fee and/or trial on the 'wcsatt_cart_item' filter.
19		- add_filter( 'wcsatt_cart_item', __CLASS__ . '::update_cart_item_sub_data', 10, 1 );
	19	+ add_filter('wcsatt_cart_item', __CLASS__.'::update_cart_item_sub_data', 10, 1);
20	20	}
21	21
22	22	/**
		@@ -28,38 +28,38 @@ discard block
		block discarded – undo
28	28	* @param array $cart_item
29	29	* @return array
30	30	*/
31		- public static function update_cart_item_sub_data( $cart_item ) {
32		- $active_scheme = WCS_ATT_Schemes::get_active_subscription_scheme( $cart_item );
	31	+ public static function update_cart_item_sub_data($cart_item) {
	32	+ $active_scheme = WCS_ATT_Schemes::get_active_subscription_scheme($cart_item);
33	33
34		- $subscription_prices = WCS_ATT_Scheme_Prices::get_active_subscription_scheme_prices( $cart_item, $active_scheme );
	34	+ $subscription_prices = WCS_ATT_Scheme_Prices::get_active_subscription_scheme_prices($cart_item, $active_scheme);
35	35
36		- if ( $active_scheme && $cart_item['data']->is_converted_to_sub == 'yes' ) {
	36	+ if ($active_scheme && $cart_item['data']->is_converted_to_sub == 'yes') {
37	37
38	38	// Subscription Price
39	39	$price = $cart_item['data']->subscription_price;
40	40
41	41	// Is there a sign up fee?
42		- $sign_up_fee = isset( $subscription_prices['sign_up_fee'] ) ? $subscription_prices['sign_up_fee'] : '';
	42	+ $sign_up_fee = isset($subscription_prices['sign_up_fee']) ? $subscription_prices['sign_up_fee'] : '';
43	43
44	44	// Checks if the cart item is a supported bundle type child.
45		- $container_key = WCS_ATT_Integrations::has_bundle_type_container( $cart_item );
	45	+ $container_key = WCS_ATT_Integrations::has_bundle_type_container($cart_item);
46	46
47	47	// If the cart item is a child item then reset the sign-up fee.
48		- if ( false !== $container_key ) { $sign_up_fee = ''; }
	48	+ if (false !== $container_key) { $sign_up_fee = ''; }
49	49
50	50	// Put both the subscription price and the sign-up fee together.
51		- $new_price = round( $price + $sign_up_fee, wc_get_price_decimals() );
	51	+ $new_price = round($price + $sign_up_fee, wc_get_price_decimals());
52	52
53		- if ( $sign_up_fee > 0 ) {
	53	+ if ($sign_up_fee > 0) {
54	54	$cart_item['data']->initial_amount = $new_price;
55	55	$cart_item['data']->subscription_sign_up_fee = $sign_up_fee;
56	56	}
57	57
58		- $trial_length = isset( $subscription_prices['trial_length'] ) ? $subscription_prices['trial_length'] : 0;
59		- $trial_period = isset( $subscription_prices['trial_period'] ) ? $subscription_prices['trial_period'] : '';
	58	+ $trial_length = isset($subscription_prices['trial_length']) ? $subscription_prices['trial_length'] : 0;
	59	+ $trial_period = isset($subscription_prices['trial_period']) ? $subscription_prices['trial_period'] : '';
60	60
61	61	// If a trial length is more than zero then set the conditions for the cart.
62		- if ( $trial_length > 0 ) {
	62	+ if ($trial_length > 0) {
63	63	$cart_item['data']->subscription_trial_length = $trial_length;
64	64	$cart_item['data']->subscription_trial_period = $trial_period;
65	65	} else {

		@@ -8,69 +8,69 @@
		block discarded – undo
8	8
9	9	class WCSATT_STT_Cart extends WCS_ATT_Cart {
10	10
11		- /**
12		- * Initialize the cart.
13		- *
14		- * @access public
15		- * @static
16		- */
17		- public static function init() {
18		- // Overrides the price of the subscription for sign up fee and/or trial on the 'wcsatt_cart_item' filter.
19		- add_filter( 'wcsatt_cart_item', __CLASS__ . '::update_cart_item_sub_data', 10, 1 );
20		- }
21		-
22		- /**
23		- * Updates the cart item data for a subscription product that
24		- * has a sign-up fee and/or trial period applied.
25		- *
26		- * @access public
27		- * @static
28		- * @param array $cart_item
29		- * @return array
30		- */
31		- public static function update_cart_item_sub_data( $cart_item ) {
32		- $active_scheme = WCS_ATT_Schemes::get_active_subscription_scheme( $cart_item );
33		-
34		- $subscription_prices = WCS_ATT_Scheme_Prices::get_active_subscription_scheme_prices( $cart_item, $active_scheme );
35		-
36		- if ( $active_scheme && $cart_item['data']->is_converted_to_sub == 'yes' ) {
37		-
38		- // Subscription Price
39		- $price = $cart_item['data']->subscription_price;
40		-
41		- // Is there a sign up fee?
42		- $sign_up_fee = isset( $subscription_prices['sign_up_fee'] ) ? $subscription_prices['sign_up_fee'] : '';
43		-
44		- // Checks if the cart item is a supported bundle type child.
45		- $container_key = WCS_ATT_Integrations::has_bundle_type_container( $cart_item );
46		-
47		- // If the cart item is a child item then reset the sign-up fee.
48		- if ( false !== $container_key ) { $sign_up_fee = ''; }
49		-
50		- // Put both the subscription price and the sign-up fee together.
51		- $new_price = round( $price + $sign_up_fee, wc_get_price_decimals() );
52		-
53		- if ( $sign_up_fee > 0 ) {
54		- $cart_item['data']->initial_amount = $new_price;
55		- $cart_item['data']->subscription_sign_up_fee = $sign_up_fee;
56		- }
57		-
58		- $trial_length = isset( $subscription_prices['trial_length'] ) ? $subscription_prices['trial_length'] : 0;
59		- $trial_period = isset( $subscription_prices['trial_period'] ) ? $subscription_prices['trial_period'] : '';
60		-
61		- // If a trial length is more than zero then set the conditions for the cart.
62		- if ( $trial_length > 0 ) {
63		- $cart_item['data']->subscription_trial_length = $trial_length;
64		- $cart_item['data']->subscription_trial_period = $trial_period;
65		- } else {
66		- $cart_item['data']->subscription_trial_length = 0;
67		- $cart_item['data']->subscription_trial_period = '';
68		- }
69		-
70		- }
71		-
72		- return $cart_item;
73		- } // END update_cart_item_sub_data()
	11	+ /**
	12	+ * Initialize the cart.
	13	+ *
	14	+ * @access public
	15	+ * @static
	16	+ */
	17	+ public static function init() {
	18	+ // Overrides the price of the subscription for sign up fee and/or trial on the 'wcsatt_cart_item' filter.
	19	+ add_filter( 'wcsatt_cart_item', __CLASS__ . '::update_cart_item_sub_data', 10, 1 );
	20	+ }
	21	+
	22	+ /**
	23	+ * Updates the cart item data for a subscription product that
	24	+ * has a sign-up fee and/or trial period applied.
	25	+ *
	26	+ * @access public
	27	+ * @static
	28	+ * @param array $cart_item
	29	+ * @return array
	30	+ */
	31	+ public static function update_cart_item_sub_data( $cart_item ) {
	32	+ $active_scheme = WCS_ATT_Schemes::get_active_subscription_scheme( $cart_item );
	33	+
	34	+ $subscription_prices = WCS_ATT_Scheme_Prices::get_active_subscription_scheme_prices( $cart_item, $active_scheme );
	35	+
	36	+ if ( $active_scheme && $cart_item['data']->is_converted_to_sub == 'yes' ) {
	37	+
	38	+ // Subscription Price
	39	+ $price = $cart_item['data']->subscription_price;
	40	+
	41	+ // Is there a sign up fee?
	42	+ $sign_up_fee = isset( $subscription_prices['sign_up_fee'] ) ? $subscription_prices['sign_up_fee'] : '';
	43	+
	44	+ // Checks if the cart item is a supported bundle type child.
	45	+ $container_key = WCS_ATT_Integrations::has_bundle_type_container( $cart_item );
	46	+
	47	+ // If the cart item is a child item then reset the sign-up fee.
	48	+ if ( false !== $container_key ) { $sign_up_fee = ''; }
	49	+
	50	+ // Put both the subscription price and the sign-up fee together.
	51	+ $new_price = round( $price + $sign_up_fee, wc_get_price_decimals() );
	52	+
	53	+ if ( $sign_up_fee > 0 ) {
	54	+ $cart_item['data']->initial_amount = $new_price;
	55	+ $cart_item['data']->subscription_sign_up_fee = $sign_up_fee;
	56	+ }
	57	+
	58	+ $trial_length = isset( $subscription_prices['trial_length'] ) ? $subscription_prices['trial_length'] : 0;
	59	+ $trial_period = isset( $subscription_prices['trial_period'] ) ? $subscription_prices['trial_period'] : '';
	60	+
	61	+ // If a trial length is more than zero then set the conditions for the cart.
	62	+ if ( $trial_length > 0 ) {
	63	+ $cart_item['data']->subscription_trial_length = $trial_length;
	64	+ $cart_item['data']->subscription_trial_period = $trial_period;
	65	+ } else {
	66	+ $cart_item['data']->subscription_trial_length = 0;
	67	+ $cart_item['data']->subscription_trial_period = '';
	68	+ }
	69	+
	70	+ }
	71	+
	72	+ return $cart_item;
	73	+ } // END update_cart_item_sub_data()
74	74
75	75	}
76	76

seb86 / woocommerce-subscribe-to-all-the-things-signup-trial-add-on

Push — master ( 9c0c61...cda7a3 )

Status

Category

Indentation +63 added lines, -63 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch