ClientTest::testNext() - Code Metrics - Inspection of "fix: add PHP8 restriction of V0.7.2 for package" - scriptotek/php-sru-client - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — main ( 6731d6...4efee0 )

by Dan Michael O.
created 2024-03-11 21:10 UTC
ClientTest::testNext() A

↳ Parent: ClientTest
Complexity

Conditions	1
Paths	1
Size

Total Lines	87
Code Lines	16
Duplication

Lines	0
Ratio	0 %
Importance

Changes	1
Bugs	1	Features	0
Metric	Value
cc	1
eloc	16
c	1
b	1
f	0
nc	1
nop	0
dl	0
loc	87
rs	9.7333
How to fix Long Method

<?php namespace Scriptotek\Sru;

use GuzzleHttp\Psr7\Response as HttpResponse;
use function GuzzleHttp\Psr7\stream_for;
use Mockery as m;
filter:
    dependency_paths: ["lib/*"]
use Http\Mock\Client as MockHttp;

class ClientTest extends TestCase
{
    protected $url = 'http://sru.my_fictive_host.net';

    protected $simple_response = '<?xml version="1.0" encoding="UTF-8" ?>
              <srw:searchRetrieveResponse xmlns:srw="http://www.loc.gov/zing/srw/" xmlns:xcql="http://www.loc.gov/zing/cql/xcql/">
              </srw:searchRetrieveResponse>';

    protected $simple_explain_response = '<?xml version="1.0" encoding="UTF-8"?>
            <sru:explainResponse xmlns:sru="http://www.loc.gov/zing/srw/">
            </sru:explainResponse>';

    public function testUrlTo()
    {
        $sru1 = new Client($this->url);
        $expectedUrl1 = $this->url . '?operation=searchRetrieve&version=1.1&recordSchema=marcxml&maximumRecords=10&query=isbn%3D123';
        $expectedUrl2 = $this->url . '?operation=searchRetrieve&version=1.1&recordSchema=marcxml&maximumRecords=50&query=isbn%3D123&startRecord=2';
        $expectedUrl5 = $this->url . '?operation=searchRetrieve&version=1.1&recordSchema=marcxml&maximumRecords=10&query=isbn%3D123&httpAccept=application%2Fxml';

        $sru3 = new Client($this->url, array('schema' => 'CUSTOMSCHEMA'));
        $expectedUrl3 = $this->url . '?operation=searchRetrieve&version=1.1&recordSchema=CUSTOMSCHEMA&maximumRecords=10&query=isbn%3D123';

        $sru4 = new Client($this->url, array('version' => '0.9'));
        $expectedUrl4 = $this->url . '?operation=searchRetrieve&version=0.9&recordSchema=marcxml&maximumRecords=10&query=isbn%3D123';

        $this->assertEquals($expectedUrl1, $sru1->urlTo('isbn=123'));
        $this->assertEquals($expectedUrl2, $sru1->urlTo('isbn=123', 2, 50));
        $this->assertEquals($expectedUrl3, $sru3->urlTo('isbn=123'));
        $this->assertEquals($expectedUrl4, $sru4->urlTo('isbn=123'));
        $this->assertEquals($expectedUrl5, $sru1->urlTo('isbn=123', 1, 10, array('httpAccept' => 'application/xml')));
    }

    public function testSearch()
    {
        $http = $this->httpMockWithResponses($this->simple_response);
        $sru = new Client($this->url, null, $http);

        $this->assertXmlStringEqualsXmlString(
            $this->simple_response,
            $sru->search('test')->asXml()
            /** @scrutinizer ignore-deprecated */ $sru->search('test')->asXml()
        );
    }

    public function testNext()
    {
        $cql = 'dc.title="Joda jada isjda"';

        $http = new MockHttp();
        $http->addResponse(
            (new HttpResponse())
                ->withBody(stream_for('<?xml version="1.0" encoding="UTF-8" ?>
                ->withBody(/** @scrutinizer ignore-deprecated */ stream_for('<?xml version="1.0" encoding="UTF-8" ?>
                      <srw:searchRetrieveResponse
                        xmlns:srw="http://www.loc.gov/zing/srw/"
                        xmlns:xcql="http://www.loc.gov/zing/cql/xcql/"
                      >
                        <srw:version>1.1</srw:version>
                        <srw:numberOfRecords>3</srw:numberOfRecords>
                        <srw:records>
                          <srw:record>
                            <srw:recordSchema>marcxchange</srw:recordSchema>
                            <srw:recordPacking>xml</srw:recordPacking>
                            <srw:recordPosition>1</srw:recordPosition>
                            <srw:recordData>Record 1</srw:recordData>
                          </srw:record>
                          <srw:record>
                            <srw:recordSchema>marcxchange</srw:recordSchema>
                            <srw:recordPacking>xml</srw:recordPacking>
                            <srw:recordPosition>2</srw:recordPosition>
                            <srw:recordData>Record 2</srw:recordData>
                          </srw:record>
                        </srw:records>
                        <srw:nextRecordPosition>3</srw:nextRecordPosition>
                        <srw:echoedSearchRetrieveRequest>
                          <srw:operation>searchRetrieve</srw:operation>
                          <srw:version>1.1</srw:version>
                          <srw:query>\' . $cql . \'</srw:query>
                          <srw:startRecord>1</srw:startRecord>
                          <srw:maximumRecords>2</srw:maximumRecords>
                          <srw:recordSchema>marcxchange</srw:recordSchema>
                        </srw:echoedSearchRetrieveRequest>
                        <srw:extraResponseData>
                          <responseDate>2014-03-28T12:09:50Z</responseDate>
                        </srw:extraResponseData>
                      </srw:searchRetrieveResponse>
                    ')
                )
        );

        $sru = new Client($this->url, null, $http);
        $response = $sru->search($cql);
        $response = /** @scrutinizer ignore-deprecated */ $sru->search($cql);
        $this->assertCount(2, $response->records);


        $http->addResponse(
            (new HttpResponse())
                ->withBody(stream_for('<?xml version="1.0" encoding="UTF-8" ?>
                ->withBody(/** @scrutinizer ignore-deprecated */ stream_for('<?xml version="1.0" encoding="UTF-8" ?>
                    <srw:searchRetrieveResponse
                xmlns:srw="http://www.loc.gov/zing/srw/"
                xmlns:xcql="http://www.loc.gov/zing/cql/xcql/"
              >
                <srw:version>1.1</srw:version>
                <srw:numberOfRecords>3</srw:numberOfRecords>
                <srw:records>
                  <srw:record>
                    <srw:recordSchema>marcxchange</srw:recordSchema>
                    <srw:recordPacking>xml</srw:recordPacking>
                    <srw:recordPosition>3</srw:recordPosition>
                    <srw:recordData>Record 3</srw:recordData>
                  </srw:record>
                </srw:records>
                <srw:echoedSearchRetrieveRequest>
                  <srw:operation>searchRetrieve</srw:operation>
                  <srw:version>1.1</srw:version>
                  <srw:query>' . $cql . '</srw:query>
                  <srw:startRecord>3</srw:startRecord>
                  <srw:maximumRecords>2</srw:maximumRecords>
                  <srw:recordSchema>marcxchange</srw:recordSchema>
                </srw:echoedSearchRetrieveRequest>
                <srw:extraResponseData>
                  <responseDate>2014-03-28T12:09:50Z</responseDate>
                </srw:extraResponseData>
              </srw:searchRetrieveResponse>
            '))
        );

        $response = $response->next();
        $this->assertCount(1, $response->records);

        $response = $response->next();
        $this->assertNull($response);
    }

    public function testHttpHeaders()
    {
        $sru1 = new Client($this->url, array(
            'user-agent' => 'Blablabla/0.1',
        ));

        $opts = $sru1->headers;

        $this->assertEquals('application/xml', $opts['Accept']);
        $this->assertEquals('Blablabla/0.1', $opts['User-Agent']);
    }

    public function testRecords()
    {
        $http = $this->httpMockWithResponses($this->makeDummyResponse(1));

        $sru1 = new Client($this->url, [], $http);
        $r = $sru1->records('test', 1);
        $r = /** @scrutinizer ignore-deprecated */ $sru1->records('test', 1);

        $this->assertInstanceOf('Scriptotek\Sru\Records', $r);
    }

    public function testExplain()
    {
        $http = $this->httpMockWithResponses($this->simple_explain_response);
        $sru = new Client($this->url, null, $http);
        $exp = $sru->explain();

        $this->assertInstanceOf('Scriptotek\Sru\ExplainResponse', $exp);

        $this->assertXmlStringEqualsXmlString(
            $this->simple_explain_response,
            $exp->asXml()
        );
    }
}

scriptotek / php-sru-client

Push — main ( 6731d6...4efee0 )

ClientTest::testNext() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
