Scriptotek\GoogleBooks\Volumes

Complexity

Total Complexity

7

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	search()	0	4	1
A	fetchSearch()	0	9	2
A	firstOrNull()	0	4	1
A	find()	0	4	1
A	byIsbn()	0	5	1

<?php

namespace Scriptotek\GoogleBooks;

use Scriptotek\GoogleBooks\LibraryBuilder;

class Volumes
{
    protected $client;
    protected $chunk = false;

    public function __construct(GoogleBooks $client)
    {
        $this->client = $client;
    }

    /**
     * @param $query
     * @return \Generator|Volume || array
     */
    public function search($query)
    {
        return (new LibraryBuilder($this->client))->search($query);
    }

    /**
     * @param $query
     * @return \Generator|Volume
     */
    public function fetchSearch($query)
    {
        $return = [];
        foreach ($this->client->listItems('volumes', ['q' => $query]) as $item) {

The expression $this->client->listItems('volumes', array('q' => $query)) of type array|null is not guaranteed to be traversable. How about adding an additional type check?

            $return[] = new Volume($this->client, $item);
        }

        return $return;
    }

    public function firstOrNull($query)
    {
        return $this->search($query)->first();
    }

    public function find($id)
    {
        return (new LibraryBuilder($this->client))->find($id);
    }

    public function byIsbn($isbn)
    {
        $isbn = preg_replace('/[^0-9Xx]/', '', $isbn);
        return $this->search('isbn:' . $isbn)->first();
    }
}