Completed
Push — master ( 6c5b86...657a58 )
by Dan Michael O.
01:30
created

Bookshelf::__isset()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 4
Code Lines 2

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
dl 0
loc 4
rs 10
c 0
b 0
f 0
cc 1
eloc 2
nc 1
nop 1
1
<?php
2
3
namespace Scriptotek\GoogleBooks;
4
5
class Bookshelf
6
{
7
    protected $data;
8
    protected $uid;
9
    protected $client;
10
11
    public function __construct(GoogleBooks $client, $data)
12
    {
13
        $this->client = $client;
14
        $this->data = $data;
15
        $selfLinkParts = explode('/', $data->selfLink);
16
        $this->uid = $selfLinkParts[count($selfLinkParts) - 3];
17
    }
18
19
    public function getVolumes()
20
    {
21
        foreach ($this->client->listItems("users/$this->uid/bookshelves/$this->id/volumes") as $item) {
0 ignored issues
show
Documentation introduced by
The property id does not exist on object<Scriptotek\GoogleBooks\Bookshelf>. Since you implemented __get, maybe consider adding a @property annotation.

Since your code implements the magic getter _get, this function will be called for any read access on an undefined variable. You can add the @property annotation to your class or interface to document the existence of this variable.

<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

If the property has read access only, you can use the @property-read annotation instead.

Of course, you may also just have mistyped another name, in which case you should fix the error.

See also the PhpDoc documentation for @property.

Loading history...
22
            yield new Volume($this->client, $item);
23
        }
24
    }
25
26
    public function __get($key)
27
    {
28
        if (isset($this->data->{$key})) {
29
            return $this->data->{$key};
30
        }
31
    }
32
    
33
    public function __isset($key)
34
    {
35
        return isset($this->data->{$key});
36
    }
37
38
    public function __toString()
39
    {
40
        return json_encode($this->data);
41
    }
42
}
43