PortfolioSpec - Code Metrics - Inspection of "Add portfolios and representations" - scriptotek/php-alma-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 804c7f...1d2ba7 )

by Dan Michael O.

created 2019-01-10 22:46 UTC

PortfolioSpec A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

Metric	Value
dl	0
loc	35
rs	10
c	0
b	0
f	0
wmc	5
lcom	0
cbo	3

5 Methods

Rating	Name	Size	Complexity
A	let()	6	1
A	it_is_initializable()	4	1
A	expectRequest()	6	1
A	it_fetches_data_when_needed()	6	1
A	it_belongs_to_collection()	7	1

<?php

namespace spec\Scriptotek\Alma\Bibs;

use PhpSpec\ObjectBehavior;
use Prophecy\Argument;
use Scriptotek\Alma\Bibs\Bib;
use Scriptotek\Alma\Bibs\Portfolio;
use Scriptotek\Alma\Bibs\Portfolios;
use Scriptotek\Alma\Client as AlmaClient;
use Scriptotek\Alma\Electronic\Collection;
use spec\Scriptotek\Alma\SpecHelper;

class PortfolioSpec extends ObjectBehavior
{
    public function let(AlmaClient $client, Bib $bib)
    {
        $bib->mms_id = 'abc';
        $portfolio_id = '123';
        $this->beConstructedWith($client, $bib, $portfolio_id);
    }

    function it_is_initializable()
    {
        $this->shouldHaveType(Portfolio::class);
    }

    protected function expectRequest($client)
    {
        $client->getJSON('/bibs/abc/portfolios/123')
            ->shouldBeCalled()
            ->willReturn(SpecHelper::getDummyData('portfolio_response.json'));
    }

    public function it_fetches_data_when_needed(AlmaClient $client)
    {
        $this->expectRequest($client);

        $this->availability->desc->shouldBe('Available');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function it_belongs_to_collection(AlmaClient $client)
    {
        $this->expectRequest($client);

        $this->getElectronicCollection()->shouldHaveType(Collection::class);
        $this->electronic_collection->shouldHaveType(Collection::class);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }}


1			<?php
2
3			namespace spec\Scriptotek\Alma\Bibs;
4
5			use PhpSpec\ObjectBehavior;
6			use Prophecy\Argument;
7			use Scriptotek\Alma\Bibs\Bib;
8			use Scriptotek\Alma\Bibs\Portfolio;
9			use Scriptotek\Alma\Bibs\Portfolios;
10			use Scriptotek\Alma\Client as AlmaClient;
11			use Scriptotek\Alma\Electronic\Collection;
12			use spec\Scriptotek\Alma\SpecHelper;
13
14			class PortfolioSpec extends ObjectBehavior
15			{
16			public function let(AlmaClient $client, Bib $bib)
17			{
18			$bib->mms_id = 'abc';
19			$portfolio_id = '123';
20			$this->beConstructedWith($client, $bib, $portfolio_id);
21			}
22
23			function it_is_initializable()
24			{
25			$this->shouldHaveType(Portfolio::class);
26			}
27
28			protected function expectRequest($client)
29			{
30			$client->getJSON('/bibs/abc/portfolios/123')
31			->shouldBeCalled()
32			->willReturn(SpecHelper::getDummyData('portfolio_response.json'));
33			}
34
35			public function it_fetches_data_when_needed(AlmaClient $client)
36			{
37			$this->expectRequest($client);
38
39			$this->availability->desc->shouldBe('Available');
			0 ignored issues – show Documentation introduced 2019-01-10 22:48 UTC by Report Bug Copy Issue Report The property `availability` does not exist on `object<spec\Scriptotek\Alma\Bibs\PortfolioSpec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
40			}
41
42			public function it_belongs_to_collection(AlmaClient $client)
43			{
44			$this->expectRequest($client);
45
46			$this->getElectronicCollection()->shouldHaveType(Collection::class);
47			$this->electronic_collection->shouldHaveType(Collection::class);
			0 ignored issues – show Documentation introduced 2019-01-10 22:48 UTC by Report Bug Copy Issue Report The property `electronic_collection` does not exist on `object<spec\Scriptotek\Alma\Bibs\PortfolioSpec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
48			}}
49

scriptotek / php-alma-client

Push — master ( 804c7f...1d2ba7 )

PortfolioSpec A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Duplication Side-by-Side

Filter issues like