RequestedResources::__construct() - Code Metrics - Inspection of "Add methods for getting task lists" - scriptotek/php-alma-client - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 99cade...32f37c )

by Dan Michael O.

created 2018-10-13 16:56 UTC

RequestedResources::__construct() A

↳ Parent: RequestedResources

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	4
dl	0
loc	8
rs	10
c	0
b	0
f	0

<?php

namespace Scriptotek\Alma\TaskLists;

use Scriptotek\Alma\Bibs\Bib;
use Scriptotek\Alma\Client;
use Scriptotek\Alma\Conf\Library;
use Scriptotek\Alma\Model\SimplePaginatedList;

class RequestedResources extends SimplePaginatedList implements \Countable, \Iterator
{
    protected $client;
    protected $library;

    /**
     * RequestedResources constructor.
     *
     * @param Client $client
     * @param Library $library
     * @param string $circ_desk
     * @param array $params
     */
    public function __construct(Client $client, Library $library, $circ_desk = 'DEFAULT_CIRC_DESK', $params = [])
    {
        parent::__construct($client, 'requested_resource');
        $this->library = $library;
        $params['library'] = $library->code;
        $params['circ_desk'] = $circ_desk;
        $this->params = $params;
    }

    /**
     * Generate the base URL for this resource.
     *
     * @return string
     */
    protected function urlBase()
    {
        return '/task-lists/requested-resources';
    }

    /**
     * Convert a data element to a resource object.
     *
     * @param $data
     * @return mixed
     */
    protected function convertToResource($data)
    {
        $bib = $this->client->bibs->get($data->resource_metadata->mms_id->value);

        return RequestedResource::make($this->client, $this->library, $this->params['circ_desk'], $bib)
            ->init($data);
    }
}


1			<?php
2
3			namespace Scriptotek\Alma\TaskLists;
4
5			use Scriptotek\Alma\Bibs\Bib;
6			use Scriptotek\Alma\Client;
7			use Scriptotek\Alma\Conf\Library;
8			use Scriptotek\Alma\Model\SimplePaginatedList;
9
10			class RequestedResources extends SimplePaginatedList implements \Countable, \Iterator
11			{
12			protected $client;
13			protected $library;
14
15			/**
16			* RequestedResources constructor.
17			*
18			* @param Client $client
19			* @param Library $library
20			* @param string $circ_desk
21			* @param array $params
22			*/
23			public function __construct(Client $client, Library $library, $circ_desk = 'DEFAULT_CIRC_DESK', $params = [])
24			{
25			parent::__construct($client, 'requested_resource');
26			$this->library = $library;
27			$params['library'] = $library->code;
28			$params['circ_desk'] = $circ_desk;
29			$this->params = $params;
30			}
31
32			/**
33			* Generate the base URL for this resource.
34			*
35			* @return string
36			*/
37			protected function urlBase()
38			{
39			return '/task-lists/requested-resources';
40			}
41
42			/**
43			* Convert a data element to a resource object.
44			*
45			* @param $data
46			* @return mixed
47			*/
48			protected function convertToResource($data)
49			{
50			$bib = $this->client->bibs->get($data->resource_metadata->mms_id->value);
51
52			return RequestedResource::make($this->client, $this->library, $this->params['circ_desk'], $bib)
53			->init($data);
54			}
55			}
56

scriptotek / php-alma-client

Push — master ( 99cade...32f37c )

RequestedResources::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like