Scriptotek\Alma\Users\Phone

Complexity

Total Complexity

2

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	setPhoneType()	0	8	2

<?php

namespace Scriptotek\Alma\Users;

use Scriptotek\Alma\Model\SettableModel;

class Phone extends SettableModel
{
    /**
     * Set the type of this phone number
     * Possible values are listed in the 'UserPhoneTypes' code table.
     *
     * @param string $phone_type The phone type
     * @param string $description The description of this phone type
     */
    public function setPhoneType($phone_type, $description = null)
    {
        $phoneTypeObj = ['value' => $phone_type];
        if ($description) {

The expression $description of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $phoneTypeObj['desc'] = $description;
        }
        $this->data->phone_type = [(object) $phoneTypeObj];
    }
}