ItemSpec::it_can_be_available() - Code Metrics - Inspection of "Rename loan() -> getLoan() for consistence" - scriptotek/php-alma-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cee823...0abcf2 )

by Dan Michael O.

created 2018-07-30 18:32 UTC

ItemSpec::it_can_be_available() A

↳ Parent: ItemSpec

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	12
Ratio	100 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	4
dl	12
loc	12
rs	9.8666
c	0
b	0
f	0

<?php

namespace spec\Scriptotek\Alma\Bibs;

use PhpSpec\ObjectBehavior;
use Psr\Http\Message\UriInterface;
use Scriptotek\Alma\Bibs\Bib;
use Scriptotek\Alma\Bibs\Holding;
use Scriptotek\Alma\Bibs\Item;
use Scriptotek\Alma\Client as AlmaClient;
use Scriptotek\Alma\Bibs\ScanInResponse;
use Scriptotek\Alma\Conf\Library;
use Scriptotek\Alma\Users\Loan;
use Scriptotek\Alma\Users\User;
use spec\Scriptotek\Alma\SpecHelper;

class ItemSpec extends ObjectBehavior
{
    public function let(AlmaClient $client, Bib $bib, Holding $holding)
    {
        $bib->mms_id = '990006312214702204';
        $holding->holding_id = '22163771200002204';
        $item_id = '23163771190002204';

        $this->beConstructedWith($client, $bib, $holding, $item_id);
    }

    public function it_is_initializable()
    {
        $this->shouldHaveType(Item::class);
    }

    function it_can_be_checked_out(AlmaClient $client, User $user, Library $library, UriInterface $url)
    {
        $client->buildUrl('/bibs/990006312214702204/holdings/22163771200002204/items/23163771190002204/loans', ['user_id' => 'Dan Michael'])
            ->willReturn($url);

        $client->postJSON($url, [
            'library' => ['value' => 'THAT LIBRARY'], 'circ_desk' => ['value' => 'DEFAULT_CIRC_DESK']])
            ->shouldBeCalled()
            ->willReturn(SpecHelper::getDummyData('create_loan_response.json'));

        $user->id = 'Dan Michael';
        $library->code = 'THAT LIBRARY';

        $this->checkOut($user, $library)
            ->shouldHaveType(Loan::class);
    }

    function it_can_be_on_loan(AlmaClient $client, User $user, Library $library, UriInterface $url)

    {
        $client->buildUrl('/bibs/990006312214702204/holdings/22163771200002204/items/23163771190002204/loans', [])
            ->willReturn($url);

        $client->getJSON($url)
            ->shouldBeCalled()
            ->willReturn(SpecHelper::getDummyData('item_loan_response.json'));

        $this->getLoan()->shouldHaveType(Loan::class);
        $this->loan->shouldHaveType(Loan::class);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    function it_can_be_available(AlmaClient $client, User $user, Library $library, UriInterface $url)

    {
        $client->buildUrl('/bibs/990006312214702204/holdings/22163771200002204/items/23163771190002204/loans', [])
            ->willReturn($url);

        $client->getJSON($url)
            ->shouldBeCalled()
            ->willReturn(SpecHelper::getDummyData('item_no_loan_response.json'));

        $this->getLoan()->shouldBe(null);
        $this->loan->shouldBe(null);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    function it_can_be_scanned_in(AlmaClient $client, Library $library, UriInterface $url)
    {
        $client->buildUrl('/bibs/990006312214702204/holdings/22163771200002204/items/23163771190002204', [
            'op' => 'scan',
            'library' => 'THAT LIBRARY',
            'circ_desk' => 'DEFAULT_CIRC_DESK',
        ])->willReturn($url);

        $client->postJSON($url)
            ->shouldBeCalled()
            ->willReturn(SpecHelper::getDummyData('scanin_transit_response.json'));

        $library->code = 'THAT LIBRARY';

        $this->scanIn($library)
            ->shouldHaveType(ScanInResponse::class);
    }
}


1		<?php
2
3		namespace spec\Scriptotek\Alma\Bibs;
4
5		use PhpSpec\ObjectBehavior;
6		use Psr\Http\Message\UriInterface;
7		use Scriptotek\Alma\Bibs\Bib;
8		use Scriptotek\Alma\Bibs\Holding;
9		use Scriptotek\Alma\Bibs\Item;
10		use Scriptotek\Alma\Client as AlmaClient;
11		use Scriptotek\Alma\Bibs\ScanInResponse;
12		use Scriptotek\Alma\Conf\Library;
13		use Scriptotek\Alma\Users\Loan;
14		use Scriptotek\Alma\Users\User;
15		use spec\Scriptotek\Alma\SpecHelper;
16
17		class ItemSpec extends ObjectBehavior
18		{
19		public function let(AlmaClient $client, Bib $bib, Holding $holding)
20		{
21		$bib->mms_id = '990006312214702204';
22		$holding->holding_id = '22163771200002204';
23		$item_id = '23163771190002204';
24
25		$this->beConstructedWith($client, $bib, $holding, $item_id);
26		}
27
28		public function it_is_initializable()
29		{
30		$this->shouldHaveType(Item::class);
31		}
32
33		function it_can_be_checked_out(AlmaClient $client, User $user, Library $library, UriInterface $url)
34		{
35		$client->buildUrl('/bibs/990006312214702204/holdings/22163771200002204/items/23163771190002204/loans', ['user_id' => 'Dan Michael'])
36		->willReturn($url);
37
38		$client->postJSON($url, [
39		'library' => ['value' => 'THAT LIBRARY'], 'circ_desk' => ['value' => 'DEFAULT_CIRC_DESK']])
40		->shouldBeCalled()
41		->willReturn(SpecHelper::getDummyData('create_loan_response.json'));
42
43		$user->id = 'Dan Michael';
44		$library->code = 'THAT LIBRARY';
45
46		$this->checkOut($user, $library)
47		->shouldHaveType(Loan::class);
48		}
49
50	View Code Duplication	function it_can_be_on_loan(AlmaClient $client, User $user, Library $library, UriInterface $url)
		0 ignored issues – show Duplication introduced 2018-07-26 20:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Unused Code introduced 2018-07-30 18:34 UTC by Report Bug Copy Issue Report The parameter `$user` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2018-07-30 18:34 UTC by Report Bug Copy Issue Report The parameter `$library` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
51		{
52		$client->buildUrl('/bibs/990006312214702204/holdings/22163771200002204/items/23163771190002204/loans', [])
53		->willReturn($url);
54
55		$client->getJSON($url)
56		->shouldBeCalled()
57		->willReturn(SpecHelper::getDummyData('item_loan_response.json'));
58
59		$this->getLoan()->shouldHaveType(Loan::class);
60		$this->loan->shouldHaveType(Loan::class);
		0 ignored issues – show Documentation introduced 2018-07-30 18:34 UTC by Report Bug Copy Issue Report The property `loan` does not exist on `object<spec\Scriptotek\Alma\Bibs\ItemSpec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
61		}
62
63	View Code Duplication	function it_can_be_available(AlmaClient $client, User $user, Library $library, UriInterface $url)
		0 ignored issues – show Unused Code introduced 2018-07-30 18:34 UTC by Report Bug Copy Issue Report The parameter `$user` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2018-07-30 18:34 UTC by Report Bug Copy Issue Report The parameter `$library` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2018-07-30 18:34 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
64		{
65		$client->buildUrl('/bibs/990006312214702204/holdings/22163771200002204/items/23163771190002204/loans', [])
66		->willReturn($url);
67
68		$client->getJSON($url)
69		->shouldBeCalled()
70		->willReturn(SpecHelper::getDummyData('item_no_loan_response.json'));
71
72		$this->getLoan()->shouldBe(null);
73		$this->loan->shouldBe(null);
		0 ignored issues – show Documentation introduced 2018-07-30 18:34 UTC by Report Bug Copy Issue Report The property `loan` does not exist on `object<spec\Scriptotek\Alma\Bibs\ItemSpec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
74		}
75
76		function it_can_be_scanned_in(AlmaClient $client, Library $library, UriInterface $url)
77		{
78		$client->buildUrl('/bibs/990006312214702204/holdings/22163771200002204/items/23163771190002204', [
79		'op' => 'scan',
80		'library' => 'THAT LIBRARY',
81		'circ_desk' => 'DEFAULT_CIRC_DESK',
82		])->willReturn($url);
83
84		$client->postJSON($url)
85		->shouldBeCalled()
86		->willReturn(SpecHelper::getDummyData('scanin_transit_response.json'));
87
88		$library->code = 'THAT LIBRARY';
89
90		$this->scanIn($library)
91		->shouldHaveType(ScanInResponse::class);
92		}
93		}
94

scriptotek / php-alma-client

Push — master ( cee823...0abcf2 )

ItemSpec::it_can_be_available() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like