JobInstancesSpec::it_provides_job_instances() - Code Metrics - Inspection of "Travis: Add PHP 7.4" - scriptotek/php-alma-client - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( e27da6...ea0580 )

by Dan Michael O.

created 2020-09-10 16:41 UTC

JobInstancesSpec::it_provides_job_instances() A

↳ Parent: JobInstancesSpec

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	1
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0

<?php

namespace spec\Scriptotek\Alma\Conf;

use PhpSpec\ObjectBehavior;
use Scriptotek\Alma\Client as AlmaClient;
use Scriptotek\Alma\Conf\Job;
use Scriptotek\Alma\Conf\JobInstance;
use spec\Scriptotek\Alma\SpecHelper;

class JobInstancesSpec extends ObjectBehavior
{
    public function let(AlmaClient $client, Job $job)
    {
        $job->job_id = '1108569450000121';
        $this->beConstructedWith($client, $job);
    }

    public function it_provides_a_lazy_interface_to_jobinstance_objects(AlmaClient $client)
    {
        SpecHelper::expectNoRequests($client);

        $jobId = '1108569450000121';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $instanceId = '1108569450000121';
        $jobInstance = $this->get($instanceId);
        $jobInstance->shouldBeAnInstanceOf(JobInstance::class);
    }

    public function it_provides_job_instances(AlmaClient $client)
    {
        $jobId = '1108569450000121';
        $client->getJSON("/conf/jobs/{$jobId}/instances?offset=0&limit=10")
            ->shouldBeCalled()
            ->willReturn(SpecHelper::getDummyData('jobinstances_response.json'));

        $this->all()->shouldBeArray();
        $this->all()[0]->shouldBeAnInstanceOf(JobInstance::class);
    }
}


1			<?php
2
3			namespace spec\Scriptotek\Alma\Conf;
4
5			use PhpSpec\ObjectBehavior;
6			use Scriptotek\Alma\Client as AlmaClient;
7			use Scriptotek\Alma\Conf\Job;
8			use Scriptotek\Alma\Conf\JobInstance;
9			use spec\Scriptotek\Alma\SpecHelper;
10
11			class JobInstancesSpec extends ObjectBehavior
12			{
13			public function let(AlmaClient $client, Job $job)
14			{
15			$job->job_id = '1108569450000121';
16			$this->beConstructedWith($client, $job);
17			}
18
19			public function it_provides_a_lazy_interface_to_jobinstance_objects(AlmaClient $client)
20			{
21			SpecHelper::expectNoRequests($client);
22
23			$jobId = '1108569450000121';
			0 ignored issues – show Unused Code introduced 2020-09-10 16:51 UTC by Report Bug Copy Issue Report `$jobId` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
24			$instanceId = '1108569450000121';
25			$jobInstance = $this->get($instanceId);
26			$jobInstance->shouldBeAnInstanceOf(JobInstance::class);
27			}
28
29			public function it_provides_job_instances(AlmaClient $client)
30			{
31			$jobId = '1108569450000121';
32			$client->getJSON("/conf/jobs/{$jobId}/instances?offset=0&limit=10")
33			->shouldBeCalled()
34			->willReturn(SpecHelper::getDummyData('jobinstances_response.json'));
35
36			$this->all()->shouldBeArray();
37			$this->all()[0]->shouldBeAnInstanceOf(JobInstance::class);
38			}
39			}
40

scriptotek / php-alma-client

Push — master ( e27da6...ea0580 )

JobInstancesSpec::it_provides_job_instances() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like