UserStatistics::getStatsByCategoryDesc() - Code Metrics - Inspection of "Add contact read/write contact info to Users" - scriptotek/php-alma-client - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#20)

unknown

created 2021-05-26 18:58 UTC

UserStatistics::getStatsByCategoryDesc() A

↳ Parent: UserStatistics

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	20
Ratio	100 %

Importance

Changes

Metric	Value
cc	3
nc	3
nop	1
dl	20
loc	20
rs	9.6
c	0
b	0
f	0

<?php

namespace Scriptotek\Alma\Users;

use Scriptotek\Alma\Client;
use Scriptotek\Alma\Model\Model;

/**
 * Iterable collection of statistics resources.
 */
class UserStatistics extends Model
{
    /**
     * Get the user's statistics.
     *
     * @return Statistic
     */
    public function getStatistics()
    {
        $stats = array();
        foreach ($this->data as $statistic) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                array_push($stats,$statistic);
        }
        return $stats;
    }

    /**
    * Get Stats By Type Code.
    *
    * @return Array of Statistics.
    */
    public function getStatsByTypeCode($typeCode)

    {
        $stats = array();
        foreach ($this->data as $statistic) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $statcat_type    = $statistic->category_type;
            $statcat_cat     = $statistic->statistic_category;
            $statcat_note    = $statistic->statistic_note;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $segment_type    = $statistic->segment_type;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            $type_code       = $statcat_type->value;
            $type_desc       = $statcat_type->desc;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $category_code   = $statcat_cat->value;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $category_desc   = $statcat_cat->desc;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            if ($type_code == $typeCode) {
                array_push($stats,$statistic);
            }
        }
        return $stats;
    } 

    /**
    * Get Stats by Type Desc.
    *
    * @return Array of statistics.
    */
    public function getStatsByTypeDesc($typeDesc)

    {
        $stats = array();
        foreach ($this->data as $statistic) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $statcat_type    = $statistic->category_type;
            $statcat_cat     = $statistic->statistic_category;
            $statcat_note    = $statistic->statistic_note;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $segment_type    = $statistic->segment_type;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            $type_code       = $statcat_type->value;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $type_desc       = $statcat_type->desc;
            $category_code   = $statcat_cat->value;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $category_desc   = $statcat_cat->desc;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            if ($type_desc == $typeDesc) {
                array_push($stats,$statistic);
            }
        }
        return $stats;
    }

    /**
    * Get Stats by Category Code.
    *
    * @return Array of Statistics.
    */
    public function getStatsByCategoryCode($categoryCode)

    {
        $stats = array();
        foreach ($this->data as $statistic) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $statcat_type    = $statistic->category_type;
            $statcat_cat     = $statistic->statistic_category;
            $statcat_note    = $statistic->statistic_note;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $segment_type    = $statistic->segment_type;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            $type_code       = $statcat_type->value;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $type_desc       = $statcat_type->desc;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $category_code   = $statcat_cat->value;
            $category_desc   = $statcat_cat->desc;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            if ($category_code == $categoryCode) {
                array_push($stats,$statistic);
            }
        }
        return $stats;
    }

    /**
    * Get Stats by Category Desc.
    *
    * @return Array of Statistics.
    */
    public function getStatsByCategoryDesc($categoryDesc)

    {
        $stats = array();
        foreach ($this->data as $statistic) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $statcat_type    = $statistic->category_type;
            $statcat_cat     = $statistic->statistic_category;
            $statcat_note    = $statistic->statistic_note;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $segment_type    = $statistic->segment_type;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            $type_code       = $statcat_type->value;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $type_desc       = $statcat_type->desc;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $category_code   = $statcat_cat->value;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $category_desc   = $statcat_cat->desc;

            if ($category_desc == $categoryDesc) {
                array_push($stats,$statistic);
            }
        }
        return $stats;
    }

    /**
    * Get Stats by Segment Type.
    *
    * @return Array of Statistics.
    */
    public function getStatsBySegmentType($segmentType)

    {
        $stats = array();
        foreach ($this->data as $statistic) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $statcat_type    = $statistic->category_type;
            $statcat_cat     = $statistic->statistic_category;
            $statcat_note    = $statistic->statistic_note;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $segment_type    = $statistic->segment_type;

            $type_code       = $statcat_type->value;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $type_desc       = $statcat_type->desc;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $category_code   = $statcat_cat->value;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $category_desc   = $statcat_cat->desc;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            if ($segment_type == $segmentType) {
                array_push($stats,$statistic);
            }
        }
        return $stats;
    }  

    /**
    * Search Stats by Note.
    *
    * @return Array of Statistics.
    */
    public function searchStatsByNote($note)

    {
        $stats = array();
        foreach ($this->data as $statistic) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $statcat_type    = $statistic->category_type;
            $statcat_cat     = $statistic->statistic_category;
            $statcat_note    = $statistic->statistic_note;
            $segment_type    = $statistic->segment_type;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            $type_code       = $statcat_type->value;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $type_desc       = $statcat_type->desc;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $category_code   = $statcat_cat->value;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $category_desc   = $statcat_cat->desc;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            if (preg_match("/$note/i", $statcat_note)) {
                array_push($stats,$statistic);
            }
        }
        return $stats;
    }

    /** 
    * Search Stats by Type Code.
    *
    * @return Array of Statistics.
    */
    public function searchStatsByTypeCode($typeCode)

    {
        $stats = array();
        foreach ($this->data as $statistic) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $statcat_type    = $statistic->category_type;
            $statcat_cat     = $statistic->statistic_category;
            $statcat_note    = $statistic->statistic_note;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $segment_type    = $statistic->segment_type;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            $type_code       = $statcat_type->value;
            $type_desc       = $statcat_type->desc;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $category_code   = $statcat_cat->value;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $category_desc   = $statcat_cat->desc;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            if (preg_match("/$typeCode/i", $type_code)) {
                array_push($stats,$statistic);
            }
        }
        return $stats;
    }

    /**
    * Search Stats by Type Code.
    *
    * @return Array of Statistics.
    */
    public function searchStatsByTypeDesc($typeDesc)

    {
        $stats = array();
        foreach ($this->data as $statistic) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $statcat_type    = $statistic->category_type;
            $statcat_cat     = $statistic->statistic_category;
            $statcat_note    = $statistic->statistic_note;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $segment_type    = $statistic->segment_type;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            $type_code       = $statcat_type->value;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $type_desc       = $statcat_type->desc;
            $category_code   = $statcat_cat->value;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $category_desc   = $statcat_cat->desc;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            if (preg_match("/$typeDesc/i", $type_desc)) {
                array_push($stats,$statistic);
            }
        }
        return $stats;
    }

    /**
    * Search Stats by Type Code.
    *
    * @return Array of Statistics.
    */
    public function searchStatsByCategoryCode($categoryCode)

    {
        $stats = array();
        foreach ($this->data as $statistic) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $statcat_type    = $statistic->category_type;
            $statcat_cat     = $statistic->statistic_category;
            $statcat_note    = $statistic->statistic_note;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $segment_type    = $statistic->segment_type;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            $type_code       = $statcat_type->value;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $type_desc       = $statcat_type->desc;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $category_code   = $statcat_cat->value;
            $category_desc   = $statcat_cat->desc;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            if (preg_match("/$categoryCode/i", $category_code)) {
                array_push($stats,$statistic);
            }
        }
        return $stats;
    }

    /**
    * Search Stats by Type Code.
    *
    * @return Array of Statistics.
    */
    public function searchStatsByCategoryDesc($categoryDesc)

    {
        $stats = array();
        foreach ($this->data as $statistic) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $statcat_type    = $statistic->category_type;
            $statcat_cat     = $statistic->statistic_category;
            $statcat_note    = $statistic->statistic_note;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $segment_type    = $statistic->segment_type;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            $type_code       = $statcat_type->value;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $type_desc       = $statcat_type->desc;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $category_code   = $statcat_cat->value;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $category_desc   = $statcat_cat->desc;

            if (preg_match("/$categoryDesc/i", $category_desc)) {
                array_push($stats,$statistic);
            }
        }
        return $stats;
    }



    /*
    public function all($status = 'ACTIVE')
    {
        $ids = [$this->data->primary_id];
        foreach ($this->data->user_identifier as $identifier) {
            if (is_null($status) || $identifier->status == $status) {
                $ids[] = $identifier->value;
            }
        }

        return $ids;
    }
    */

}


1		<?php
2
3		namespace Scriptotek\Alma\Users;
4
5		use Scriptotek\Alma\Client;
6		use Scriptotek\Alma\Model\Model;
7
8		/**
9		* Iterable collection of statistics resources.
10		*/
11		class UserStatistics extends Model
12		{
13		/**
14		* Get the user's statistics.
15		*
16		* @return Statistic
17		*/
18		public function getStatistics()
19		{
20		$stats = array();
21		foreach ($this->data as $statistic) {
		0 ignored issues – show Bug introduced 2021-05-25 18:53 UTC by Report Bug Copy Issue Report The expression `$this->data` of type `object<stdClass>\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
22		array_push($stats,$statistic);
23		}
24		return $stats;
25		}
26
27		/**
28		* Get Stats By Type Code.
29		*
30		* @return Array of Statistics.
31		*/
32	View Code Duplication	public function getStatsByTypeCode($typeCode)
		0 ignored issues – show Duplication introduced 2021-05-25 18:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
33		{
34		$stats = array();
35		foreach ($this->data as $statistic) {
		0 ignored issues – show Bug introduced 2021-05-25 18:53 UTC by Report Bug Copy Issue Report The expression `$this->data` of type `object<stdClass>\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
36		$statcat_type = $statistic->category_type;
37		$statcat_cat = $statistic->statistic_category;

scriptotek / php-alma-client

Pull Request — master (#20)

UserStatistics::getStatsByCategoryDesc() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like