Fee - Code Metrics - Inspection of "Add user fees" - scriptotek/php-alma-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9d90d4...cee823 )

by Dan Michael O.

created 2018-07-30 16:42 UTC

Fee A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	50
Duplicated Lines	100 %

Coupling/Cohesion

Components	2
Dependencies	4

Importance

Changes

Metric	Value
dl	50
loc	50
rs	10
c	0
b	0
f	0
wmc	5
lcom	2
cbo	4

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	6	6	1
A	urlBase()	4	4	1
A	isInitialized()	4	4	1
A	getItem()	8	8	2

How to fix Duplicated Code

<?php

namespace Scriptotek\Alma\Users;

use Scriptotek\Alma\Bibs\Item;
use Scriptotek\Alma\Client;
use Scriptotek\Alma\Model\LazyResource;

/**
 * A single Fee resource.
 */
class Fee extends LazyResource

{
    /* @var User */
    protected $user;

    /* @var string */
    protected $id;

    public function __construct(Client $client, User $user, $id)
    {
        parent::__construct($client);
        $this->user = $user;
        $this->id = $id;
    }

    /**
     * Generate the base URL for this resource.
     *
     * @return string
     */
    protected function urlBase()
    {
        return "/users/{$this->user->id}/fees/{$this->id}";
    }

    /**
     * Check if we have the full representation of our data object.
     *
     * @param \stdClass $data
     * @return boolean
     */
    protected function isInitialized($data)
    {
        return isset($data->link);
    }

    /**
     * Get the related Item, if any.
     *
     * @return Item|null
     */
    public function getItem()
    {
        if (isset($this->barcode)) {
            return $this->client->items->fromBarcode($this->barcode);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }

        return null;
    }
}


1		<?php
2
3		namespace Scriptotek\Alma\Users;
4
5		use Scriptotek\Alma\Bibs\Item;
6		use Scriptotek\Alma\Client;
7		use Scriptotek\Alma\Model\LazyResource;
8
9		/**
10		* A single Fee resource.
11		*/
12	View Code Duplication	class Fee extends LazyResource
		0 ignored issues – show Duplication introduced 2018-07-30 16:45 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13		{
14		/* @var User */
15		protected $user;
16
17		/* @var string */
18		protected $id;
19
20		public function __construct(Client $client, User $user, $id)
21		{
22		parent::__construct($client);
23		$this->user = $user;
24		$this->id = $id;
25		}
26
27		/**
28		* Generate the base URL for this resource.
29		*
30		* @return string
31		*/
32		protected function urlBase()
33		{
34		return "/users/{$this->user->id}/fees/{$this->id}";
35		}
36
37		/**
38		* Check if we have the full representation of our data object.
39		*
40		* @param \stdClass $data
41		* @return boolean
42		*/
43		protected function isInitialized($data)
44		{
45		return isset($data->link);
46		}
47
48		/**
49		* Get the related Item, if any.
50		*
51		* @return Item\|null
52		*/
53		public function getItem()
54		{
55		if (isset($this->barcode)) {
56		return $this->client->items->fromBarcode($this->barcode);
		0 ignored issues – show Documentation introduced 2018-07-30 16:45 UTC by Report Bug Copy Issue Report The property `barcode` does not exist on `object<Scriptotek\Alma\Users\Fee>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
57		}
58
59		return null;
60		}
61		}
62

scriptotek / php-alma-client

Push — master ( 9d90d4...cee823 )

Fee A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like