Scriptotek\Alma\Users\UserIdentifiers

Complexity

Total Complexity

21

Size/Duplication

Total Lines	120
Duplicated Lines	17.5 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	all()	11	11	4
A	allOfType()	10	10	5
A	firstOfType()	0	8	5
A	getBarcode()	0	4	1
A	getBarcodes()	0	4	1
A	getUniversityId()	0	4	1
A	getUniversityIds()	0	4	1
A	__get()	0	7	2

<?php

namespace Scriptotek\Alma\Users;

class UserIdentifiers
{
    /* @var string */
    protected $id;

    /* @var \stdClass */
    protected $data;

    /**
     * UserIdentifiers constructor.
     *
     * @param \stdClass   $data
     */
    public function __construct($id, $data = null)
    {
        $this->id = $id;
        $this->data = $data ?? [];

It seems like $data ?? array() can also be of type array. However, the property $data is declared as type object<stdClass>. Maybe add an additional type check?

    }

    /**
     * Get a flat array of all the user IDs.
     *
     * @param string $status (Default: 'ACTIVE').
     *
     * @return string[]
     */
    public function all($status='ACTIVE')

This method seems to be duplicated in your project.

    {
        $ids = [$this->id];
        foreach ($this->data as $identifier) {

The expression $this->data of type object<stdClass> is not traversable.

            if (is_null($status) || $identifier->status == $status) {
                $ids[] = $identifier->value;
            }
        }

        return $ids;
    }

    /**
     * Get all active user identifiers of a given type, like 'BARCODE' or 'UNIV_ID'.
     *
     * @param string $value
     *
     * @return null|string
     */
    public function allOfType($value, $status = 'ACTIVE')

This method seems to be duplicated in your project.

    {
        $ids = [];
        foreach ($this->data as $identifier) {

The expression $this->data of type object<stdClass> is not traversable.

            if ($identifier->id_type->value == $value && (is_null($status) || $identifier->status == $status)) {
                $ids[] = $identifier->value;
            }
        }
        return $ids;
    }

    /**
     * Get the first active user identifier of a given type, like 'BARCODE' or 'UNIV_ID'.
     *
     * @param string $value
     *
     * @return null|string
     */
    public function firstOfType($value, $status = 'ACTIVE')
    {
        foreach ($this->data as $identifier) {

The expression $this->data of type object<stdClass> is not traversable.

            if ($identifier->id_type->value == $value && (is_null($status) || $identifier->status == $status)) {
                return $identifier->value;
            }
        }
    }

    /**
     * Get the first active barcode.
     *
     * @return null|string
     */
    public function getBarcode()
    {
        return $this->firstOfType('BARCODE');
    }

    /**
     * Get all active barcodes.
     *
     * @return string[]
     */
    public function getBarcodes()
    {
        return $this->allOfType('BARCODE');
    }

    /**
     * Get the first active university id.
     *
     * @return null|string
     */
    public function getUniversityId()
    {
        return $this->firstOfType('UNIV_ID');
    }

    /**
     * Get all active university ids.
     *
     * @return string[]
     */
    public function getUniversityIds()
    {
        return $this->allOfType('UNIV_ID');
    }

    public function __get($key)
    {
        $method = 'get' . ucfirst($key);
        if (method_exists($this, $method)) {
            return $this->$method();
        }
    }
}