UserSpec::it_can_change_sms() - Code Metrics - Inspection of "Enable save() method for User and enable SMS manip..." - scriptotek/php-alma-client - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 2f310d...e27da6 )

by Dan Michael O.

created 2020-09-10 15:11 UTC

UserSpec::it_can_change_sms() A

↳ Parent: UserSpec

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	5
rs	10
c	0
b	0
f	0

<?php

namespace spec\Scriptotek\Alma\Users;

use PhpSpec\ObjectBehavior;
use Scriptotek\Alma\Client as AlmaClient;
use Scriptotek\Alma\Users\Fees;
use Scriptotek\Alma\Users\Loans;
use Scriptotek\Alma\Users\Requests;
use Scriptotek\Alma\Users\User;
use spec\Scriptotek\Alma\SpecHelper;

class UserSpec extends ObjectBehavior
{
    public function let(AlmaClient $client)
    {
        $this->beConstructedWith($client, '12345');

        $client->getJSON('/users/12345')
            ->willReturn(SpecHelper::getDummyData('user_response.json'));
    }

    public function it_is_initializable()
    {
        $this->shouldHaveType(User::class);
    }

    public function it_has_primary_id()
    {
        $this->primaryId->shouldBe('12345');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function it_has_barcode()
    {
        $this->barcode->shouldBe('ub54321');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function it_has_barcodes()
    {
        $this->barcodes->shouldBe(['ub54321', 'ntb12897787']);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function it_has_university_id()
    {
        $this->universityId->shouldBe('[email protected]');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function it_has_university_ids()
    {
        $this->universityIds->shouldBe(['[email protected]']);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function it_has_identifiers()
    {
        $this->identifiers->all()->shouldBe(['12345', 'ub54321', 'ntb12897787', '[email protected]']);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function it_has_loans(AlmaClient $client)
    {
        SpecHelper::expectNoRequests($client);
        $this->loans->shouldHaveType(Loans::class);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function it_has_fees(AlmaClient $client)
    {
        SpecHelper::expectNoRequests($client);
        $this->fees->shouldHaveType(Fees::class);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function it_has_requests()
    {
        $this->requests->shouldHaveType(Requests::class);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function it_has_sms()
    {
        $this->getSmsNumber()->shouldBe('87654321');
    }
    
    public function it_can_change_sms()
    {
        $this->setSmsNumber('12345678')->shouldBeCalled();
        $this->getSmsNumber()->shouldBe('12345678');
    }

    public function it_can_add_sms()
    {
        $this->setSmsNumber('9999999')->shouldBeCalled();
        $this->getSmsNumber()->shouldBe('9999999');
    }

    public function it_can_remove_sms()
    {
        $this->unsetSmsNumber()->shouldBeCalled();
        $this->getSmsNumber()->shouldBe(null);
    }

}


1			<?php
2
3			namespace spec\Scriptotek\Alma\Users;
4
5			use PhpSpec\ObjectBehavior;
6			use Scriptotek\Alma\Client as AlmaClient;
7			use Scriptotek\Alma\Users\Fees;
8			use Scriptotek\Alma\Users\Loans;
9			use Scriptotek\Alma\Users\Requests;
10			use Scriptotek\Alma\Users\User;
11			use spec\Scriptotek\Alma\SpecHelper;
12
13			class UserSpec extends ObjectBehavior
14			{
15			public function let(AlmaClient $client)
16			{
17			$this->beConstructedWith($client, '12345');
18
19			$client->getJSON('/users/12345')
20			->willReturn(SpecHelper::getDummyData('user_response.json'));
21			}
22
23			public function it_is_initializable()
24			{
25			$this->shouldHaveType(User::class);
26			}
27
28			public function it_has_primary_id()
29			{
30			$this->primaryId->shouldBe('12345');
			0 ignored issues – show Documentation introduced 2018-07-12 13:46 UTC by Report Bug Copy Issue Report The property `primaryId` does not exist on `object<spec\Scriptotek\Alma\Users\UserSpec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
31			}
32
33			public function it_has_barcode()
34			{
35			$this->barcode->shouldBe('ub54321');
			0 ignored issues – show Documentation introduced 2018-07-12 13:46 UTC by Report Bug Copy Issue Report The property `barcode` does not exist on `object<spec\Scriptotek\Alma\Users\UserSpec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
36			}
37
38			public function it_has_barcodes()
39			{
40			$this->barcodes->shouldBe(['ub54321', 'ntb12897787']);
			0 ignored issues – show Documentation introduced 2018-07-12 13:46 UTC by Report Bug Copy Issue Report The property `barcodes` does not exist on `object<spec\Scriptotek\Alma\Users\UserSpec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
41			}
42
43			public function it_has_university_id()
44			{
45			$this->universityId->shouldBe('[email protected]');
			0 ignored issues – show Documentation introduced 2018-07-12 13:46 UTC by Report Bug Copy Issue Report The property `universityId` does not exist on `object<spec\Scriptotek\Alma\Users\UserSpec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
46			}
47
48			public function it_has_university_ids()
49			{
50			$this->universityIds->shouldBe(['[email protected]']);
			0 ignored issues – show Documentation introduced 2018-07-12 13:46 UTC by Report Bug Copy Issue Report The property `universityIds` does not exist on `object<spec\Scriptotek\Alma\Users\UserSpec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
51			}
52
53			public function it_has_identifiers()
54			{
55			$this->identifiers->all()->shouldBe(['12345', 'ub54321', 'ntb12897787', '[email protected]']);
			0 ignored issues – show Documentation introduced 2018-07-12 13:46 UTC by Report Bug Copy Issue Report The property `identifiers` does not exist on `object<spec\Scriptotek\Alma\Users\UserSpec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
56			}
57
58			public function it_has_loans(AlmaClient $client)
59			{
60			SpecHelper::expectNoRequests($client);
61			$this->loans->shouldHaveType(Loans::class);
			0 ignored issues – show Documentation introduced 2018-07-29 16:25 UTC by Report Bug Copy Issue Report The property `loans` does not exist on `object<spec\Scriptotek\Alma\Users\UserSpec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
62			}
63
64			public function it_has_fees(AlmaClient $client)
65			{
66			SpecHelper::expectNoRequests($client);
67			$this->fees->shouldHaveType(Fees::class);
			0 ignored issues – show Documentation introduced 2018-07-30 16:45 UTC by Report Bug Copy Issue Report The property `fees` does not exist on `object<spec\Scriptotek\Alma\Users\UserSpec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
68			}
69
70			public function it_has_requests()
71			{
72			$this->requests->shouldHaveType(Requests::class);
			0 ignored issues – show Documentation introduced 2018-07-31 22:20 UTC by Report Bug Copy Issue Report The property `requests` does not exist on `object<spec\Scriptotek\Alma\Users\UserSpec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
73			}
74
75			public function it_has_sms()
76			{
77			$this->getSmsNumber()->shouldBe('87654321');
78			}
79
80			public function it_can_change_sms()
81			{
82			$this->setSmsNumber('12345678')->shouldBeCalled();
83			$this->getSmsNumber()->shouldBe('12345678');
84			}
85
86			public function it_can_add_sms()
87			{
88			$this->setSmsNumber('9999999')->shouldBeCalled();
89			$this->getSmsNumber()->shouldBe('9999999');
90			}
91
92			public function it_can_remove_sms()
93			{
94			$this->unsetSmsNumber()->shouldBeCalled();
95			$this->getSmsNumber()->shouldBe(null);
96			}
97
98			}
99

scriptotek / php-alma-client

Push — master ( 2f310d...e27da6 )

UserSpec::it_can_change_sms() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like