BibSpec - Code Metrics - Inspection of "Fix Bib::save()" - scriptotek/php-alma-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0abcf2...c12050 )

by Dan Michael O.

created 2018-07-30 20:36 UTC

BibSpec A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	90
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

Metric	Value
dl	0
loc	90
rs	10
c	0
b	0
f	0
wmc	10
lcom	1
cbo	5

10 Methods

Rating	Name	Size	Complexity
A	it_is_lazy()	5	1
A	it_loads_bib_data_when_needed()	6	1
A	it_links_to_network_zone()	12	1
A	it_provides_lazy_access_to_holdings()	5	1
A	it_has_a_MARC_record()	7	1
A	it_catches_resource_not_found()	12	1
A	let()	4	1
A	expectRequest()	10	1
A	it_can_exist()	6	1
A	it_can_be_edited()	11	1

<?php

namespace spec\Scriptotek\Alma\Bibs;

use PhpSpec\ObjectBehavior;
use Prophecy\Argument;
use Psr\Http\Message\UriInterface;
use Scriptotek\Alma\Bibs\Bib;
use Scriptotek\Alma\Bibs\Bibs;
use Scriptotek\Alma\Bibs\Holding;
use Scriptotek\Alma\Bibs\Holdings;
use Scriptotek\Alma\Client as AlmaClient;
use Scriptotek\Alma\Exception\ResourceNotFound;
use Scriptotek\Marc\Record;
use spec\Scriptotek\Alma\SpecHelper;

class BibSpec extends ObjectBehavior
{
    public function let(AlmaClient $client, UriInterface $url)

    {
        $this->beConstructedWith($client, '999104760474702204');
    }

    protected function expectRequest($client, $url)
    {
        $client->buildUrl('/bibs/999104760474702204', [])
            ->shouldBeCalled()
            ->willReturn($url);

        $client->getXML($url)
            ->shouldBeCalled()
            ->willReturn(SpecHelper::getDummyData('bib_response_iz.xml'));
    }

    public function it_is_lazy(AlmaClient $client)
    {
        SpecHelper::expectNoRequests($client);
        $this->shouldHaveType(Bib::class);
    }

    public function it_loads_bib_data_when_needed(AlmaClient $client, UriInterface $url)
    {
        $this->expectRequest($client, $url);

        $this->created_date->shouldBe('2015-11-05Z');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function it_can_exist(AlmaClient $client, UriInterface $url)
    {
        $this->expectRequest($client, $url);

        $this->exists()->shouldBe(true);
    }

    public function it_links_to_network_zone(AlmaClient $client, AlmaClient $nz, Bibs $bibs, Bib $nz_bib, UriInterface $url)
    {
        $this->expectRequest($client, $url);

        $client->nz = $nz;
        $nz->bibs = $bibs;
        $bibs->get('999104760474702201')
            ->shouldBeCalled()
            ->willReturn($nz_bib);

        $this->getNzRecord()->shouldHaveType(Bib::class);
    }

    public function it_provides_lazy_access_to_holdings(AlmaClient $client)
    {
        SpecHelper::expectNoRequests($client);
        $this->holdings->shouldHaveType(Holdings::class);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function it_has_a_MARC_record(AlmaClient $client, UriInterface $url)
    {
        $this->expectRequest($client, $url);

        $this->record->shouldHaveType(Record::class);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->record->getField('245')->getSubfield('a')->getData()->shouldBe('Lonely hearts of the cosmos :');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function it_can_be_edited(AlmaClient $client, UriInterface $url)
    {
        $this->expectRequest($client, $url);

        $this->record->getField('245')->getSubfield('a')->setData('New title');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $client->putXML($url, Argument::containingString('New title'))
            ->shouldBeCalled();

        $this->save();
    }

    public function it_catches_resource_not_found(AlmaClient $client, UriInterface $url)
    {
        $client->buildUrl('/bibs/999104760474702204', [])
            ->shouldBeCalled()
            ->willReturn($url);

        $client->getXML($url)
            ->shouldBeCalled()
            ->willThrow(ResourceNotFound::class);

        $this->exists()->shouldBe(false);
    }
}


1			<?php
2
3			namespace spec\Scriptotek\Alma\Bibs;
4
5			use PhpSpec\ObjectBehavior;
6			use Prophecy\Argument;
7			use Psr\Http\Message\UriInterface;
8			use Scriptotek\Alma\Bibs\Bib;
9			use Scriptotek\Alma\Bibs\Bibs;
10			use Scriptotek\Alma\Bibs\Holding;
11			use Scriptotek\Alma\Bibs\Holdings;
12			use Scriptotek\Alma\Client as AlmaClient;
13			use Scriptotek\Alma\Exception\ResourceNotFound;
14			use Scriptotek\Marc\Record;
15			use spec\Scriptotek\Alma\SpecHelper;
16
17			class BibSpec extends ObjectBehavior
18			{
19			public function let(AlmaClient $client, UriInterface $url)
			0 ignored issues – show Unused Code introduced 2018-07-26 20:14 UTC by Report Bug Copy Issue Report The parameter `$url` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
20			{
21			$this->beConstructedWith($client, '999104760474702204');
22			}
23
24			protected function expectRequest($client, $url)
25			{
26			$client->buildUrl('/bibs/999104760474702204', [])
27			->shouldBeCalled()
28			->willReturn($url);
29
30			$client->getXML($url)
31			->shouldBeCalled()
32			->willReturn(SpecHelper::getDummyData('bib_response_iz.xml'));
33			}
34
35			public function it_is_lazy(AlmaClient $client)
36			{
37			SpecHelper::expectNoRequests($client);
38			$this->shouldHaveType(Bib::class);
39			}
40
41			public function it_loads_bib_data_when_needed(AlmaClient $client, UriInterface $url)
42			{
43			$this->expectRequest($client, $url);
44
45			$this->created_date->shouldBe('2015-11-05Z');
			0 ignored issues – show Documentation introduced 2017-04-16 18:39 UTC by Report Bug Copy Issue Report The property `created_date` does not exist on `object<spec\Scriptotek\Alma\Bibs\BibSpec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
46			}
47
48			public function it_can_exist(AlmaClient $client, UriInterface $url)
49			{
50			$this->expectRequest($client, $url);
51
52			$this->exists()->shouldBe(true);
53			}
54
55			public function it_links_to_network_zone(AlmaClient $client, AlmaClient $nz, Bibs $bibs, Bib $nz_bib, UriInterface $url)
56			{
57			$this->expectRequest($client, $url);
58
59			$client->nz = $nz;
60			$nz->bibs = $bibs;
61			$bibs->get('999104760474702201')
62			->shouldBeCalled()
63			->willReturn($nz_bib);
64
65			$this->getNzRecord()->shouldHaveType(Bib::class);
66			}
67
68			public function it_provides_lazy_access_to_holdings(AlmaClient $client)
69			{
70			SpecHelper::expectNoRequests($client);
71			$this->holdings->shouldHaveType(Holdings::class);
			0 ignored issues – show Documentation introduced 2017-04-16 18:39 UTC by Report Bug Copy Issue Report The property `holdings` does not exist on `object<spec\Scriptotek\Alma\Bibs\BibSpec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
72			}
73
74			public function it_has_a_MARC_record(AlmaClient $client, UriInterface $url)
75			{
76			$this->expectRequest($client, $url);
77
78			$this->record->shouldHaveType(Record::class);
			0 ignored issues – show Documentation introduced 2017-04-16 18:39 UTC by Report Bug Copy Issue Report The property `record` does not exist on `object<spec\Scriptotek\Alma\Bibs\BibSpec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
79			$this->record->getField('245')->getSubfield('a')->getData()->shouldBe('Lonely hearts of the cosmos :');
			0 ignored issues – show Documentation introduced 2017-04-16 18:39 UTC by Report Bug Copy Issue Report The property `record` does not exist on `object<spec\Scriptotek\Alma\Bibs\BibSpec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
80			}
81
82			public function it_can_be_edited(AlmaClient $client, UriInterface $url)
83			{
84			$this->expectRequest($client, $url);
85
86			$this->record->getField('245')->getSubfield('a')->setData('New title');
			0 ignored issues – show Documentation introduced 2016-11-25 20:06 UTC by Report Bug Copy Issue Report The property `record` does not exist on `object<spec\Scriptotek\Alma\Bibs\BibSpec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
87
88			$client->putXML($url, Argument::containingString('New title'))
89			->shouldBeCalled();
90
91			$this->save();
92			}
93
94			public function it_catches_resource_not_found(AlmaClient $client, UriInterface $url)
95			{
96			$client->buildUrl('/bibs/999104760474702204', [])
97			->shouldBeCalled()
98			->willReturn($url);
99
100			$client->getXML($url)
101			->shouldBeCalled()
102			->willThrow(ResourceNotFound::class);
103
104			$this->exists()->shouldBe(false);
105			}
106			}
107

scriptotek / php-alma-client

Push — master ( 0abcf2...c12050 )

BibSpec A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

10 Methods

Duplication Side-by-Side

Filter issues like