Code Duplication - scriptotek/php-alma-client - Measure and Improve Code Quality continuously with Scrutinizer

Code Duplication Length = 56-57 lines in 3 locations

src/Bibs/Holdings.php 1 location


/**
 * Iterable collection of Holding resources belonging to some Bib resource.
 */
class Holdings extends LazyResourceList implements \Countable, \Iterator, \ArrayAccess
{
    use ReadOnlyArrayAccess;
    use IterableCollection;

    /**
     * The Bib this Holdings list belongs to.
     *
     * @var Bib
     */
    public $bib;

    /**
     * Holdings constructor.
     *
     * @param Client $client
     * @param Bib $bib
     */
    public function __construct(Client $client, Bib $bib)
    {
        parent::__construct($client, 'holding');
        $this->bib = $bib;
    }

    /**
     * Get a single holding record by id.
     *
     * @param string $holding_id
     * @return Holding
     */
    public function get($holding_id)
    {
        return Holding::make($this->client, $this->bib, $holding_id);
    }

    /**
     * Convert a data element to a resource object.
     *
     * @param $data
     * @return Holding
     */
    protected function convertToResource($data)
    {
        return Holding::make($this->client, $this->bib, $data->holding_id)
            ->init($data);
    }

    /**
     * Generate the base URL for this resource.
     *
     * @return string
     */
    protected function urlBase()
    {
        return "/bibs/{$this->bib->mms_id}/holdings";
    }
}


src/Conf/Locations.php 1 location


/**
 * Iterable collection of Location resources.
 */
class Locations extends LazyResourceList implements \ArrayAccess, \Countable, \Iterator
{
    use ReadOnlyArrayAccess;
    use IterableCollection;

    /**
     * The Library this Locations list belongs to.
     *
     * @var Library
     */
    protected $library;

    /**
     * Locations constructor.
     *
     * @param Client $client
     * @param Library $library
     */
    public function __construct(Client $client, Library $library)
    {
        parent::__construct($client, 'location');
        $this->library = $library;
    }

    /**
     * Get a single location by its location code.
     *
     * @param string $code
     * @return Location
     */
    public function get($code)
    {
        return Location::make($this->client, $this->library, $code);
    }

    /**
     * Convert a data element to a resource object.
     *
     * @param $data
     * @return Location
     */
    protected function convertToResource($data)
    {
        return Location::make($this->client, $this->library, $data->code)
            ->init($data);
    }

    /**
     * Generate the base URL for this resource.
     *
     * @return string
     */
    protected function urlBase()
    {
        return "/conf/libraries/{$this->library->code}/locations";
    }
}


src/Users/Fees.php 1 location


/**
 * Iterable collection of Fee resources.
 */
class Fees extends LazyResourceList implements \Countable, \Iterator, \ArrayAccess
{
    use ReadOnlyArrayAccess;
    use IterableCollection;

    /**
     * The User object this Fees list belongs to.
     *
     * @var User
     */
    public $user;

    /**
     * Fees constructor.
     *
     * @param Client $client
     * @param User $user
     */
    public function __construct(Client $client, User $user)
    {
        parent::__construct($client, 'fee');
        $this->user = $user;
    }

    /**
     * Get a single Fee by id.
     *
     * @param string $id
     * @return Fee
     */
    public function get($id)
    {
        return Fee::make($this->client, $this->user, $id);
    }

    /**
     * Convert a retrieved resource object to a model object.
     *
     * @param $data
     * @return Fee
     */
    public function convertToResource($data)
    {
        return $this->get($data->id)->init($data);
    }

    /**
     * Generate the base URL for this resource.
     *
     * @return string
     */
    protected function urlBase()
    {
        return "/users/{$this->user->id}/fees";
    }
}


		@@ 13-69 (lines=57) @@
10		/**
11		* Iterable collection of Holding resources belonging to some Bib resource.
12		*/
13		class Holdings extends LazyResourceList implements \Countable, \Iterator, \ArrayAccess
14		{
15		use ReadOnlyArrayAccess;
16		use IterableCollection;
17
18		/**
19		* The Bib this Holdings list belongs to.
20		*
21		* @var Bib
22		*/
23		public $bib;
24
25		/**
26		* Holdings constructor.
27		*
28		* @param Client $client
29		* @param Bib $bib
30		*/
31		public function __construct(Client $client, Bib $bib)
32		{
33		parent::__construct($client, 'holding');
34		$this->bib = $bib;
35		}
36
37		/**
38		* Get a single holding record by id.
39		*
40		* @param string $holding_id
41		* @return Holding
42		*/
43		public function get($holding_id)
44		{
45		return Holding::make($this->client, $this->bib, $holding_id);
46		}
47
48		/**
49		* Convert a data element to a resource object.
50		*
51		* @param $data
52		* @return Holding
53		*/
54		protected function convertToResource($data)
55		{
56		return Holding::make($this->client, $this->bib, $data->holding_id)
57		->init($data);
58		}
59
60		/**
61		* Generate the base URL for this resource.
62		*
63		* @return string
64		*/
65		protected function urlBase()
66		{
67		return "/bibs/{$this->bib->mms_id}/holdings";
68		}
69		}
70

		@@ 13-69 (lines=57) @@
10		/**
11		* Iterable collection of Location resources.
12		*/
13		class Locations extends LazyResourceList implements \ArrayAccess, \Countable, \Iterator
14		{
15		use ReadOnlyArrayAccess;
16		use IterableCollection;
17
18		/**
19		* The Library this Locations list belongs to.
20		*
21		* @var Library
22		*/
23		protected $library;
24
25		/**
26		* Locations constructor.
27		*
28		* @param Client $client
29		* @param Library $library
30		*/
31		public function __construct(Client $client, Library $library)
32		{
33		parent::__construct($client, 'location');
34		$this->library = $library;
35		}
36
37		/**
38		* Get a single location by its location code.
39		*
40		* @param string $code
41		* @return Location
42		*/
43		public function get($code)
44		{
45		return Location::make($this->client, $this->library, $code);
46		}
47
48		/**
49		* Convert a data element to a resource object.
50		*
51		* @param $data
52		* @return Location
53		*/
54		protected function convertToResource($data)
55		{
56		return Location::make($this->client, $this->library, $data->code)
57		->init($data);
58		}
59
60		/**
61		* Generate the base URL for this resource.
62		*
63		* @return string
64		*/
65		protected function urlBase()
66		{
67		return "/conf/libraries/{$this->library->code}/locations";
68		}
69		}
70

		@@ 13-68 (lines=56) @@
10		/**
11		* Iterable collection of Fee resources.
12		*/
13		class Fees extends LazyResourceList implements \Countable, \Iterator, \ArrayAccess
14		{
15		use ReadOnlyArrayAccess;
16		use IterableCollection;
17
18		/**
19		* The User object this Fees list belongs to.
20		*
21		* @var User
22		*/
23		public $user;
24
25		/**
26		* Fees constructor.
27		*
28		* @param Client $client
29		* @param User $user
30		*/
31		public function __construct(Client $client, User $user)
32		{
33		parent::__construct($client, 'fee');
34		$this->user = $user;
35		}
36
37		/**
38		* Get a single Fee by id.
39		*
40		* @param string $id
41		* @return Fee
42		*/
43		public function get($id)
44		{
45		return Fee::make($this->client, $this->user, $id);
46		}
47
48		/**
49		* Convert a retrieved resource object to a model object.
50		*
51		* @param $data
52		* @return Fee
53		*/
54		public function convertToResource($data)
55		{
56		return $this->get($data->id)->init($data);
57		}
58
59		/**
60		* Generate the base URL for this resource.
61		*
62		* @return string
63		*/
64		protected function urlBase()
65		{
66		return "/users/{$this->user->id}/fees";
67		}
68		}
69

scriptotek / php-alma-client

Code Duplication Length = 56-57 lines in 3 locations

src/Bibs/Holdings.php 1 location

src/Conf/Locations.php 1 location

src/Users/Fees.php 1 location