for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
namespace spec\Scriptotek\Alma\Conf;
use PhpSpec\ObjectBehavior;
use Scriptotek\Alma\Client as AlmaClient;
use Scriptotek\Alma\Conf\Job;
use Scriptotek\Alma\Conf\JobInstance;
use spec\Scriptotek\Alma\SpecHelper;
class JobInstancesSpec extends ObjectBehavior
{
public function let(AlmaClient $client, Job $job)
$job->job_id = '1108569450000121';
$this->beConstructedWith($client, $job);
}
public function it_provides_a_lazy_interface_to_jobinstance_objects(AlmaClient $client)
SpecHelper::expectNoRequests($client);
$jobId = '1108569450000121';
$jobId
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
$myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; }
Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.
$myVar
$higher
$instanceId = '1108569450000121';
$jobInstance = $this->get($instanceId);
$jobInstance->shouldBeAnInstanceOf(JobInstance::class);
public function it_provides_job_instances(AlmaClient $client)
$client->getJSON("/conf/jobs/{$jobId}/instances?offset=0&limit=10")
->shouldBeCalled()
->willReturn(SpecHelper::getDummyData('jobinstances_response.json'));
$this->all()->shouldBeArray();
$this->all()[0]->shouldBeAnInstanceOf(JobInstance::class);
scriptotek /
php-alma-client
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.