Loan::getItem() - Code Metrics - scriptotek/php-alma-client - Measure and Improve Code Quality continuously with Scrutinizer

Loan::getItem() A
last analyzed 2021-04-14 14:57 UTC

↳ Parent: Loan

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	4
Ratio	100 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	4
loc	4
rs	10
c	0
b	0
f	0

<?php

namespace Scriptotek\Alma\Users;

use Scriptotek\Alma\Bibs\Item;
use Scriptotek\Alma\Client;
use Scriptotek\Alma\Model\LazyResource;

/**
 * A single Loan resource.
 */
class Loan extends LazyResource

{
    /* @var User */
    protected $user;

    /* @var string */
    protected $loan_id;

    public function __construct(Client $client, User $user, $loan_id)
    {
        parent::__construct($client);
        $this->user = $user;
        $this->loan_id = $loan_id;
    }

    /**
     * Generate the base URL for this resource.
     *
     * @return string
     */
    protected function urlBase()
    {
        return sprintf('/users/%s/loans/%s', rawurlencode($this->user->id), $this->loan_id);
    }

    /**
     * Check if we have the full representation of our data object.
     *
     * @param \stdClass $data
     *
     * @return bool
     */
    protected function isInitialized($data)
    {
        return isset($data->loan_id);
    }

    /**
     * Get the Item on loan. Since the response from the loan(s) API does not
     * include the `holding_id` and `item_pid`, we cannot initiate an Item object
     * directly, so we have to lookup the barcode instead.
     *
     * @see https://developers.exlibrisgroup.com/discussions#!/forum/posts/list/1397.page
     *
     * @return Item
     */
    public function getItem()
    {
        return $this->client->items->fromBarcode($this->item_barcode);
    }
}


1		<?php
2
3		namespace Scriptotek\Alma\Users;
4
5		use Scriptotek\Alma\Bibs\Item;
6		use Scriptotek\Alma\Client;
7		use Scriptotek\Alma\Model\LazyResource;
8
9		/**
10		* A single Loan resource.
11		*/
12	View Code Duplication	class Loan extends LazyResource
		0 ignored issues – show Duplication introduced 2018-07-30 16:45 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13		{
14		/* @var User */
15		protected $user;
16
17		/* @var string */
18		protected $loan_id;
19
20		public function __construct(Client $client, User $user, $loan_id)
21		{
22		parent::__construct($client);
23		$this->user = $user;
24		$this->loan_id = $loan_id;
25		}
26
27		/**
28		* Generate the base URL for this resource.
29		*
30		* @return string
31		*/
32		protected function urlBase()
33		{
34		return sprintf('/users/%s/loans/%s', rawurlencode($this->user->id), $this->loan_id);
35		}
36
37		/**
38		* Check if we have the full representation of our data object.
39		*
40		* @param \stdClass $data
41		*
42		* @return bool
43		*/
44		protected function isInitialized($data)
45		{
46		return isset($data->loan_id);
47		}
48
49		/**
50		* Get the Item on loan. Since the response from the loan(s) API does not
51		* include the `holding_id` and `item_pid`, we cannot initiate an Item object
52		* directly, so we have to lookup the barcode instead.
53		*
54		* @see https://developers.exlibrisgroup.com/discussions#!/forum/posts/list/1397.page
55		*
56		* @return Item
57		*/
58		public function getItem()
59		{
60		return $this->client->items->fromBarcode($this->item_barcode);
61		}
62		}
63

scriptotek / php-alma-client

Loan::getItem() A last analyzed 2021-04-14 14:57 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Loan::getItem() A
last analyzed 2021-04-14 14:57 UTC