ReadOnlyArrayAccess::offsetExists() - Code Metrics - scriptotek/php-alma-client - Measure and Improve Code Quality continuously with Scrutinizer

ReadOnlyArrayAccess::offsetExists() A
last analyzed 2021-04-14 14:57 UTC

↳ Parent: ReadOnlyArrayAccess

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	1
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

namespace Scriptotek\Alma\Model;

trait ReadOnlyArrayAccess
{
    public function offsetSet($offset, $value)

    {
        throw \Exception('Not implemented');
    }

    public function offsetUnset($offset)

    {
        throw \Exception('Not implemented');
    }

    public function offsetExists($offset)
    {
        return $this->get($offset)->exists();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function offsetGet($offset)
    {
        return $this->get($offset);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			namespace Scriptotek\Alma\Model;
4
5			trait ReadOnlyArrayAccess
6			{
7			public function offsetSet($offset, $value)
			0 ignored issues – show Unused Code introduced 2018-07-26 20:14 UTC by Report Bug Copy Issue Report The parameter `$offset` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2018-07-26 20:14 UTC by Report Bug Copy Issue Report The parameter `$value` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
8			{
9			throw \Exception('Not implemented');
10			}
11
12			public function offsetUnset($offset)
			0 ignored issues – show Unused Code introduced 2018-07-26 20:14 UTC by Report Bug Copy Issue Report The parameter `$offset` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
13			{
14			throw \Exception('Not implemented');
15			}
16
17			public function offsetExists($offset)
18			{
19			return $this->get($offset)->exists();
			0 ignored issues – show Bug introduced 2018-07-26 20:14 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
20			}
21
22			public function offsetGet($offset)
23			{
24			return $this->get($offset);
			0 ignored issues – show Bug introduced 2018-07-26 20:14 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
25			}
26			}
27

scriptotek / php-alma-client

ReadOnlyArrayAccess::offsetExists() A last analyzed 2021-04-14 14:57 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ReadOnlyArrayAccess::offsetExists() A
last analyzed 2021-04-14 14:57 UTC