FeesSpec - Code Metrics - scriptotek/php-alma-client - Measure and Improve Code Quality continuously with Scrutinizer

FeesSpec A
last analyzed 2021-04-14 14:57 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	40
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
dl	40
loc	40
rs	10
c	0
b	0
f	0
wmc	4
lcom	1
cbo	4

4 Methods

Rating	Name	Duplication	Size	Complexity
A	let()	5	5	1
A	it_is_initializable()	4	4	1
A	it_yields_fees()	14	14	1
A	it_can_be_empty()	11	11	1

How to fix Duplicated Code

<?php

namespace spec\Scriptotek\Alma\Users;

use PhpSpec\ObjectBehavior;
use Scriptotek\Alma\Client as AlmaClient;
use Scriptotek\Alma\Users\Fee;
use Scriptotek\Alma\Users\Fees;
use Scriptotek\Alma\Users\User;
use spec\Scriptotek\Alma\SpecHelper;

class FeesSpec extends ObjectBehavior

{
    public function let(AlmaClient $client, User $user)
    {
        $user->id = '123435';
        $this->beConstructedWith($client, $user);
    }

    public function it_is_initializable()
    {
        $this->shouldHaveType(Fees::class);
    }

    public function it_yields_fees(AlmaClient $client)
    {
        $client->getJSON('/users/123435/fees')
            ->shouldBeCalled()
            ->willReturn(SpecHelper::getDummyData('fees_response.json'));

        $this->total_sum->shouldBe(750);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $this->rewind();
        $this->valid()->shouldBe(true);
        $this->current()->shouldBeAnInstanceOf(Fee::class);

        $this->shouldHaveCount(1);
    }

    public function it_can_be_empty(AlmaClient $client)
    {
        $client->getJSON('/users/123435/fees')
            ->shouldBeCalled()
            ->willReturn(SpecHelper::getDummyData('zero_fees_response.json'));

        $this->rewind();
        $this->valid()->shouldBe(false);

        $this->shouldHaveCount(0);
    }
}


1		<?php
2
3		namespace spec\Scriptotek\Alma\Users;
4
5		use PhpSpec\ObjectBehavior;
6		use Scriptotek\Alma\Client as AlmaClient;
7		use Scriptotek\Alma\Users\Fee;
8		use Scriptotek\Alma\Users\Fees;
9		use Scriptotek\Alma\Users\User;
10		use spec\Scriptotek\Alma\SpecHelper;
11
12	View Code Duplication	class FeesSpec extends ObjectBehavior
		0 ignored issues – show Duplication introduced 2018-07-30 16:45 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13		{
14		public function let(AlmaClient $client, User $user)
15		{
16		$user->id = '123435';
17		$this->beConstructedWith($client, $user);
18		}
19
20		public function it_is_initializable()
21		{
22		$this->shouldHaveType(Fees::class);
23		}
24
25		public function it_yields_fees(AlmaClient $client)
26		{
27		$client->getJSON('/users/123435/fees')
28		->shouldBeCalled()
29		->willReturn(SpecHelper::getDummyData('fees_response.json'));
30
31		$this->total_sum->shouldBe(750);
		0 ignored issues – show Documentation introduced 2018-07-30 16:45 UTC by Report Bug Copy Issue Report The property `total_sum` does not exist on `object<spec\Scriptotek\Alma\Users\FeesSpec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
32
33		$this->rewind();
34		$this->valid()->shouldBe(true);
35		$this->current()->shouldBeAnInstanceOf(Fee::class);
36
37		$this->shouldHaveCount(1);
38		}
39
40		public function it_can_be_empty(AlmaClient $client)
41		{
42		$client->getJSON('/users/123435/fees')
43		->shouldBeCalled()
44		->willReturn(SpecHelper::getDummyData('zero_fees_response.json'));
45
46		$this->rewind();
47		$this->valid()->shouldBe(false);
48
49		$this->shouldHaveCount(0);
50		}
51		}
52

scriptotek / php-alma-client

FeesSpec A last analyzed 2021-04-14 14:57 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

FeesSpec A
last analyzed 2021-04-14 14:57 UTC