RowSpec - Code Metrics - scriptotek/php-alma-client - Measure and Improve Code Quality continuously with Scrutinizer

RowSpec A
last analyzed 2021-04-14 14:57 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

Metric	Value
dl	0
loc	58
rs	10
c	0
b	0
f	0
wmc	8
lcom	0
cbo	2

8 Methods

Rating	Name	Size	Complexity
A	let()	14	1
A	it_is_initializable()	4	1
A	it_should_have_columns_accessible_by_name()	6	1
A	it_should_have_columns_accessible_by_array_key()	6	1
A	it_should_have_columns_accessible_by_array_index()	6	1
A	it_should_be_traversable()	4	1
A	it_should_be_countable()	4	1
A	it_should_be_serializable_as_array()	4	1

<?php

namespace spec\Scriptotek\Alma\Analytics;

use Danmichaelo\QuiteSimpleXMLElement\QuiteSimpleXMLElement;
use PhpSpec\ObjectBehavior;
use Scriptotek\Alma\Analytics\Row;

class RowSpec extends ObjectBehavior
{
    public function let()
    {
        // We need to be able to handle missing data, so let's assume we have
        // a report with three columns, but that we for this row only got data
        // for two of the columns (data missing for Column2).
        $xml = QuiteSimpleXMLElement::make('<Row xmlns="urn:schemas-microsoft-com:xml-analysis:rowset">
                <Column0>0</Column0>
                <Column1>col1 content</Column1>
                <Column3>col3 content</Column3>
            </Row>');
        $xml->registerXPathNamespace('rowset', 'urn:schemas-microsoft-com:xml-analysis:rowset');
        $headers = ['mms_id', 'title', 'isbn'];
        $this->beConstructedWith($xml, $headers);
    }

    public function it_is_initializable()
    {
        $this->shouldHaveType(Row::class);
    }

    public function it_should_have_columns_accessible_by_name()
    {
        $this->mms_id->shouldBe('col1 content');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->title->shouldBe(null);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->isbn->shouldBe('col3 content');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function it_should_have_columns_accessible_by_array_key()
    {
        $this['mms_id']->shouldBe('col1 content');
        $this['title']->shouldBe(null);
        $this['isbn']->shouldBe('col3 content');
    }

    public function it_should_have_columns_accessible_by_array_index()
    {
        $this[0]->shouldBe('col1 content');
        $this[1]->shouldBe(null);
        $this[2]->shouldBe('col3 content');
    }

    public function it_should_be_traversable()
    {
        $this->shouldBeAnInstanceOf('Traversable');
    }

    public function it_should_be_countable()
    {
        $this->shouldHaveCount(3);
    }

    public function it_should_be_serializable_as_array()
    {
        $this->toArray()->shouldBeArray();
    }
}


1			<?php
2
3			namespace spec\Scriptotek\Alma\Analytics;
4
5			use Danmichaelo\QuiteSimpleXMLElement\QuiteSimpleXMLElement;
6			use PhpSpec\ObjectBehavior;
7			use Scriptotek\Alma\Analytics\Row;
8
9			class RowSpec extends ObjectBehavior
10			{
11			public function let()
12			{
13			// We need to be able to handle missing data, so let's assume we have
14			// a report with three columns, but that we for this row only got data
15			// for two of the columns (data missing for Column2).
16			$xml = QuiteSimpleXMLElement::make('<Row xmlns="urn:schemas-microsoft-com:xml-analysis:rowset">
17			<Column0>0</Column0>
18			<Column1>col1 content</Column1>
19			<Column3>col3 content</Column3>
20			</Row>');
21			$xml->registerXPathNamespace('rowset', 'urn:schemas-microsoft-com:xml-analysis:rowset');
22			$headers = ['mms_id', 'title', 'isbn'];
23			$this->beConstructedWith($xml, $headers);
24			}
25
26			public function it_is_initializable()
27			{
28			$this->shouldHaveType(Row::class);
29			}
30
31			public function it_should_have_columns_accessible_by_name()
32			{
33			$this->mms_id->shouldBe('col1 content');
			0 ignored issues – show Documentation introduced 2016-11-24 19:52 UTC by Report Bug Copy Issue Report The property `mms_id` does not exist on `object<spec\Scriptotek\Alma\Analytics\RowSpec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
34			$this->title->shouldBe(null);
			0 ignored issues – show Documentation introduced 2017-01-13 20:57 UTC by Report Bug Copy Issue Report The property `title` does not exist on `object<spec\Scriptotek\Alma\Analytics\RowSpec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
35			$this->isbn->shouldBe('col3 content');
			0 ignored issues – show Documentation introduced 2017-01-13 20:57 UTC by Report Bug Copy Issue Report The property `isbn` does not exist on `object<spec\Scriptotek\Alma\Analytics\RowSpec>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
36			}
37
38			public function it_should_have_columns_accessible_by_array_key()
39			{
40			$this['mms_id']->shouldBe('col1 content');
41			$this['title']->shouldBe(null);
42			$this['isbn']->shouldBe('col3 content');
43			}
44
45			public function it_should_have_columns_accessible_by_array_index()
46			{
47			$this[0]->shouldBe('col1 content');
48			$this[1]->shouldBe(null);
49			$this[2]->shouldBe('col3 content');
50			}
51
52			public function it_should_be_traversable()
53			{
54			$this->shouldBeAnInstanceOf('Traversable');
55			}
56
57			public function it_should_be_countable()
58			{
59			$this->shouldHaveCount(3);
60			}
61
62			public function it_should_be_serializable_as_array()
63			{
64			$this->toArray()->shouldBeArray();
65			}
66			}
67

scriptotek / php-alma-client

RowSpec A last analyzed 2021-04-14 14:57 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

Duplication Side-by-Side

Filter issues like

RowSpec A
last analyzed 2021-04-14 14:57 UTC